Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117078/?format=api
{ "id": 117078, "url": "https://patches.dpdk.org/api/patches/117078/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220928191945.1630990-3-abdullah.sevincer@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220928191945.1630990-3-abdullah.sevincer@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220928191945.1630990-3-abdullah.sevincer@intel.com", "date": "2022-09-28T19:19:45", "name": "[v6,3/3] event/dlb2: optimize credit allocations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "393fac168b266bbf93f1f08acbcd621c3318982f", "submitter": { "id": 2843, "url": "https://patches.dpdk.org/api/people/2843/?format=api", "name": "Sevincer, Abdullah", "email": "abdullah.sevincer@intel.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220928191945.1630990-3-abdullah.sevincer@intel.com/mbox/", "series": [ { "id": 24889, "url": "https://patches.dpdk.org/api/series/24889/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24889", "date": "2022-09-28T19:19:43", "name": "[v6,1/3] event/dlb2: add producer port probing optimization", "version": 6, "mbox": "https://patches.dpdk.org/series/24889/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/117078/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/117078/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BB608A00C4;\n\tWed, 28 Sep 2022 21:20:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3F58D42825;\n\tWed, 28 Sep 2022 21:19:59 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 1381942686\n for <dev@dpdk.org>; Wed, 28 Sep 2022 21:19:55 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Sep 2022 12:19:55 -0700", "from txanpdk02.an.intel.com ([10.123.117.76])\n by fmsmga006.fm.intel.com with ESMTP; 28 Sep 2022 12:19:55 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1664392796; x=1695928796;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=fEcc1VsWRe+dkbfKigdMRZ7ibY+2QiTT5nCouS0SBYQ=;\n b=c1+8141rtAEQjZa1COOHbhcvBtFaec2V96imMkw9hodIdLtg3kgHcNGn\n VXqRUELE85O2aC2Kc+rDNDN2YAoAwqI0AraU7LA2RPRwgcJOqSprhGJl8\n f1wudCDHz5un+efMxo8gMw2tlVK8HB1UUmoTuxZXIp7HSMkhxRQttNSo1\n luSn8WrusLn1IbnHce0gWMc3YdrRy0N13TwAZHRlrMoAsQQitv2Ve6GEp\n KX18xU8ewwRjcBU7TytBhRggOgsoIF2WY/5HI8uLU23y+t6bor7ISzhyU\n nrIu7I+Wily6xd+TADoGNL/pPGRrkZd1/x4Oj99dDlhO1OheIlpi6LulW Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10484\"; a=\"387977337\"", "E=Sophos;i=\"5.93,352,1654585200\"; d=\"scan'208\";a=\"387977337\"", "E=McAfee;i=\"6500,9779,10484\"; a=\"867087045\"", "E=Sophos;i=\"5.93,352,1654585200\"; d=\"scan'208\";a=\"867087045\"" ], "X-ExtLoop1": "1", "From": "Abdullah Sevincer <abdullah.sevincer@intel.com>", "To": "dev@dpdk.org", "Cc": "jerinj@marvell.com,\n\tAbdullah Sevincer <abdullah.sevincer@intel.com>", "Subject": "[PATCH v6 3/3] event/dlb2: optimize credit allocations", "Date": "Wed, 28 Sep 2022 14:19:45 -0500", "Message-Id": "<20220928191945.1630990-3-abdullah.sevincer@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220928191945.1630990-1-abdullah.sevincer@intel.com>", "References": "<20220927014204.1401746-1-abdullah.sevincer@intel.com>\n <20220928191945.1630990-1-abdullah.sevincer@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This commit implements the changes required for using suggested\nport type hint feature. Each port uses different credit quanta\nbased on port type specified using port configuration flags.\n\nEach port has separate quanta defined in dlb2_priv.h\nProducer and consumer ports will need larger quanta value to reduce number\nof credit calls they make. Workers can use small quanta as they mostly\nwork out of locally cached credits and don't request/return credits often.\n\nSigned-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>\n---\n drivers/event/dlb2/dlb2.c | 20 +++++++++++++++++++-\n 1 file changed, 19 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c\nindex 4dd1d55ddc..164ebbcfe2 100644\n--- a/drivers/event/dlb2/dlb2.c\n+++ b/drivers/event/dlb2/dlb2.c\n@@ -1965,8 +1965,8 @@ dlb2_eventdev_port_setup(struct rte_eventdev *dev,\n {\n \tstruct dlb2_eventdev *dlb2;\n \tstruct dlb2_eventdev_port *ev_port;\n-\tint ret;\n \tuint32_t hw_credit_quanta, sw_credit_quanta;\n+\tint ret;\n \n \tif (dev == NULL || port_conf == NULL) {\n \t\tDLB2_LOG_ERR(\"Null parameter\\n\");\n@@ -2067,6 +2067,24 @@ dlb2_eventdev_port_setup(struct rte_eventdev *dev,\n \tev_port->inflight_credits = 0;\n \tev_port->dlb2 = dlb2; /* reverse link */\n \n+\t/* Default for worker ports */\n+\tsw_credit_quanta = dlb2->sw_credit_quanta;\n+\thw_credit_quanta = dlb2->hw_credit_quanta;\n+\n+\tif (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_HINT_PRODUCER) {\n+\t\t/* Producer type ports. Mostly enqueue */\n+\t\tsw_credit_quanta = DLB2_SW_CREDIT_P_QUANTA_DEFAULT;\n+\t\thw_credit_quanta = DLB2_SW_CREDIT_P_BATCH_SZ;\n+\t}\n+\tif (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_HINT_CONSUMER) {\n+\t\t/* Consumer type ports. Mostly dequeue */\n+\t\tsw_credit_quanta = DLB2_SW_CREDIT_C_QUANTA_DEFAULT;\n+\t\thw_credit_quanta = DLB2_SW_CREDIT_C_BATCH_SZ;\n+\t}\n+\tev_port->credit_update_quanta = sw_credit_quanta;\n+\tev_port->qm_port.hw_credit_quanta = hw_credit_quanta;\n+\n+\n \t/* Tear down pre-existing port->queue links */\n \tif (dlb2->run_state == DLB2_RUN_STATE_STOPPED)\n \t\tdlb2_port_link_teardown(dlb2, &dlb2->ev_ports[ev_port_id]);\n", "prefixes": [ "v6", "3/3" ] }