Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117037/?format=api
{ "id": 117037, "url": "https://patches.dpdk.org/api/patches/117037/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220928052516.1279442-16-g.singh@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220928052516.1279442-16-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220928052516.1279442-16-g.singh@nxp.com", "date": "2022-09-28T05:25:16", "name": "[15/15] net/dpaa: fix buffer free in slow path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a6845755762c34124c8f7ee00d56930371f61f20", "submitter": { "id": 1068, "url": "https://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220928052516.1279442-16-g.singh@nxp.com/mbox/", "series": [ { "id": 24872, "url": "https://patches.dpdk.org/api/series/24872/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24872", "date": "2022-09-28T05:25:01", "name": "DPAA and DPAA2 driver changes", "version": 1, "mbox": "https://patches.dpdk.org/series/24872/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/117037/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/117037/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0FE7AA00C2;\n\tWed, 28 Sep 2022 07:27:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DE8C142BCF;\n\tWed, 28 Sep 2022 07:26:07 +0200 (CEST)", "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2069.outbound.protection.outlook.com [40.107.22.69])\n by mails.dpdk.org (Postfix) with ESMTP id 1CA8742BCC;\n Wed, 28 Sep 2022 07:26:06 +0200 (CEST)", "from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14)\n by AM9PR04MB8988.eurprd04.prod.outlook.com (2603:10a6:20b:40b::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep\n 2022 05:26:04 +0000", "from AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::14d0:4458:d6ec:b8b1]) by AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::14d0:4458:d6ec:b8b1%7]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022\n 05:26:04 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=M5UtA57vshfodOlZO1LZY03e2tQJHFN+z0lXYPoHj/vZuZyztu90Mepk5KdME70M+rJAP1qAvifcGS1ClzlZSYUW6fYX0R+ZbXN4DqCXHsyJkImJSGR6Chmg6cC/tWKCQD5BpYQGju1aWAPNY2UxNsIQbJpuLhfbjUW54bZTfu3/l0STCCgQB9yZ274sSF/rYQ5h4Pib8U16EXlJfBuVsynnC+OrsmEDDz/TRGY6D64F0+EQEbdPWSOqlYqC5jqyWs4xIqi33nlRAKE3ZG34rQkrd0Q4ZrYMGzEHm2EEW27F63K2ROLR/FPmrxzhTUVXxWMMfXgpY3nzu+SpP4GFIA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=r+QpVLrLpeO4VxgrvGUdY2yYiUsvDbVpkzG7RqjN2Nc=;\n b=ZzWK6R0IA/VbaQe09UQtrHk2+9uqAtcT1MXth/ezfqTmcBoD3ajU4IirJAaBLhaKo8O+AXvKBQOTBPGskuXJ+N+HsyzIxo3QEI+OcbcP2JXJI5ZytwZ0AuWXc797nUOdlP1obdS2wySqeF8g3AGxM9URG9uNZghKGR0eUItLIYvTUa/h3r1M7omKPnpZjVhwi3fkAxb1KeIHS12vZTHJ+d+Ar7hIpdtCVEtpnjswcDrqAIkyG9QmcJc3b8P/Rp0fpBL43QoRdjBIQPTDOx/ngBZw0ZCf6br88yGaXGJGsBjr7YgsHJE2jAzc/8QveU1se1z+vJKTXqlMZCa4WcFBuQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=r+QpVLrLpeO4VxgrvGUdY2yYiUsvDbVpkzG7RqjN2Nc=;\n b=KdgkuQBJm9v7ODnjh+TLgCd8TZ03twSVloHBAXGxW86YahOXxmYe3/d6pWlT84SONmXxGQyc/uHW6bd/zeaGz5hozpBhTrxxcCamMAzpBqcsRqyc3qk/P73KK14ah3d2xL0xlpmZHF5s3u0138kwOb0SJU81a1hdDEo3hynYz4s=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;", "From": "Gagandeep Singh <g.singh@nxp.com>", "To": "ferruh.yigit@amd.com,\n\tdev@dpdk.org", "Cc": "Gagandeep Singh <g.singh@nxp.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 15/15] net/dpaa: fix buffer free in slow path", "Date": "Wed, 28 Sep 2022 10:55:16 +0530", "Message-Id": "<20220928052516.1279442-16-g.singh@nxp.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220928052516.1279442-1-g.singh@nxp.com>", "References": "<20220928052516.1279442-1-g.singh@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SGBP274CA0015.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::27)\n To AS8PR04MB8198.eurprd04.prod.outlook.com\n (2603:10a6:20b:3b0::14)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AS8PR04MB8198:EE_|AM9PR04MB8988:EE_", "X-MS-Office365-Filtering-Correlation-Id": "69ef2dbc-ca78-491a-7576-08daa111f02d", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n OjUhNcKaRoq9A3TPe4jnE0KIe7J7QcLpMFgnu7WTmtecTWlGGlX5dcnW0wGkKbpn4Mv3utnaiJcmn5cZw+Uf5zDEaXV9tjxHS3Izul6UQZThyx9oalnQmtEXvRuE5tZkmATcHbIqbSGCnQ+GFxdd82tkwN5nCWligciNetyF16+N2uQEnB8ZA9Q9Xbzv14atXnexibCyNsMNXBJ1I6XRhHi78Fpb6q9ue+kxQGTvJbnnrZhKJbNOjPimy5VqjrNu3Ncz1FFDwB+XaqF9JXC/IpqOutTvXU06rUKkYbqvpec/nWwFRbMo4Tu6aM/MLFAH/xk2vgdDowzrD0g/nqzPvK5sZ4jSv6L4jjId6EzP45kdk0UJ3+xwAkgiXPUaONCxHNx9Jsf5JAP7jXQExIRzWGjgRdyFdFWJQYDlD0J2mi081RECp9Zz7hVo7fWFG4XdgoyYPQRVl0j3xPIJ0cde2jFlgdiJj6lbkMoUpat0JQ+HR/vKdsD161IM5a0DWckxSDfWBsGBij5ONisQRpuc1jvmtXLn4BoejX7zKrKHsmVqZsPD3qKmM0Concyqk0MTr88APVsdJl5chrcWuObA4R/4tMHow4FzFGdPWTCE//d+7czaPXboBLT7yKnPWmcK5I9rISq2yrOCwtvY9sQYRck0F0c5N1xFAxD+hc8aRn0K9yH7KDBnDRwXN74GsfJWWrjdeB/zXNZJl/c5NwjDNQBu1ePYuttk4KX1D3peUzljCVB82kBUGhaUgtoFtoRB258wV4isWcrjw6Vu9n6YJA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(366004)(396003)(451199015)(26005)(52116002)(6512007)(478600001)(6506007)(6666004)(83380400001)(2616005)(186003)(1076003)(2906002)(5660300002)(8936002)(316002)(6486002)(41300700001)(66556008)(66476007)(4326008)(8676002)(66946007)(36756003)(38350700002)(38100700002)(86362001);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n itrQ0i3TmHX33Slf0lgq6HcHbos+2O7NPVMyIXOGu/H656zOsGZFf2PPbrebfEgrRiNHdqIjX/FXDEYmRoNvql/V0YPHF45tt1bJapg/bd7voPb7BRnplVdlrP2xj+tWPc+pZNY+QQ060bBWCWoq2UVxCRo7q9NA05zLHjoltNH9GlOZ03jz1m3JdFWKgzXSUH5iu8BAMSRnLG3sOhyOnZEQMm87uKW4XteZajIs8dBjCEKrpBMywtNiVkfB0gMTzeaCleIGQBnTF/57mmCFHcwL81g+9LjbEtzYDIQlTFtEwqzUuyXiqmulETs5/Xchx0AeQkEGHfQc0caCYWCHE9xruaB7HJ7eggKwPg44Jxkrh05RjF+C+CYfvVXJJlJgLjSwVyezmBJmiv7QEdzCeXVhBM3j2xutgj6m5vGYmagEmQ+pIrr/uFqBuQBxgag6mmybmR2ajNgta6eS704LDTgxhVvV5ON748LMNPDoyvYTqTmuki8cKBFmU/FLD16c2t/6zQmaKLFuQhr9mAllRrZQUquPBFbKYkI/gVF6uky5UK2OSiVs24x8hRxMyfwEqUph9md39Hnq04fWCI7FMn3ykOofMSeQSdT94jxr+ZqxkrzeyKDK+B85X2CJUVgGqxrOgmdf3Onwb3tTh6vUL9k0ZHQtQsSfAXnTQ3nbftV5xd+o9McGUHZHhoFXBtPRQMd6xi9vRfeywQGFmxXuKsDSG0KTvfMLIy7APAq+uVPQiXfSq4OiCXHFS7cB+OL7Cb0f5s/4XXh8lxMLr785x3H0Q2+RxX4TQaobN/sBw/XjZeLOJGfPidnOvqzJ1fQ+22K+teZBd/5bQyvQZLvzSB5PoX9a14BhuXtb3S2+slNrITWt1DMqb+4U2mFFi5BldOF34XU4EHjLqUJN0gYK3M5D4Tymm87d+XukCeuyk3PTVLkXEOlf/MZMMgYRTXmrK3p/njjpIG4P6lIn/qAgv4FZvzN6N0D0sNSGx9B54+jLlXchRGiXTaVHXantPymflaNlPJsWJvwwH1uNsrjlU7+D+WbP8HB4s+eAtwsU/cSSiyTTDHt1K9vHp5CXHMZQ5rSv9e00vsM4QedgZKyO6WN59wsr7KLGiAkF6JHtFQH0NpttFrOGF9TpTwVxHtLhdSpCqIUWmpOg5x7VMWoeJw9PRzcbNXn+9F9/oMGjr7S3/IHJreWmFOTskV8KMIMUW2SN+Cr52W9YDhOJdkenH6dO/aqM0gG7bciJqx8dt9iU4l/Jl+w/XkyLsOlmbtAmC8SWOLFNi+wG0vB4I7UJ7pzmSZi3NQjDO4xcf1Mj0EiZEGyW72oc3R/b/3AEmlAcQKWjfbLybdoclcYu1LXkYrZ8zF4OKTV5bmrmr5OibIz96hLkCNPJEXQkZ/OR1iiwb8IZgX29sWwMyFw9MaS1DPbMBAmOG2vK7L/Vay0n27yVcwbjQSfYF5hKwQUjwtn7axKyCUP3DDNRtXrp7C9qWCUrXbLLWEP6T2to2B7DtSbxfN40amVlby35KIyrZ5Q2WTJJcqAGrpMIRl/bPW5MaqdNWvHwVMcL8SRN7p6+e3fUj8bdyGjqwTHgicoWw7Wa", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 69ef2dbc-ca78-491a-7576-08daa111f02d", "X-MS-Exchange-CrossTenant-AuthSource": "AS8PR04MB8198.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Sep 2022 05:26:04.4561 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n hf5kjBvhm0hsb1kvLUfVL71Fyg8SMSiX8Yup+hZjUG9TiFPChRFrdN5/56hfYKuy", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM9PR04MB8988", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Adding a check in slow path to free those buffers\nwhich are not external.\n\nFixes: 9124e65dd3eb (\"net/dpaa: enable Tx queue taildrop\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/net/dpaa/dpaa_rxtx.c | 23 ++++++++---------------\n 1 file changed, 8 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c\nindex 4d285b4f38..ce4f3d6c85 100644\n--- a/drivers/net/dpaa/dpaa_rxtx.c\n+++ b/drivers/net/dpaa/dpaa_rxtx.c\n@@ -455,7 +455,7 @@ dpaa_free_mbuf(const struct qm_fd *fd)\n \tbp_info = DPAA_BPID_TO_POOL_INFO(fd->bpid);\n \tformat = (fd->opaque & DPAA_FD_FORMAT_MASK) >> DPAA_FD_FORMAT_SHIFT;\n \tif (unlikely(format == qm_fd_sg)) {\n-\t\tstruct rte_mbuf *first_seg, *prev_seg, *cur_seg, *temp;\n+\t\tstruct rte_mbuf *first_seg, *cur_seg;\n \t\tstruct qm_sg_entry *sgt, *sg_temp;\n \t\tvoid *vaddr, *sg_vaddr;\n \t\tint i = 0;\n@@ -469,32 +469,25 @@ dpaa_free_mbuf(const struct qm_fd *fd)\n \t\tsgt = vaddr + fd_offset;\n \t\tsg_temp = &sgt[i++];\n \t\thw_sg_to_cpu(sg_temp);\n-\t\ttemp = (struct rte_mbuf *)\n-\t\t\t((char *)vaddr - bp_info->meta_data_size);\n \t\tsg_vaddr = DPAA_MEMPOOL_PTOV(bp_info,\n \t\t\t\t\t\tqm_sg_entry_get64(sg_temp));\n-\n \t\tfirst_seg = (struct rte_mbuf *)((char *)sg_vaddr -\n \t\t\t\t\t\tbp_info->meta_data_size);\n \t\tfirst_seg->nb_segs = 1;\n-\t\tprev_seg = first_seg;\n \t\twhile (i < DPAA_SGT_MAX_ENTRIES) {\n \t\t\tsg_temp = &sgt[i++];\n \t\t\thw_sg_to_cpu(sg_temp);\n-\t\t\tsg_vaddr = DPAA_MEMPOOL_PTOV(bp_info,\n+\t\t\tif (sg_temp->bpid != 0xFF) {\n+\t\t\t\tbp_info = DPAA_BPID_TO_POOL_INFO(sg_temp->bpid);\n+\t\t\t\tsg_vaddr = DPAA_MEMPOOL_PTOV(bp_info,\n \t\t\t\t\t\tqm_sg_entry_get64(sg_temp));\n-\t\t\tcur_seg = (struct rte_mbuf *)((char *)sg_vaddr -\n+\t\t\t\tcur_seg = (struct rte_mbuf *)((char *)sg_vaddr -\n \t\t\t\t\t\t bp_info->meta_data_size);\n-\t\t\tfirst_seg->nb_segs += 1;\n-\t\t\tprev_seg->next = cur_seg;\n-\t\t\tif (sg_temp->final) {\n-\t\t\t\tcur_seg->next = NULL;\n-\t\t\t\tbreak;\n+\t\t\t\trte_pktmbuf_free_seg(cur_seg);\n \t\t\t}\n-\t\t\tprev_seg = cur_seg;\n+\t\t\tif (sg_temp->final)\n+\t\t\t\tbreak;\n \t\t}\n-\n-\t\trte_pktmbuf_free_seg(temp);\n \t\trte_pktmbuf_free_seg(first_seg);\n \t\treturn 0;\n \t}\n", "prefixes": [ "15/15" ] }