Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116970/?format=api
{ "id": 116970, "url": "https://patches.dpdk.org/api/patches/116970/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220927113608.3015654-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220927113608.3015654-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220927113608.3015654-1-david.marchand@redhat.com", "date": "2022-09-27T11:36:08", "name": "vhost: remove deprecated helpers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f7b10ac507ea5c551c3f0481e158f60b846057c5", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220927113608.3015654-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 24863, "url": "https://patches.dpdk.org/api/series/24863/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24863", "date": "2022-09-27T11:36:08", "name": "vhost: remove deprecated helpers", "version": 1, "mbox": "https://patches.dpdk.org/series/24863/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/116970/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/116970/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A498BA00C2;\n\tTue, 27 Sep 2022 13:37:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8AF8E41133;\n\tTue, 27 Sep 2022 13:37:06 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 09C5740694\n for <dev@dpdk.org>; Tue, 27 Sep 2022 13:37:04 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-346-yOM5M4m_PNmad5lx403BEg-1; Tue, 27 Sep 2022 07:37:01 -0400", "from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com\n [10.11.54.10])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34821805AC7;\n Tue, 27 Sep 2022 11:37:01 +0000 (UTC)", "from localhost.localdomain (unknown [10.40.194.61])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 2614A492B05;\n Tue, 27 Sep 2022 11:37:00 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1664278624;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=FBG6eP1Eu75gm+qDl5vUj1iOzpysYefhkrPCqDekjDQ=;\n b=ckwrpWXw88qDJ6T1eTMxetZnG7hdZkzpOfH7TT0u8nYtZuVmRAgCnSW/zUM3dvOicRW1qI\n BVkxqBqx7Z7xgrmbUEa8PPedfg3pa5Ta3kevapfX2n6qq5xNEz1eN1meXk2j+gGb73dRz0\n WZTG13cnRDIeI5uuQbTCHLtIF/wOtk4=", "X-MC-Unique": "yOM5M4m_PNmad5lx403BEg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>, Ray Kinsella <mdr@ashroe.eu>", "Subject": "[PATCH] vhost: remove deprecated helpers", "Date": "Tue, 27 Sep 2022 13:36:08 +0200", "Message-Id": "<20220927113608.3015654-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.10", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Those helpers have been marked as deprecated for a long time and have\ndocumented equivalent helpers.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n doc/guides/rel_notes/release_22_11.rst | 3 ++\n lib/vhost/rte_vhost.h | 55 --------------------------\n lib/vhost/version.map | 2 -\n lib/vhost/vhost.c | 11 ------\n 4 files changed, 3 insertions(+), 68 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst\nindex 684bf74596..7f61cdf56a 100644\n--- a/doc/guides/rel_notes/release_22_11.rst\n+++ b/doc/guides/rel_notes/release_22_11.rst\n@@ -204,6 +204,9 @@ API Changes\n Names for the telemetry commands are now similarly limited.\n The parameters for telemetry commands are unaffected by this change.\n \n+* vhost: Removed deprecated ``rte_vhost_gpa_to_vva`` and\n+ ``rte_vhost_get_queue_num`` helpers.\n+\n * raw/ifgpa: The function ``rte_pmd_ifpga_get_pci_bus`` has been removed.\n \n \ndiff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h\nindex 617425e8d6..bb7d86a432 100644\n--- a/lib/vhost/rte_vhost.h\n+++ b/lib/vhost/rte_vhost.h\n@@ -354,44 +354,6 @@ struct rte_vhost_stat_name {\n /**\n * Convert guest physical address to host virtual address\n *\n- * This function is deprecated because unsafe.\n- * New rte_vhost_va_from_guest_pa() should be used instead to ensure\n- * guest physical ranges are fully and contiguously mapped into\n- * process virtual address space.\n- *\n- * @param mem\n- * the guest memory regions\n- * @param gpa\n- * the guest physical address for querying\n- * @return\n- * the host virtual address on success, 0 on failure\n- */\n-__rte_deprecated\n-static __rte_always_inline uint64_t\n-rte_vhost_gpa_to_vva(struct rte_vhost_memory *mem, uint64_t gpa)\n-{\n-\tstruct rte_vhost_mem_region *reg;\n-\tuint32_t i;\n-\n-\tfor (i = 0; i < mem->nregions; i++) {\n-\t\treg = &mem->regions[i];\n-\t\tif (gpa >= reg->guest_phys_addr &&\n-\t\t gpa < reg->guest_phys_addr + reg->size) {\n-\t\t\treturn gpa - reg->guest_phys_addr +\n-\t\t\t reg->host_user_addr;\n-\t\t}\n-\t}\n-\n-\treturn 0;\n-}\n-\n-/**\n- * Convert guest physical address to host virtual address safely\n- *\n- * This variant of rte_vhost_gpa_to_vva() takes care all the\n- * requested length is mapped and contiguous in process address\n- * space.\n- *\n * @param mem\n * the guest memory regions\n * @param gpa\n@@ -696,23 +658,6 @@ int rte_vhost_get_mtu(int vid, uint16_t *mtu);\n */\n int rte_vhost_get_numa_node(int vid);\n \n-/**\n- * @deprecated\n- * Get the number of queues the device supports.\n- *\n- * Note this function is deprecated, as it returns a queue pair number,\n- * which is vhost specific. Instead, rte_vhost_get_vring_num should\n- * be used.\n- *\n- * @param vid\n- * vhost device ID\n- *\n- * @return\n- * The number of queues, 0 on failure\n- */\n-__rte_deprecated\n-uint32_t rte_vhost_get_queue_num(int vid);\n-\n /**\n * Get the number of vrings the device supports.\n *\ndiff --git a/lib/vhost/version.map b/lib/vhost/version.map\nindex 18574346d5..7a00b65740 100644\n--- a/lib/vhost/version.map\n+++ b/lib/vhost/version.map\n@@ -41,14 +41,12 @@ DPDK_23 {\n \trte_vhost_get_mtu;\n \trte_vhost_get_negotiated_features;\n \trte_vhost_get_numa_node;\n-\trte_vhost_get_queue_num;\n \trte_vhost_get_vdpa_device;\n \trte_vhost_get_vhost_ring_inflight;\n \trte_vhost_get_vhost_vring;\n \trte_vhost_get_vring_base;\n \trte_vhost_get_vring_base_from_inflight;\n \trte_vhost_get_vring_num;\n-\trte_vhost_gpa_to_vva;\n \trte_vhost_log_used_vring;\n \trte_vhost_log_write;\n \trte_vhost_rx_queue_count;\ndiff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c\nindex aa671f47a3..abf17eb509 100644\n--- a/lib/vhost/vhost.c\n+++ b/lib/vhost/vhost.c\n@@ -859,17 +859,6 @@ rte_vhost_get_numa_node(int vid)\n #endif\n }\n \n-uint32_t\n-rte_vhost_get_queue_num(int vid)\n-{\n-\tstruct virtio_net *dev = get_device(vid);\n-\n-\tif (dev == NULL)\n-\t\treturn 0;\n-\n-\treturn dev->nr_vring / 2;\n-}\n-\n uint16_t\n rte_vhost_get_vring_num(int vid)\n {\n", "prefixes": [] }