Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116914/?format=api
{ "id": 116914, "url": "https://patches.dpdk.org/api/patches/116914/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220926225536.1387161-3-abdullah.sevincer@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220926225536.1387161-3-abdullah.sevincer@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220926225536.1387161-3-abdullah.sevincer@intel.com", "date": "2022-09-26T22:55:36", "name": "[v3,3/3] event/dlb2: optimize credit allocations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "393fac168b266bbf93f1f08acbcd621c3318982f", "submitter": { "id": 2843, "url": "https://patches.dpdk.org/api/people/2843/?format=api", "name": "Sevincer, Abdullah", "email": "abdullah.sevincer@intel.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220926225536.1387161-3-abdullah.sevincer@intel.com/mbox/", "series": [ { "id": 24841, "url": "https://patches.dpdk.org/api/series/24841/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24841", "date": "2022-09-26T22:55:34", "name": "[v3,1/3] event/dlb2: add producer port probing optimization", "version": 3, "mbox": "https://patches.dpdk.org/series/24841/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/116914/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/116914/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 833A9A00C2;\n\tTue, 27 Sep 2022 00:55:57 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 465B6427FF;\n\tTue, 27 Sep 2022 00:55:47 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 01DE84113F\n for <dev@dpdk.org>; Tue, 27 Sep 2022 00:55:44 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Sep 2022 15:55:44 -0700", "from txanpdk02.an.intel.com ([10.123.117.76])\n by orsmga004.jf.intel.com with ESMTP; 26 Sep 2022 15:55:43 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1664232945; x=1695768945;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=fEcc1VsWRe+dkbfKigdMRZ7ibY+2QiTT5nCouS0SBYQ=;\n b=JKOCcpYQ8i9XH5YghKlQ0bkFjVD+mfUX53wUL6K/HdHJW3wCqRsok9hr\n A2ZZcWWfZPyUwuboKQ7yiVx6nwaNH/TqLv3d4xn0RfCj1Jd/VCm6UXbXT\n wQ68YCAeKRAoPOK02plibJ2ar/1pLKDaYw5dZuJbabWfRtP1rY7gSKYwJ\n m84l3fMgkPomVp/6jATfdiTE+rY46fSjLpZN5pN5UNvTyy2INsdDOHKVa\n r2vP3uidmubyaoG4AzZ7XGyZvulFtJZH5xeC7u7MES/p9R8XOl4s8jUS8\n aFwZux0YpFpbDpx0XCkDlT5eMPEb7z4scW8wVVKAt72dBuV4BKTTWJVA7 Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10482\"; a=\"302067155\"", "E=Sophos;i=\"5.93,347,1654585200\"; d=\"scan'208\";a=\"302067155\"", "E=McAfee;i=\"6500,9779,10482\"; a=\"746807162\"", "E=Sophos;i=\"5.93,347,1654585200\"; d=\"scan'208\";a=\"746807162\"" ], "X-ExtLoop1": "1", "From": "Abdullah Sevincer <abdullah.sevincer@intel.com>", "To": "dev@dpdk.org", "Cc": "jerinj@marvell.com, rashmi.shetty@intel.com, pravin.pathak@intel.com,\n mike.ximing.chen@intel.com, timothy.mcdaniel@intel.com,\n shivani.doneria@intel.com, tirthendu.sarkar@intel.com,\n Abdullah Sevincer <abdullah.sevincer@intel.com>", "Subject": "[PATCH v3 3/3] event/dlb2: optimize credit allocations", "Date": "Mon, 26 Sep 2022 17:55:36 -0500", "Message-Id": "<20220926225536.1387161-3-abdullah.sevincer@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220926225536.1387161-1-abdullah.sevincer@intel.com>", "References": "<20220820005957.2986689-2-timothy.mcdaniel@intel.com>\n <20220926225536.1387161-1-abdullah.sevincer@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This commit implements the changes required for using suggested\nport type hint feature. Each port uses different credit quanta\nbased on port type specified using port configuration flags.\n\nEach port has separate quanta defined in dlb2_priv.h\nProducer and consumer ports will need larger quanta value to reduce number\nof credit calls they make. Workers can use small quanta as they mostly\nwork out of locally cached credits and don't request/return credits often.\n\nSigned-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>\n---\n drivers/event/dlb2/dlb2.c | 20 +++++++++++++++++++-\n 1 file changed, 19 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c\nindex 4dd1d55ddc..164ebbcfe2 100644\n--- a/drivers/event/dlb2/dlb2.c\n+++ b/drivers/event/dlb2/dlb2.c\n@@ -1965,8 +1965,8 @@ dlb2_eventdev_port_setup(struct rte_eventdev *dev,\n {\n \tstruct dlb2_eventdev *dlb2;\n \tstruct dlb2_eventdev_port *ev_port;\n-\tint ret;\n \tuint32_t hw_credit_quanta, sw_credit_quanta;\n+\tint ret;\n \n \tif (dev == NULL || port_conf == NULL) {\n \t\tDLB2_LOG_ERR(\"Null parameter\\n\");\n@@ -2067,6 +2067,24 @@ dlb2_eventdev_port_setup(struct rte_eventdev *dev,\n \tev_port->inflight_credits = 0;\n \tev_port->dlb2 = dlb2; /* reverse link */\n \n+\t/* Default for worker ports */\n+\tsw_credit_quanta = dlb2->sw_credit_quanta;\n+\thw_credit_quanta = dlb2->hw_credit_quanta;\n+\n+\tif (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_HINT_PRODUCER) {\n+\t\t/* Producer type ports. Mostly enqueue */\n+\t\tsw_credit_quanta = DLB2_SW_CREDIT_P_QUANTA_DEFAULT;\n+\t\thw_credit_quanta = DLB2_SW_CREDIT_P_BATCH_SZ;\n+\t}\n+\tif (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_HINT_CONSUMER) {\n+\t\t/* Consumer type ports. Mostly dequeue */\n+\t\tsw_credit_quanta = DLB2_SW_CREDIT_C_QUANTA_DEFAULT;\n+\t\thw_credit_quanta = DLB2_SW_CREDIT_C_BATCH_SZ;\n+\t}\n+\tev_port->credit_update_quanta = sw_credit_quanta;\n+\tev_port->qm_port.hw_credit_quanta = hw_credit_quanta;\n+\n+\n \t/* Tear down pre-existing port->queue links */\n \tif (dlb2->run_state == DLB2_RUN_STATE_STOPPED)\n \t\tdlb2_port_link_teardown(dlb2, &dlb2->ev_ports[ev_port_id]);\n", "prefixes": [ "v3", "3/3" ] }