Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1166/?format=api
{ "id": 1166, "url": "https://patches.dpdk.org/api/patches/1166/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1415283932-20724-2-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1415283932-20724-2-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1415283932-20724-2-git-send-email-helin.zhang@intel.com", "date": "2014-11-06T14:25:25", "name": "[dpdk-dev,v5,1/8] app/testpmd: code style fix", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "487224bc289715e206db1de70f642639b492a09a", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1415283932-20724-2-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1166/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1166/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 29F6A7F34;\n\tThu, 6 Nov 2014 15:16:19 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 6BDFB7F2D\n\tfor <dev@dpdk.org>; Thu, 6 Nov 2014 15:16:16 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 06 Nov 2014 06:25:42 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 06 Nov 2014 06:25:41 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sA6EPbgh003488;\n\tThu, 6 Nov 2014 22:25:37 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sA6EPZNj020766; Thu, 6 Nov 2014 22:25:37 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sA6EPZZ2020762; \n\tThu, 6 Nov 2014 22:25:35 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,326,1413270000\"; d=\"scan'208\";a=\"627680134\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 6 Nov 2014 22:25:25 +0800", "Message-Id": "<1415283932-20724-2-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1415283932-20724-1-git-send-email-helin.zhang@intel.com>", "References": "<1414746215-17327-1-git-send-email-helin.zhang@intel.com>\n\t<1415283932-20724-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 1/8] app/testpmd: code style fix", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix of several code style issues.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n app/test-pmd/cmdline.c | 28 +++++++++++++++-------------\n app/test-pmd/config.c | 2 +-\n 2 files changed, 16 insertions(+), 14 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 4c3fc76..daba286 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -1602,7 +1602,7 @@ parse_reta_config(const char *str, struct rte_eth_rss_reta *reta_conf)\n \t\tnb_queue = (uint8_t)int_fld[FLD_QUEUE];\n \n \t\tif (hash_index >= ETH_RSS_RETA_NUM_ENTRIES) {\n-\t\t\tprintf(\"Invalid RETA hash index=%d\",hash_index);\n+\t\t\tprintf(\"Invalid RETA hash index=%d\", hash_index);\n \t\t\treturn -1;\n \t\t}\n \n@@ -1619,22 +1619,24 @@ parse_reta_config(const char *str, struct rte_eth_rss_reta *reta_conf)\n \n static void\n cmd_set_rss_reta_parsed(void *parsed_result,\n-\t\t\t\t__attribute__((unused)) struct cmdline *cl,\n-\t\t\t\t__attribute__((unused)) void *data)\n+\t\t\t__attribute__((unused)) struct cmdline *cl,\n+\t\t\t__attribute__((unused)) void *data)\n {\n \tint ret;\n \tstruct rte_eth_rss_reta reta_conf;\n \tstruct cmd_config_rss_reta *res = parsed_result;\n \n-\tmemset(&reta_conf,0,sizeof(struct rte_eth_rss_reta));\n+\tmemset(&reta_conf, 0, sizeof(struct rte_eth_rss_reta));\n \tif (!strcmp(res->list_name, \"reta\")) {\n \t\tif (parse_reta_config(res->list_of_items, &reta_conf)) {\n-\t\t\tprintf(\"Invalid RSS Redirection Table config entered\\n\");\n+\t\t\tprintf(\"Invalid RSS Redirection Table config \"\n+\t\t\t\t\t\t\t\"entered\\n\");\n \t\t\treturn;\n \t\t}\n \t\tret = rte_eth_dev_rss_reta_update(res->port_id, &reta_conf);\n \t\tif (ret != 0)\n-\t\t\tprintf(\"Bad redirection table parameter, return code = %d \\n\",ret);\n+\t\t\tprintf(\"Bad redirection table parameter, \"\n+\t\t\t\t\t\"return code = %d \\n\", ret);\n \t}\n }\n \n@@ -1696,19 +1698,19 @@ static void cmd_showport_reta_parsed(void *parsed_result,\n }\n \n cmdline_parse_token_string_t cmd_showport_reta_show =\n- TOKEN_STRING_INITIALIZER(struct cmd_showport_reta, show, \"show\");\n+\tTOKEN_STRING_INITIALIZER(struct cmd_showport_reta, show, \"show\");\n cmdline_parse_token_string_t cmd_showport_reta_port =\n- TOKEN_STRING_INITIALIZER(struct cmd_showport_reta, port, \"port\");\n+\tTOKEN_STRING_INITIALIZER(struct cmd_showport_reta, port, \"port\");\n cmdline_parse_token_num_t cmd_showport_reta_port_id =\n- TOKEN_NUM_INITIALIZER(struct cmd_showport_reta, port_id, UINT8);\n+\tTOKEN_NUM_INITIALIZER(struct cmd_showport_reta, port_id, UINT8);\n cmdline_parse_token_string_t cmd_showport_reta_rss =\n- TOKEN_STRING_INITIALIZER(struct cmd_showport_reta, rss, \"rss\");\n+\tTOKEN_STRING_INITIALIZER(struct cmd_showport_reta, rss, \"rss\");\n cmdline_parse_token_string_t cmd_showport_reta_reta =\n- TOKEN_STRING_INITIALIZER(struct cmd_showport_reta, reta, \"reta\");\n+\tTOKEN_STRING_INITIALIZER(struct cmd_showport_reta, reta, \"reta\");\n cmdline_parse_token_num_t cmd_showport_reta_mask_lo =\n- TOKEN_NUM_INITIALIZER(struct cmd_showport_reta,mask_lo,UINT64);\n+\tTOKEN_NUM_INITIALIZER(struct cmd_showport_reta, mask_lo, UINT64);\n cmdline_parse_token_num_t cmd_showport_reta_mask_hi =\n-\tTOKEN_NUM_INITIALIZER(struct cmd_showport_reta,mask_hi,UINT64);\n+\tTOKEN_NUM_INITIALIZER(struct cmd_showport_reta, mask_hi, UINT64);\n \n cmdline_parse_inst_t cmd_showport_reta = {\n \t.f = cmd_showport_reta_parsed,\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 9bc08f4..73afcf5 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -764,7 +764,7 @@ rxtx_config_display(void)\n void\n port_rss_reta_info(portid_t port_id,struct rte_eth_rss_reta *reta_conf)\n {\n-\tuint8_t i,j;\n+\tuint8_t i, j;\n \tint ret;\n \n \tif (port_id_is_invalid(port_id))\n", "prefixes": [ "dpdk-dev", "v5", "1/8" ] }