Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116385/?format=api
{ "id": 116385, "url": "https://patches.dpdk.org/api/patches/116385/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1663308990-621-4-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1663308990-621-4-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1663308990-621-4-git-send-email-andy.pei@intel.com", "date": "2022-09-16T06:16:25", "name": "[v3,3/8] vdpa/ifc: set max queues based on virtio spec", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ec0554d468d376c8b83b8a153cdcd9afcd658412", "submitter": { "id": 1185, "url": "https://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1663308990-621-4-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 24689, "url": "https://patches.dpdk.org/api/series/24689/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24689", "date": "2022-09-16T06:16:22", "name": "vdpa/ifc: add multi queue support", "version": 3, "mbox": "https://patches.dpdk.org/series/24689/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/116385/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/116385/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E51F1A0032;\n\tFri, 16 Sep 2022 08:17:15 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 001DA42826;\n\tFri, 16 Sep 2022 08:17:07 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 3304E427F7\n for <dev@dpdk.org>; Fri, 16 Sep 2022 08:17:04 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Sep 2022 23:16:35 -0700", "from dpdk-dipei.sh.intel.com ([10.67.110.251])\n by orsmga003.jf.intel.com with ESMTP; 15 Sep 2022 23:16:33 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1663309024; x=1694845024;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=kMSHcYV7EuNl9w7jvbLWU83QFbAAWPdqpRkAqMVpxP0=;\n b=kP2N2CGo7NAauHUh2bi6HjViY8U362S2u2sfmPmqSjN5chnNj6P4kU21\n tzwb3a5onnRUDF0BW/IpeD84mcauCUAafEAViSLP1qhswwBGMvlyeru7G\n pPhmTsNHcuQLhAnojURTmlSfISjaq5gOjNl/FVRUEDhN97P0McGnIgpQT\n KgJ61ranE1cV/fMKW3N2D0qrq/FX0A9OQ1doNldoHiYFM9GGbaXnHOe5Y\n QUimEVFYuHFuOwqOmFdssZ6qFebDHwe3nBM5BDN8c7BAF3i7iKeKwAQJF\n yD5FCC0P8ecraQ8XeZ7F4130XlZKSU++oqe3RQrv4KTRN01gSUy1axUqZ A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10471\"; a=\"278650944\"", "E=Sophos;i=\"5.93,320,1654585200\"; d=\"scan'208\";a=\"278650944\"", "E=Sophos;i=\"5.93,320,1654585200\"; d=\"scan'208\";a=\"568724569\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, rosen.xu@intel.com, wei.huang@intel.com,\n gang.cao@intel.com, maxime.coquelin@redhat.com", "Subject": "[PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec", "Date": "Fri, 16 Sep 2022 14:16:25 +0800", "Message-Id": "<1663308990-621-4-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1663308990-621-1-git-send-email-andy.pei@intel.com>", "References": "<1661229305-240952-2-git-send-email-andy.pei@intel.com>\n <1663308990-621-1-git-send-email-andy.pei@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Set max_queues according to virtio HW spec.\nFor virtio BLK device, set max_queues to the value of \"num_queues\".\n\"num_queues\" is element of struct virtio_blk_config.\nFor virtio NET device, read num_queues from truct ifcvf_pci_common_cfg,\ncalculate \"queue_pairs = (num_queues - 1) / 2\" and get queue_pairs.\nSet max_queues to the value of \"queue_pairs\".\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\nSigned-off-by: Huang Wei <wei.huang@intel.com>\n---\n drivers/vdpa/ifc/base/ifcvf.h | 2 +-\n drivers/vdpa/ifc/ifcvf_vdpa.c | 19 ++++++++++++++++++-\n 2 files changed, 19 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h\nindex d16d9ab..1e133c0 100644\n--- a/drivers/vdpa/ifc/base/ifcvf.h\n+++ b/drivers/vdpa/ifc/base/ifcvf.h\n@@ -21,7 +21,7 @@\n #define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001\n #define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002\n \n-#define IFCVF_MAX_QUEUES\t\t1\n+#define IFCVF_MAX_QUEUES\t\t32\n \n #ifndef VIRTIO_F_IOMMU_PLATFORM\n #define VIRTIO_F_IOMMU_PLATFORM\t\t33\ndiff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex 3e5ffba..376239a 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -26,6 +26,12 @@\n \n #include \"base/ifcvf.h\"\n \n+/*\n+ * RTE_MIN() cannot be used since braced-group within expression allowed\n+ * only inside a function.\n+ */\n+#define MIN(v1, v2)\t((v1) < (v2) ? (v1) : (v2))\n+\n RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE);\n #define DRV_LOG(level, fmt, args...) \\\n \trte_log(RTE_LOG_ ## level, ifcvf_vdpa_logtype, \\\n@@ -1512,6 +1518,7 @@ struct rte_vdpa_dev_info dev_info[] = {\n \tuint64_t capacity = 0;\n \tuint8_t *byte;\n \tuint32_t i;\n+\tuint16_t queue_pairs;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n@@ -1559,7 +1566,6 @@ struct rte_vdpa_dev_info dev_info[] = {\n \t}\n \n \tinternal->configured = 0;\n-\tinternal->max_queues = IFCVF_MAX_QUEUES;\n \tfeatures = ifcvf_get_features(&internal->hw);\n \n \tdevice_id = ifcvf_pci_get_device_type(pci_dev);\n@@ -1570,6 +1576,14 @@ struct rte_vdpa_dev_info dev_info[] = {\n \n \tif (device_id == VIRTIO_ID_NET) {\n \t\tinternal->hw.device_type = IFCVF_NET;\n+\t\t/*\n+\t\t * ifc driver always has CTRL_VQ,\n+\t\t * and supports VIRTIO_NET_F_CTRL_VQ feature.\n+\t\t */\n+\t\tqueue_pairs = (internal->hw.common_cfg->num_queues - 1) / 2;\n+\t\tDRV_LOG(INFO, \"%s support %u queue pairs\", pci_dev->name,\n+\t\t\tqueue_pairs);\n+\t\tinternal->max_queues = MIN(IFCVF_MAX_QUEUES, queue_pairs);\n \t\tinternal->features = features &\n \t\t\t\t\t~(1ULL << VIRTIO_F_IOMMU_PLATFORM);\n \t\tinternal->features |= dev_info[IFCVF_NET].features;\n@@ -1609,6 +1623,9 @@ struct rte_vdpa_dev_info dev_info[] = {\n \t\t\tinternal->hw.blk_cfg->geometry.sectors);\n \t\tDRV_LOG(DEBUG, \"num_queues: 0x%08x\",\n \t\t\tinternal->hw.blk_cfg->num_queues);\n+\n+\t\tinternal->max_queues = MIN(IFCVF_MAX_QUEUES,\n+\t\t\tinternal->hw.blk_cfg->num_queues);\n \t}\n \n \tlist->internal = internal;\n", "prefixes": [ "v3", "3/8" ] }