Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116351/?format=api
{ "id": 116351, "url": "https://patches.dpdk.org/api/patches/116351/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220915124522.5407-2-lihuisong@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220915124522.5407-2-lihuisong@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220915124522.5407-2-lihuisong@huawei.com", "date": "2022-09-15T12:45:17", "name": "[V2,1/6] bus/pci: fix a segfault when call callback", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "39ea2bc8a8b9dcc9821f4c2c2355ef58f0255ee5", "submitter": { "id": 2085, "url": "https://patches.dpdk.org/api/people/2085/?format=api", "name": "lihuisong (C)", "email": "lihuisong@huawei.com" }, "delegate": { "id": 3961, "url": "https://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220915124522.5407-2-lihuisong@huawei.com/mbox/", "series": [ { "id": 24680, "url": "https://patches.dpdk.org/api/series/24680/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24680", "date": "2022-09-15T12:45:18", "name": "app/testpmd: support attach and detach port for MP", "version": 2, "mbox": "https://patches.dpdk.org/series/24680/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/116351/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/116351/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9196AA00C5;\n\tThu, 15 Sep 2022 14:47:08 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0B8E4427FF;\n\tThu, 15 Sep 2022 14:46:58 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 82BC440156\n for <dev@dpdk.org>; Thu, 15 Sep 2022 14:46:54 +0200 (CEST)", "from dggemv703-chm.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MSxgr5WsjzmV9Z;\n Thu, 15 Sep 2022 20:43:04 +0800 (CST)", "from kwepemm600004.china.huawei.com (7.193.23.242) by\n dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Thu, 15 Sep 2022 20:46:51 +0800", "from localhost.localdomain (10.28.79.22) by\n kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.31; Thu, 15 Sep 2022 20:46:51 +0800" ], "From": "Huisong Li <lihuisong@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,\n <andrew.rybchenko@oktetlabs.ru>, <huangdaode@huawei.com>,\n <lihuisong@huawei.com>", "Subject": "[PATCH V2 1/6] bus/pci: fix a segfault when call callback", "Date": "Thu, 15 Sep 2022 20:45:17 +0800", "Message-ID": "<20220915124522.5407-2-lihuisong@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20220915124522.5407-1-lihuisong@huawei.com>", "References": "<20220825024425.10534-1-lihuisong@huawei.com>\n <20220915124522.5407-1-lihuisong@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n kwepemm600004.china.huawei.com (7.193.23.242)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "After the driver probe is executed, the callback in application will\nbe called. The callback in application may call some APIs which access the\nrte_pci_driver::driver by the device::driver pointer to get driver\ninformation. If the rte_pci_device::device::driver pointer isn't pointed to\nrte_pci_driver::driver in rte_pci_probe_one_driver, a segfault will occur.\nFor example, when ethdev driver probe completes, the callback in\napplication call rte_eth_dev_info_get which use dev->device->driver->name.\nSo rte_pci_device::device::driver should point to rte_pci_driver::driver\nbefore executing the driver probe.\n\nFixes: c752998b5e2e (\"pci: introduce library and driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n drivers/bus/pci/pci_common.c | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c\nindex 37ab879779..831a9cd8c7 100644\n--- a/drivers/bus/pci/pci_common.c\n+++ b/drivers/bus/pci/pci_common.c\n@@ -265,11 +265,22 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,\n \t\t\tdr->driver.name, dev->id.vendor_id, dev->id.device_id,\n \t\t\tloc->domain, loc->bus, loc->devid, loc->function,\n \t\t\tdev->device.numa_node);\n+\n+\t/*\n+\t * After the driver probe is executed, the callback in application will\n+\t * be called. The callback in application may call some APIs which use\n+\t * dev->device.driver to get some driver information. If the driver\n+\t * pointer isn't pointed to driver->driver here, a segfault will occur.\n+\t */\n+\tif (!already_probed)\n+\t\tdev->device.driver = &dr->driver;\n+\n \t/* call the driver probe() function */\n \tret = dr->probe(dr, dev);\n \tif (already_probed)\n \t\treturn ret; /* no rollback if already succeeded earlier */\n \tif (ret) {\n+\t\tdev->device.driver = NULL;\n \t\tdev->driver = NULL;\n \t\tif ((dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) &&\n \t\t\t/* Don't unmap if device is unsupported and\n@@ -282,8 +293,6 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,\n \t\tdev->vfio_req_intr_handle = NULL;\n \t\trte_intr_instance_free(dev->intr_handle);\n \t\tdev->intr_handle = NULL;\n-\t} else {\n-\t\tdev->device.driver = &dr->driver;\n \t}\n \n \treturn ret;\n", "prefixes": [ "V2", "1/6" ] }