Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1161/?format=api
{ "id": 1161, "url": "https://patches.dpdk.org/api/patches/1161/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1415278430-17920-5-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1415278430-17920-5-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1415278430-17920-5-git-send-email-helin.zhang@intel.com", "date": "2014-11-06T12:53:49", "name": "[dpdk-dev,v3,4/5] i40e: support of configurable crc stripping in rx queue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "42e9f01d3c3fa82fb109c44849f3082edc47c247", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1415278430-17920-5-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1161/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1161/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 16E2D7F3C;\n\tThu, 6 Nov 2014 13:44:47 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 0123A7F38\n\tfor <dev@dpdk.org>; Thu, 6 Nov 2014 13:44:42 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 06 Nov 2014 04:47:50 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 06 Nov 2014 04:54:08 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sA6Cs6EG010963;\n\tThu, 6 Nov 2014 20:54:06 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sA6Cs49F017982; Thu, 6 Nov 2014 20:54:06 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sA6Cs4eJ017978; \n\tThu, 6 Nov 2014 20:54:04 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,325,1413270000\"; d=\"scan'208\";a=\"618175736\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 6 Nov 2014 20:53:49 +0800", "Message-Id": "<1415278430-17920-5-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1415278430-17920-1-git-send-email-helin.zhang@intel.com>", "References": "<1410706109-30448-1-git-send-email-helin.zhang@intel.com>\n\t<1415278430-17920-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 4/5] i40e: support of configurable crc\n\tstripping in rx queue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support of configurable crc stripping in context of\nVF RX queues.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n lib/librte_pmd_i40e/i40e_pf.c | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)\n\nv2 changes:\n* Put setting the crc stripping into a single patch.\n\nv3 changes:\n* Added an input parameter for configuring crc stripping in\n RX queue context.", "diff": "diff --git a/lib/librte_pmd_i40e/i40e_pf.c b/lib/librte_pmd_i40e/i40e_pf.c\nindex f4b4f2d..7f98636 100644\n--- a/lib/librte_pmd_i40e/i40e_pf.c\n+++ b/lib/librte_pmd_i40e/i40e_pf.c\n@@ -56,6 +56,8 @@\n #include \"i40e_rxtx.h\"\n #include \"i40e_pf.h\"\n \n+#define I40E_CFG_CRCSTRIP_DEFAULT 1\n+\n static int\n i40e_pf_host_switch_queues(struct i40e_pf_vf *vf,\n \t\t\t struct i40e_virtchnl_queue_select *qsel,\n@@ -325,7 +327,8 @@ send_msg:\n static int\n i40e_pf_host_hmc_config_rxq(struct i40e_hw *hw,\n \t\t\t struct i40e_pf_vf *vf,\n-\t\t\t struct i40e_virtchnl_rxq_info *rxq)\n+\t\t\t struct i40e_virtchnl_rxq_info *rxq,\n+\t\t\t uint8_t crcstrip)\n {\n \tint err = I40E_SUCCESS;\n \tstruct i40e_hmc_obj_rxq rx_ctx;\n@@ -354,7 +357,7 @@ i40e_pf_host_hmc_config_rxq(struct i40e_hw *hw,\n \trx_ctx.tphdata_ena = 1;\n \trx_ctx.tphhead_ena = 1;\n \trx_ctx.lrxqthresh = 2;\n-\trx_ctx.crcstrip = 1;\n+\trx_ctx.crcstrip = crcstrip;\n \trx_ctx.l2tsel = 1;\n \trx_ctx.prefena = 1;\n \n@@ -434,8 +437,8 @@ i40e_pf_host_process_cmd_config_vsi_queues(struct i40e_pf_vf *vf,\n \t\t}\n \n \t\t/* Apply VF RX queue setting to HMC */\n-\t\tif (i40e_pf_host_hmc_config_rxq(hw, vf, &vc_qpi[i].rxq)\n-\t\t\t!= I40E_SUCCESS) {\n+\t\tif (i40e_pf_host_hmc_config_rxq(hw, vf, &vc_qpi[i].rxq,\n+\t\t\tI40E_CFG_CRCSTRIP_DEFAULT) != I40E_SUCCESS) {\n \t\t\tPMD_DRV_LOG(ERR, \"Configure RX queue HMC failed\");\n \t\t\tret = I40E_ERR_PARAM;\n \t\t\tgoto send_msg;\n", "prefixes": [ "dpdk-dev", "v3", "4/5" ] }