Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116014/?format=api
https://patches.dpdk.org/api/patches/116014/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220907051040.119588-2-jie1x.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220907051040.119588-2-jie1x.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220907051040.119588-2-jie1x.wang@intel.com", "date": "2022-09-07T05:10:36", "name": "[v5,1/5] common/iavf: support flow subscription", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "86f298ed3866d1c0fe6d62d8ca73c485b3720699", "submitter": { "id": 2201, "url": "https://patches.dpdk.org/api/people/2201/?format=api", "name": "Jie Wang", "email": "jie1x.wang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220907051040.119588-2-jie1x.wang@intel.com/mbox/", "series": [ { "id": 24576, "url": "https://patches.dpdk.org/api/series/24576/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24576", "date": "2022-09-07T05:10:35", "name": "support flow subscription", "version": 5, "mbox": "https://patches.dpdk.org/series/24576/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/116014/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/116014/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5BA85A0550;\n\tWed, 7 Sep 2022 07:11:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 321D041141;\n\tWed, 7 Sep 2022 07:11:24 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 68E5940697\n for <dev@dpdk.org>; Wed, 7 Sep 2022 07:11:22 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Sep 2022 22:11:21 -0700", "from intel-cd-odc-gavin.cd.intel.com ([10.240.178.187])\n by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Sep 2022 22:11:19 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1662527482; x=1694063482;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=1+bUTQLF+ydHT2LtP/eG5D4FdY8aT16l9Te5N1BQe4M=;\n b=RO4Qj3vGCp1Rl2/poFNepIN0IV+Hq9z0Z+Arfcsad/NBqSsOzvrAjx2q\n T0Vm6SfB60QlbWJtvjMFEh38/kVw5xDtILdTTMjbK9O0J+b9DYB5dchTe\n 6YvV6mbmvLWmnuAvttUe8HcP735mZ1DmDybTEmqmEvNT4XdEkNsQqCt7L\n T4rS7jgLfc/vLibjtZlMoMRG3OVpwv7ttjHo51ZLJQVFhrM1xifxwKmak\n BtW4ntWs+V1RtLDs7yVQ7G35teJMvZF11tPpWRPyTFgT9vjg9peh5a7Ap\n HJe57AJiV2Df5kWfZ/nwLTAG5M1zhBMkmLB8o09drcZWfVotTAYvceXhJ A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10462\"; a=\"283779067\"", "E=Sophos;i=\"5.93,295,1654585200\"; d=\"scan'208\";a=\"283779067\"", "E=Sophos;i=\"5.93,295,1654585200\"; d=\"scan'208\";a=\"676012992\"" ], "From": "Jie Wang <jie1x.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "qiming.yang@intel.com, qi.z.zhang@intel.com, jingjing.wu@intel.com,\n beilei.xing@intel.com, stevex.yang@intel.com,\n Jie Wang <jie1x.wang@intel.com>", "Subject": "[PATCH v5 1/5] common/iavf: support flow subscription", "Date": "Wed, 7 Sep 2022 13:10:36 +0800", "Message-Id": "<20220907051040.119588-2-jie1x.wang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220907051040.119588-1-jie1x.wang@intel.com>", "References": "<20220809062122.1203281-1-jie1x.wang@intel.com>\n <20220907051040.119588-1-jie1x.wang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "VF is able to subscribe a flow from PF by VIRTCHNL_FLOW_SUBSCRIBE.\n\nPF is expected to offload a rule to hardware which will redirect\nthe packet that matching the required pattern to this VF.\n\nOnly a flow with dst mac address as PF's mac address can be subscribed.\n\nVIRTCHNL_VF_OFFLOAD_FSUB_PF is used for Flow subscription capability\nnegotiation and only a trusted VF can be granted with this capability.\n\nA flow can be unsubscribed by VIRTCHNL_FLOW_UNSUBSCRIBE.\n\nSigned-off-by: Jie Wang <jie1x.wang@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/common/iavf/virtchnl.h | 104 +++++++++++++++++++++++++++++++--\n 1 file changed, 100 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h\nindex f123daec8e..e02eec4935 100644\n--- a/drivers/common/iavf/virtchnl.h\n+++ b/drivers/common/iavf/virtchnl.h\n@@ -168,6 +168,8 @@ enum virtchnl_ops {\n \tVIRTCHNL_OP_MAP_QUEUE_VECTOR = 111,\n \tVIRTCHNL_OP_CONFIG_QUEUE_BW = 112,\n \tVIRTCHNL_OP_CONFIG_QUANTA = 113,\n+\tVIRTCHNL_OP_FLOW_SUBSCRIBE = 114,\n+\tVIRTCHNL_OP_FLOW_UNSUBSCRIBE = 115,\n \tVIRTCHNL_OP_MAX,\n };\n \n@@ -282,6 +284,10 @@ static inline const char *virtchnl_op_str(enum virtchnl_ops v_opcode)\n \t\treturn \"VIRTCHNL_OP_1588_PTP_GET_CAPS\";\n \tcase VIRTCHNL_OP_1588_PTP_GET_TIME:\n \t\treturn \"VIRTCHNL_OP_1588_PTP_GET_TIME\";\n+\tcase VIRTCHNL_OP_FLOW_SUBSCRIBE:\n+\t\treturn \"VIRTCHNL_OP_FLOW_SUBSCRIBE\";\n+\tcase VIRTCHNL_OP_FLOW_UNSUBSCRIBE:\n+\t\treturn \"VIRTCHNL_OP_FLOW_UNSUBSCRIBE\";\n \tcase VIRTCHNL_OP_MAX:\n \t\treturn \"VIRTCHNL_OP_MAX\";\n \tdefault:\n@@ -401,6 +407,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);\n #define VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO\tBIT(8)\n #define VIRTCHNL_VF_LARGE_NUM_QPAIRS\t\tBIT(9)\n #define VIRTCHNL_VF_OFFLOAD_CRC\t\t\tBIT(10)\n+#define VIRTCHNL_VF_OFFLOAD_FSUB_PF\t\tBIT(14)\n #define VIRTCHNL_VF_OFFLOAD_VLAN_V2\t\tBIT(15)\n #define VIRTCHNL_VF_OFFLOAD_VLAN\t\tBIT(16)\n #define VIRTCHNL_VF_OFFLOAD_RX_POLLING\t\tBIT(17)\n@@ -1503,6 +1510,7 @@ enum virtchnl_vfr_states {\n };\n \n #define VIRTCHNL_MAX_NUM_PROTO_HDRS\t32\n+#define VIRTCHNL_MAX_NUM_PROTO_HDRS_W_MSK\t16\n #define VIRTCHNL_MAX_SIZE_RAW_PACKET\t1024\n #define PROTO_HDR_SHIFT\t\t\t5\n #define PROTO_HDR_FIELD_START(proto_hdr_type) \\\n@@ -1695,6 +1703,22 @@ struct virtchnl_proto_hdr {\n \n VIRTCHNL_CHECK_STRUCT_LEN(72, virtchnl_proto_hdr);\n \n+struct virtchnl_proto_hdr_w_msk {\n+\t/* see enum virtchnl_proto_hdr_type */\n+\ts32 type;\n+\tu32 pad;\n+\t/**\n+\t * binary buffer in network order for specific header type.\n+\t * For example, if type = VIRTCHNL_PROTO_HDR_IPV4, a IPv4\n+\t * header is expected to be copied into the buffer.\n+\t */\n+\tu8 buffer_spec[64];\n+\t/* binary buffer for bit-mask applied to specific header type */\n+\tu8 buffer_mask[64];\n+};\n+\n+VIRTCHNL_CHECK_STRUCT_LEN(136, virtchnl_proto_hdr_w_msk);\n+\n struct virtchnl_proto_hdrs {\n \tu8 tunnel_level;\n \t/**\n@@ -1706,11 +1730,18 @@ struct virtchnl_proto_hdrs {\n \t */\n \tint count;\n \t/**\n-\t * number of proto layers, must < VIRTCHNL_MAX_NUM_PROTO_HDRS\n-\t * must be 0 for a raw packet request.\n+\t * count must <=\n+\t * VIRTCHNL_MAX_NUM_PROTO_HDRS + VIRTCHNL_MAX_NUM_PROTO_HDRS_W_MSK\n+\t * count = 0 :\t\t\t\t\tselect raw\n+\t * 1 < count <= VIRTCHNL_MAX_NUM_PROTO_HDRS :\tselect proto_hdr\n+\t * count > VIRTCHNL_MAX_NUM_PROTO_HDRS :\tselect proto_hdr_w_msk\n+\t * last valid index = count - VIRTCHNL_MAX_NUM_PROTO_HDRS\n \t */\n \tunion {\n-\t\tstruct virtchnl_proto_hdr proto_hdr[VIRTCHNL_MAX_NUM_PROTO_HDRS];\n+\t\tstruct virtchnl_proto_hdr\n+\t\t\tproto_hdr[VIRTCHNL_MAX_NUM_PROTO_HDRS];\n+\t\tstruct virtchnl_proto_hdr_w_msk\n+\t\t\tproto_hdr_w_msk[VIRTCHNL_MAX_NUM_PROTO_HDRS_W_MSK];\n \t\tstruct {\n \t\t\tu16 pkt_len;\n \t\t\tu8 spec[VIRTCHNL_MAX_SIZE_RAW_PACKET];\n@@ -1731,7 +1762,7 @@ struct virtchnl_rss_cfg {\n \n VIRTCHNL_CHECK_STRUCT_LEN(2444, virtchnl_rss_cfg);\n \n-/* action configuration for FDIR */\n+/* action configuration for FDIR and FSUB */\n struct virtchnl_filter_action {\n \t/* see enum virtchnl_action type */\n \ts32 type;\n@@ -1849,6 +1880,65 @@ struct virtchnl_fdir_del {\n \n VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_fdir_del);\n \n+/* Status returned to VF after VF requests FSUB commands\n+ * VIRTCHNL_FSUB_SUCCESS\n+ * VF FLOW related request is successfully done by PF\n+ * The request can be OP_FLOW_SUBSCRIBE/UNSUBSCRIBE.\n+ *\n+ * VIRTCHNL_FSUB_FAILURE_RULE_NORESOURCE\n+ * OP_FLOW_SUBSCRIBE request is failed due to no Hardware resource.\n+ *\n+ * VIRTCHNL_FSUB_FAILURE_RULE_EXIST\n+ * OP_FLOW_SUBSCRIBE request is failed due to the rule is already existed.\n+ *\n+ * VIRTCHNL_FSUB_FAILURE_RULE_NONEXIST\n+ * OP_FLOW_UNSUBSCRIBE request is failed due to this rule doesn't exist.\n+ *\n+ * VIRTCHNL_FSUB_FAILURE_RULE_INVALID\n+ * OP_FLOW_SUBSCRIBE request is failed due to parameters validation\n+ * or HW doesn't support.\n+ */\n+enum virtchnl_fsub_prgm_status {\n+\tVIRTCHNL_FSUB_SUCCESS = 0,\n+\tVIRTCHNL_FSUB_FAILURE_RULE_NORESOURCE,\n+\tVIRTCHNL_FSUB_FAILURE_RULE_EXIST,\n+\tVIRTCHNL_FSUB_FAILURE_RULE_NONEXIST,\n+\tVIRTCHNL_FSUB_FAILURE_RULE_INVALID,\n+};\n+\n+/* VIRTCHNL_OP_FLOW_SUBSCRIBE\n+ * VF sends this request to PF by filling out vsi_id,\n+ * validate_only, priority, proto_hdrs and actions.\n+ * PF will return flow_id\n+ * if the request is successfully done and return status to VF.\n+ */\n+struct virtchnl_flow_sub {\n+\tu16 vsi_id; /* INPUT */\n+\tu8 validate_only; /* INPUT */\n+\tu8 priority; /* INPUT */\n+\tu32 flow_id; /* OUTPUT */\n+\tstruct virtchnl_proto_hdrs proto_hdrs; /* INPUT */\n+\tstruct virtchnl_filter_action_set actions; /* INPUT */\n+\t/* see enum virtchnl_fsub_prgm_status; OUTPUT */\n+\ts32 status;\n+};\n+\n+VIRTCHNL_CHECK_STRUCT_LEN(2616, virtchnl_flow_sub);\n+\n+/* VIRTCHNL_OP_FLOW_UNSUBSCRIBE\n+ * VF sends this request to PF by filling out vsi_id\n+ * and flow_id. PF will return status to VF.\n+ */\n+struct virtchnl_flow_unsub {\n+\tu16 vsi_id; /* INPUT */\n+\tu16 pad;\n+\tu32 flow_id; /* INPUT */\n+\t/* see enum virtchnl_fsub_prgm_status; OUTPUT */\n+\ts32 status;\n+};\n+\n+VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_flow_unsub);\n+\n /* VIRTCHNL_OP_GET_QOS_CAPS\n * VF sends this message to get its QoS Caps, such as\n * TC number, Arbiter and Bandwidth.\n@@ -2318,6 +2408,12 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,\n \tcase VIRTCHNL_OP_DEL_FDIR_FILTER:\n \t\tvalid_len = sizeof(struct virtchnl_fdir_del);\n \t\tbreak;\n+\tcase VIRTCHNL_OP_FLOW_SUBSCRIBE:\n+\t\tvalid_len = sizeof(struct virtchnl_flow_sub);\n+\t\tbreak;\n+\tcase VIRTCHNL_OP_FLOW_UNSUBSCRIBE:\n+\t\tvalid_len = sizeof(struct virtchnl_flow_unsub);\n+\t\tbreak;\n \tcase VIRTCHNL_OP_GET_QOS_CAPS:\n \t\tbreak;\n \tcase VIRTCHNL_OP_CONFIG_QUEUE_TC_MAP:\n", "prefixes": [ "v5", "1/5" ] }{ "id": 116014, "url": "