Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115786/?format=api
{ "id": 115786, "url": "https://patches.dpdk.org/api/patches/115786/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220902084754.99884-4-bhagyada.modali@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220902084754.99884-4-bhagyada.modali@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220902084754.99884-4-bhagyada.modali@amd.com", "date": "2022-09-02T08:47:54", "name": "[v3,4/4] net/axgbe: fix checksum and RSS in scattered Rx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c41d0b19393f1b62d72a0607c5e21b612aa78a05", "submitter": { "id": 2826, "url": "https://patches.dpdk.org/api/people/2826/?format=api", "name": "Bhagyada Modali", "email": "bhagyada.modali@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220902084754.99884-4-bhagyada.modali@amd.com/mbox/", "series": [ { "id": 24518, "url": "https://patches.dpdk.org/api/series/24518/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24518", "date": "2022-09-02T08:47:51", "name": "[v3,1/4] net/axgbe: fix scattered Rx", "version": 3, "mbox": "https://patches.dpdk.org/series/24518/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/115786/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/115786/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3739DA0544;\n\tFri, 2 Sep 2022 10:48:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 76E3642826;\n\tFri, 2 Sep 2022 10:48:35 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2072.outbound.protection.outlook.com [40.107.223.72])\n by mails.dpdk.org (Postfix) with ESMTP id 69FB6427F9;\n Fri, 2 Sep 2022 10:48:34 +0200 (CEST)", "from CY5PR18CA0041.namprd18.prod.outlook.com (2603:10b6:930:13::19)\n by BN9PR12MB5306.namprd12.prod.outlook.com (2603:10b6:408:103::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep\n 2022 08:48:31 +0000", "from CY4PEPF0000B8ED.namprd05.prod.outlook.com\n (2603:10b6:930:13:cafe::ec) by CY5PR18CA0041.outlook.office365.com\n (2603:10b6:930:13::19) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16 via Frontend\n Transport; Fri, 2 Sep 2022 08:48:31 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CY4PEPF0000B8ED.mail.protection.outlook.com (10.167.241.9) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.5588.7 via Frontend Transport; Fri, 2 Sep 2022 08:48:31 +0000", "from cae-Selwin.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 2 Sep\n 2022 03:48:28 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Nk5I0A7BpVcFSHOiOeY9znIcjxua93aHVCUnRpm3M0siuTw6JFLY0KbUIUb5thaj9qS/ESpH6qZ3XSwnkXyhNGB3MQDX5GQAWvFMAT50PIWgj77I5LonlfklP8x188Evv8x0gjgwzBRhLoy7x5cR5GWsnFVnBIbAWcEQhLZLwjs+zSmtoxpKjU5Y6l44Az8O5/uQ+q9Es7vOT6+i2SC/GzEbxL2k9wMoNhdkcqaGPsflMX9l3CUeU843fv/ZHO6N2mysjx00SEnmhu0WWEM5OquZqsH5xulcZJFJEM11NoE+eR0Nfh9XsQDtmRSQx87ZvSvhjyLipuv/yn0A3OVdCg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=eAcZzJVfpEDVGVQO24f2o1DyzsW2/qYCg7bCCH/wxPE=;\n b=PgpAKCUeXJYfsQobcPpdeBIbNgqDIfZHX26+9Kp486xbfNM+B8nylQ6+Kc53aX68LqmlN5QjSRvjfaujyFUE3DD8GHuNXwsddM7T0CLgWTaVYqjX4GIvrldCXYr/+I4sFIe5uGZBfxhllJtar9M+UWB9D23s0TBDBxV2xDMl/qgfOW0p3rDtWQpUu4tGT7t8WLMw4WLaSZIlvW4ebPNACnbGrtn2KokTf8iwJ8Qg1l4IGAWU4ORwCZVLRab3jkw3EtM8kUy7+UbpGCthhG551gC7BxaWBtmPQuPcUtBydHUkovjYG+RffnypfWML396sVUS8jHm5DrZbAURy9aq7TA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=eAcZzJVfpEDVGVQO24f2o1DyzsW2/qYCg7bCCH/wxPE=;\n b=Oft7L143XzeF79HggNcIJpcUo+YT0O7ghG4QtUp6ebQGI0oIg7BlE2Rp5njlPU6uGCQcyOe6kzL++68sqelfUab04PfkVtsekFlvjwxCHmHmEa9tGPD5wL5xxoqAxp4JczO+Ek+7lHM2uG4I9Yi1rN01E1eAtNY11Y63RRRxWNQ=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Bhagyada Modali <bhagyada.modali@amd.com>", "To": "<chandu@amd.com>, <ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, <stable@dpdk.org>, Bhagyada Modali\n <bhagyada.modali@amd.com>", "Subject": "[PATCH v3 4/4] net/axgbe: fix checksum and RSS in scattered Rx", "Date": "Fri, 2 Sep 2022 04:47:54 -0400", "Message-ID": "<20220902084754.99884-4-bhagyada.modali@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220902084754.99884-1-bhagyada.modali@amd.com>", "References": "<20220901124948.97063-1-bhagyada.modali@amd.com>\n <20220902084754.99884-1-bhagyada.modali@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "6166c66a-fcab-4eff-9e51-08da8cbfe98f", "X-MS-TrafficTypeDiagnostic": "BN9PR12MB5306:EE_", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n DkpVD0HVffJ8HZH66Xs9sXi3e3Wd0g8/EcTPD3TQMqqvZYy5WOl6r6IGkXHOHSiF7jvAC3J69nA1vq4wlPP+2sTGG25Mn8DEaJXAExbe9hbj5N0ettnN1RrEitoTxFWFxOPlJ7iwZ8V3qugEo/zbT2fWx6mOuMIdEOpJBiiKQqbuhcAETXTjj28Pp+3LTFYpUcBGGlKAMTtINFkwAemZSeFfTQaAk8NryPLnZqzlG3agoWE0Ug4XflB+aqePoM0QjCebDzP06ev6MC8ohxsyXvC+Q+MeD1jwHyQm7YBJWQn4/M7L5SNCz48vu3uHS5NnaD7ecNmgHBaTo6EtbqzDJ76mWO8tBdODlV7I6FMuoRVd7h90yu6BHA/WRR5M3d4iFCjKhmHpHwwKzJ7KPqdIiLdf2PZp7JDJRbjHrW8wVX5U2npzlMfYqpO2fAJqhIdIzREXuTl/WlRuYModTpIBBuekZFyfxyNWsrhs0ld7qo3xrfmpHMytR6gDHdf0YhsUuQiXO+sY9UjJbUSNU00sAOvlpPlREFB3hwiyjP13g0pt5qSEnybB6ejzGzM7AnNMr99uUHTNVJ0II6yVPtYZt+vvc77Yk1QAGMxhtguhrLd9VUrGlx4znrk9Y+l2aApwMjX2wZEieJNx5r74L2h3ZGKDkv86k3o5TQ4RGdj0IvnO19EJ1FLIYYYcb9xUb0MJkWo06XX9nbuVaePAdnB43shnr2OPuuZzZd2dwmoNfwytF/U60nMmBAkbnjdnmAcveV1LrFADAVRGEGL4JTpCbFOfnKn3VVKRGWvzGhNR0pOnKQAS329cdcB9veOfpZ0b1dat1gK7611bg/wra6EL4w==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230016)(4636009)(136003)(39860400002)(346002)(396003)(376002)(36840700001)(40470700004)(46966006)(16526019)(7696005)(26005)(426003)(47076005)(336012)(2616005)(186003)(1076003)(44832011)(5660300002)(8936002)(36756003)(41300700001)(6666004)(86362001)(478600001)(36860700001)(83380400001)(356005)(81166007)(54906003)(6636002)(110136005)(82310400005)(2906002)(40480700001)(316002)(40460700003)(82740400003)(4326008)(8676002)(70206006)(70586007)(450100002)(83323001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 Sep 2022 08:48:31.0242 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6166c66a-fcab-4eff-9e51-08da8cbfe98f", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CY4PEPF0000B8ED.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN9PR12MB5306", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Updated the RSS hash and CSUM checks with first_seg instead of mbufs.\n\nFixes: 965b3127d425 (\"net/axgbe: support scattered Rx\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bhagyada Modali <bhagyada.modali@amd.com>\n---\n drivers/net/axgbe/axgbe_rxtx.c | 41 +++++++++++++++++++++-------------\n 1 file changed, 25 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c\nindex 7c07fd90ef..2bad638f79 100644\n--- a/drivers/net/axgbe/axgbe_rxtx.c\n+++ b/drivers/net/axgbe/axgbe_rxtx.c\n@@ -427,24 +427,27 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue,\n \n \t\t/* Get the RSS hash */\n \t\tif (AXGMAC_GET_BITS_LE(desc->write.desc3, RX_NORMAL_DESC3, RSV))\n-\t\t\tmbuf->hash.rss = rte_le_to_cpu_32(desc->write.desc1);\n+\t\t\tfirst_seg->hash.rss =\n+\t\t\t\trte_le_to_cpu_32(desc->write.desc1);\n \t\tetlt = AXGMAC_GET_BITS_LE(desc->write.desc3,\n \t\t\t\tRX_NORMAL_DESC3, ETLT);\n \t\toffloads = rxq->pdata->eth_dev->data->dev_conf.rxmode.offloads;\n \t\tif (!err || !etlt) {\n \t\t\tif (etlt == RX_CVLAN_TAG_PRESENT) {\n-\t\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_VLAN;\n-\t\t\t\tmbuf->vlan_tci =\n+\t\t\t\tfirst_seg->ol_flags |= RTE_MBUF_F_RX_VLAN;\n+\t\t\t\tfirst_seg->vlan_tci =\n \t\t\t\t\tAXGMAC_GET_BITS_LE(desc->write.desc0,\n \t\t\t\t\t\t\tRX_NORMAL_DESC0, OVT);\n \t\t\t\tif (offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)\n-\t\t\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_VLAN_STRIPPED;\n+\t\t\t\t\tfirst_seg->ol_flags |=\n+\t\t\t\t\t\tRTE_MBUF_F_RX_VLAN_STRIPPED;\n \t\t\t\telse\n-\t\t\t\t\tmbuf->ol_flags &= ~RTE_MBUF_F_RX_VLAN_STRIPPED;\n+\t\t\t\t\tfirst_seg->ol_flags &=\n+\t\t\t\t\t\t~RTE_MBUF_F_RX_VLAN_STRIPPED;\n \t\t\t} else {\n-\t\t\t\tmbuf->ol_flags &=\n+\t\t\t\tfirst_seg->ol_flags &=\n \t\t\t\t\t~(RTE_MBUF_F_RX_VLAN | RTE_MBUF_F_RX_VLAN_STRIPPED);\n-\t\t\t\tmbuf->vlan_tci = 0;\n+\t\t\t\tfirst_seg->vlan_tci = 0;\n \t\t\t}\n \t\t}\n \n@@ -468,18 +471,24 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue,\n \n \t\tfirst_seg->port = rxq->port_id;\n \t\tif (rxq->pdata->rx_csum_enable) {\n-\t\t\tmbuf->ol_flags = 0;\n-\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;\n-\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;\n+\t\t\tfirst_seg->ol_flags = 0;\n+\t\t\tfirst_seg->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;\n+\t\t\tfirst_seg->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;\n \t\t\tif (unlikely(error_status == AXGBE_L3_CSUM_ERR)) {\n-\t\t\t\tmbuf->ol_flags &= ~RTE_MBUF_F_RX_IP_CKSUM_GOOD;\n-\t\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD;\n-\t\t\t\tmbuf->ol_flags &= ~RTE_MBUF_F_RX_L4_CKSUM_GOOD;\n-\t\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN;\n+\t\t\t\tfirst_seg->ol_flags &=\n+\t\t\t\t\t~RTE_MBUF_F_RX_IP_CKSUM_GOOD;\n+\t\t\t\tfirst_seg->ol_flags |=\n+\t\t\t\t\tRTE_MBUF_F_RX_IP_CKSUM_BAD;\n+\t\t\t\tfirst_seg->ol_flags &=\n+\t\t\t\t\t~RTE_MBUF_F_RX_L4_CKSUM_GOOD;\n+\t\t\t\tfirst_seg->ol_flags |=\n+\t\t\t\t\tRTE_MBUF_F_RX_L4_CKSUM_UNKNOWN;\n \t\t\t} else if (unlikely(error_status\n \t\t\t\t\t\t== AXGBE_L4_CSUM_ERR)) {\n-\t\t\t\tmbuf->ol_flags &= ~RTE_MBUF_F_RX_L4_CKSUM_GOOD;\n-\t\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;\n+\t\t\t\tfirst_seg->ol_flags &=\n+\t\t\t\t\t~RTE_MBUF_F_RX_L4_CKSUM_GOOD;\n+\t\t\t\tfirst_seg->ol_flags |=\n+\t\t\t\t\tRTE_MBUF_F_RX_L4_CKSUM_BAD;\n \t\t\t}\n \t\t}\n \n", "prefixes": [ "v3", "4/4" ] }