Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115768/?format=api
{ "id": 115768, "url": "https://patches.dpdk.org/api/patches/115768/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220902030011.377523-7-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220902030011.377523-7-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220902030011.377523-7-jiawenwu@trustnetic.com", "date": "2022-09-02T03:00:08", "name": "[6/9] net/ngbe: remove semaphore between SW/FW", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "35ceab428e4bb0f4d67301f2814a70a061a79ec3", "submitter": { "id": 1932, "url": "https://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220902030011.377523-7-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 24512, "url": "https://patches.dpdk.org/api/series/24512/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24512", "date": "2022-09-02T03:00:02", "name": "Wangxun fixes and supports", "version": 1, "mbox": "https://patches.dpdk.org/series/24512/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/115768/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/115768/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AF7C6A0542;\n\tFri, 2 Sep 2022 05:01:31 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B87C942B7B;\n\tFri, 2 Sep 2022 05:01:03 +0200 (CEST)", "from smtpbg.qq.com (smtpbgeu2.qq.com [18.194.254.142])\n by mails.dpdk.org (Postfix) with ESMTP id D3D1D427F4;\n Fri, 2 Sep 2022 05:01:00 +0200 (CEST)", "from wxdbg.localdomain.com ( [183.129.236.74])\n by bizesmtp.qq.com (ESMTP) with\n id ; Fri, 02 Sep 2022 11:00:56 +0800 (CST)" ], "X-QQ-mid": "bizesmtp70t1662087657tv66i7q0", "X-QQ-SSF": "01400000000000G0T000000A0000000", "X-QQ-FEAT": "Vi+pOBAqRtdoGsmo+1b4Jw4WsUJntc0UUppQ1oo4FBB8vbH/FkCm9I45dcAPl\n Qbgfuy6jScijrO+Ka0oG9HdDLNipcLjKvCKzVQ13HcNoqO5Jqjlnf8bmHPBeIh5wQyQFoCF\n iC1HpUW3UBw6USckBXNBxNuU1BpSr6lXqQFTyjnQ5T1C+sx00lSKq3WN2OtxWOm362NGT3v\n ++vuI/rs2hmrC7dYnU8txt8ji+4bRNPna6VTmwZYygbTJ4L5zXSVrpIqT6on+5J3jgzbEZL\n /g8X6XoS/r0brsYRlcVMZi6Hit0vkkKvWJbGqdHsel2nNd45h5TN+Y/ztlN3LzMtnCZen2A\n o1r7xhznhYL/9ArVHbqgQhtlWP3T5R3n9sFBqeXoOAv7QNbS288uulS3RqbwnWw5m8r+vkE\n N3/7rPf4VRo=", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 6/9] net/ngbe: remove semaphore between SW/FW", "Date": "Fri, 2 Sep 2022 11:00:08 +0800", "Message-Id": "<20220902030011.377523-7-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20220902030011.377523-1-jiawenwu@trustnetic.com>", "References": "<20220902030011.377523-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybglogicsvr:qybglogicsvr5", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Since firmware does not use the semaphore between software and firmware.\nRemove useless unilateral semaphore setting.\n\nFixes: f501a195bded (\"net/ngbe: initialize and validate EEPROM\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/ngbe/base/ngbe_eeprom.c | 32 -----------------------------\n 1 file changed, 32 deletions(-)", "diff": "diff --git a/drivers/net/ngbe/base/ngbe_eeprom.c b/drivers/net/ngbe/base/ngbe_eeprom.c\nindex 6375ee9b29..104501fa7a 100644\n--- a/drivers/net/ngbe/base/ngbe_eeprom.c\n+++ b/drivers/net/ngbe/base/ngbe_eeprom.c\n@@ -105,37 +105,6 @@ s32 ngbe_get_eeprom_semaphore(struct ngbe_hw *hw)\n \t\t\tstatus = 0;\n \t}\n \n-\t/* Now get the semaphore between SW/FW through the SWESMBI bit */\n-\tif (status == 0) {\n-\t\tfor (i = 0; i < timeout; i++) {\n-\t\t\t/* Set the SW EEPROM semaphore bit to request access */\n-\t\t\twr32m(hw, NGBE_MNGSWSYNC,\n-\t\t\t\tNGBE_MNGSWSYNC_REQ, NGBE_MNGSWSYNC_REQ);\n-\n-\t\t\t/*\n-\t\t\t * If we set the bit successfully then we got the\n-\t\t\t * semaphore.\n-\t\t\t */\n-\t\t\tswsm = rd32(hw, NGBE_MNGSWSYNC);\n-\t\t\tif (swsm & NGBE_MNGSWSYNC_REQ)\n-\t\t\t\tbreak;\n-\n-\t\t\tusec_delay(50);\n-\t\t}\n-\n-\t\t/*\n-\t\t * Release semaphores and return error if SW EEPROM semaphore\n-\t\t * was not granted because we don't have access to the EEPROM\n-\t\t */\n-\t\tif (i >= timeout) {\n-\t\t\tDEBUGOUT(\"SWESMBI Software EEPROM semaphore not granted.\");\n-\t\t\tngbe_release_eeprom_semaphore(hw);\n-\t\t\tstatus = NGBE_ERR_EEPROM;\n-\t\t}\n-\t} else {\n-\t\tDEBUGOUT(\"Software semaphore SMBI between device drivers not granted.\");\n-\t}\n-\n \treturn status;\n }\n \n@@ -147,7 +116,6 @@ s32 ngbe_get_eeprom_semaphore(struct ngbe_hw *hw)\n **/\n void ngbe_release_eeprom_semaphore(struct ngbe_hw *hw)\n {\n-\twr32m(hw, NGBE_MNGSWSYNC, NGBE_MNGSWSYNC_REQ, 0);\n \twr32m(hw, NGBE_SWSEM, NGBE_SWSEM_PF, 0);\n \tngbe_flush(hw);\n }\n", "prefixes": [ "6/9" ] }