Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115767/?format=api
{ "id": 115767, "url": "https://patches.dpdk.org/api/patches/115767/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220902030011.377523-6-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220902030011.377523-6-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220902030011.377523-6-jiawenwu@trustnetic.com", "date": "2022-09-02T03:00:07", "name": "[5/9] net/ngbe: rename some extended statistic", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "75b9fe74f51fd025a1be9d140b9b1fb9b0008311", "submitter": { "id": 1932, "url": "https://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220902030011.377523-6-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 24512, "url": "https://patches.dpdk.org/api/series/24512/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24512", "date": "2022-09-02T03:00:02", "name": "Wangxun fixes and supports", "version": 1, "mbox": "https://patches.dpdk.org/series/24512/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/115767/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/115767/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 491BAA0542;\n\tFri, 2 Sep 2022 05:01:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B0AC842B72;\n\tFri, 2 Sep 2022 05:01:02 +0200 (CEST)", "from smtpbg.qq.com (smtpbgbr2.qq.com [54.207.22.56])\n by mails.dpdk.org (Postfix) with ESMTP id DD08242905;\n Fri, 2 Sep 2022 05:00:58 +0200 (CEST)", "from wxdbg.localdomain.com ( [183.129.236.74])\n by bizesmtp.qq.com (ESMTP) with\n id ; Fri, 02 Sep 2022 11:00:54 +0800 (CST)" ], "X-QQ-mid": "bizesmtp70t1662087654tepkcmy2", "X-QQ-SSF": "01400000000000G0T000000A0000000", "X-QQ-FEAT": "NGMqyHdgFPZqCS0z2PNXX4doXELaub0YVRMf4GgE1HSaOv9wmwGrkMr73bkbV\n WT0TBkx0pXrvZTeCvWQCLYPHrsC4pd9PUQKq+C6/Iz9OdX7Ov4Z4YiYyAquGR3GoY/KmJlF\n vU2I51pmbp47OdxR5yLrAJdFf4Bth5X07Vnn/1EPC6lPuihSeN3DllBlZr6eNuKAv5kAKJM\n UvSPlImbkjjzt9UTs/3fmQrIOYZXTKi0vv8cbDUC9oqyUm+CAJkk0iIci7daxKuxMRNBIKd\n tgY/vYUwZbqzG+FIW+4DZmQV+R+YTCAv6yA+Dn3Hv0vHH7+JA+Ij0YHPpkv3tdUwv5m2ov+\n ceyivJaPkEiEsIShShEjZZKqjdJz+mDyujhAH2e0mvE26FcbCkF4/n3UpXst3vdhyOyk61F", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 5/9] net/ngbe: rename some extended statistic", "Date": "Fri, 2 Sep 2022 11:00:07 +0800", "Message-Id": "<20220902030011.377523-6-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20220902030011.377523-1-jiawenwu@trustnetic.com>", "References": "<20220902030011.377523-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybglogicsvr:qybglogicsvr5", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Rename rx_oversize_errors to rx_oversize_cnt since it depends on giant\npacket size limit instead of MTU, by hardware design.\nRename rx_drop_packets and tx_drop_packets to rx_dma_drop and tx_dma_drop\nto indicate the drop location.\nAnd add tx_dma_drop to extended statistics.\n\nFixes: 8b433d04adc9 (\"net/ngbe: support device xstats\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/ngbe/base/ngbe_type.h | 5 ++---\n drivers/net/ngbe/ngbe_ethdev.c | 10 +++++-----\n 2 files changed, 7 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ngbe/base/ngbe_type.h b/drivers/net/ngbe/base/ngbe_type.h\nindex 4a6c273f1e..73111f7950 100644\n--- a/drivers/net/ngbe/base/ngbe_type.h\n+++ b/drivers/net/ngbe/base/ngbe_type.h\n@@ -142,9 +142,8 @@ struct ngbe_hw_stats {\n \tu64 mng_bmc2host_packets;\n \tu64 mng_host2bmc_packets;\n \t/* Basix RxTx */\n-\tu64 rx_drop_packets;\n-\tu64 tx_drop_packets;\n \tu64 rx_dma_drop;\n+\tu64 tx_dma_drop;\n \tu64 tx_secdrp_packets;\n \tu64 rx_packets;\n \tu64 tx_packets;\n@@ -170,7 +169,7 @@ struct ngbe_hw_stats {\n \tu64 rx_length_errors;\n \tu64 rx_undersize_errors;\n \tu64 rx_fragment_errors;\n-\tu64 rx_oversize_errors;\n+\tu64 rx_oversize_cnt;\n \tu64 rx_jabber_errors;\n \tu64 rx_l3_l4_xsum_error;\n \tu64 mac_local_errors;\ndiff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c\nindex 86c28099c4..df32bf64ff 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.c\n+++ b/drivers/net/ngbe/ngbe_ethdev.c\n@@ -165,6 +165,7 @@ static const struct rte_ngbe_xstats_name_off rte_ngbe_stats_strings[] = {\n \tHW_XSTAT(tx_management_packets),\n \tHW_XSTAT(rx_management_dropped),\n \tHW_XSTAT(rx_dma_drop),\n+\tHW_XSTAT(tx_dma_drop),\n \tHW_XSTAT(tx_secdrp_packets),\n \n \t/* Basic Error */\n@@ -175,7 +176,7 @@ static const struct rte_ngbe_xstats_name_off rte_ngbe_stats_strings[] = {\n \tHW_XSTAT(rx_length_errors),\n \tHW_XSTAT(rx_undersize_errors),\n \tHW_XSTAT(rx_fragment_errors),\n-\tHW_XSTAT(rx_oversize_errors),\n+\tHW_XSTAT(rx_oversize_cnt),\n \tHW_XSTAT(rx_jabber_errors),\n \tHW_XSTAT(rx_l3_l4_xsum_error),\n \tHW_XSTAT(mac_local_errors),\n@@ -1374,9 +1375,8 @@ ngbe_read_stats_registers(struct ngbe_hw *hw,\n \thw_stats->rx_xoff_packets += rd32(hw, NGBE_PBRXLNKXOFF);\n \n \t/* DMA Stats */\n-\thw_stats->rx_drop_packets += rd32(hw, NGBE_DMARXDROP);\n-\thw_stats->tx_drop_packets += rd32(hw, NGBE_DMATXDROP);\n \thw_stats->rx_dma_drop += rd32(hw, NGBE_DMARXDROP);\n+\thw_stats->tx_dma_drop += rd32(hw, NGBE_DMATXDROP);\n \thw_stats->tx_secdrp_packets += rd32(hw, NGBE_DMATXSECDROP);\n \thw_stats->rx_packets += rd32(hw, NGBE_DMARXPKT);\n \thw_stats->tx_packets += rd32(hw, NGBE_DMATXPKT);\n@@ -1413,7 +1413,7 @@ ngbe_read_stats_registers(struct ngbe_hw *hw,\n \t\t\trd64(hw, NGBE_MACTX1024TOMAXL);\n \n \thw_stats->rx_undersize_errors += rd64(hw, NGBE_MACRXERRLENL);\n-\thw_stats->rx_oversize_errors += rd32(hw, NGBE_MACRXOVERSIZE);\n+\thw_stats->rx_oversize_cnt += rd32(hw, NGBE_MACRXOVERSIZE);\n \thw_stats->rx_jabber_errors += rd32(hw, NGBE_MACRXJABBER);\n \n \t/* MNG Stats */\n@@ -1512,7 +1512,7 @@ ngbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \t\t\t hw_stats->rx_mac_short_packet_dropped +\n \t\t\t hw_stats->rx_length_errors +\n \t\t\t hw_stats->rx_undersize_errors +\n-\t\t\t hw_stats->rx_oversize_errors +\n+\t\t\t hw_stats->rdb_drp_cnt +\n \t\t\t hw_stats->rx_illegal_byte_errors +\n \t\t\t hw_stats->rx_error_bytes +\n \t\t\t hw_stats->rx_fragment_errors;\n", "prefixes": [ "5/9" ] }