Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115764/?format=api
{ "id": 115764, "url": "https://patches.dpdk.org/api/patches/115764/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220902030011.377523-2-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220902030011.377523-2-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220902030011.377523-2-jiawenwu@trustnetic.com", "date": "2022-09-02T03:00:03", "name": "[1/9] net/txgbe: fix IPv6 rule in flow director", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a1df5c3fc57c817f03964de69972694c9ebbc7df", "submitter": { "id": 1932, "url": "https://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220902030011.377523-2-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 24512, "url": "https://patches.dpdk.org/api/series/24512/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24512", "date": "2022-09-02T03:00:02", "name": "Wangxun fixes and supports", "version": 1, "mbox": "https://patches.dpdk.org/series/24512/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/115764/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/115764/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 834F5A0542;\n\tFri, 2 Sep 2022 05:01:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 22FBE4280B;\n\tFri, 2 Sep 2022 05:00:54 +0200 (CEST)", "from smtpbg.qq.com (smtpbgbr2.qq.com [54.207.22.56])\n by mails.dpdk.org (Postfix) with ESMTP id 93C7940E09;\n Fri, 2 Sep 2022 05:00:49 +0200 (CEST)", "from wxdbg.localdomain.com ( [183.129.236.74])\n by bizesmtp.qq.com (ESMTP) with\n id ; Fri, 02 Sep 2022 11:00:44 +0800 (CST)" ], "X-QQ-mid": "bizesmtp70t1662087644td3ja4ou", "X-QQ-SSF": "01400000000000G0T000000A0000000", "X-QQ-FEAT": "q+EIYT+FhZpUq6uvjhG9Cryqz8rZ2EVGErbTEqunJhS/NhclwxrRBXEWKfEX1\n eWPsQXoAQLMKaCfZkkQDvNUBhxhTOmvQijprEuwTatEZ6z4kpxXORUQC+t4OZ2EQr7pVUIA\n Qeoa3p3MocEHqVQsvExgu7dh9uhenDEsIbkJy9oFR99SmxrRMf3CyF5n8cZfmBwB5lNemuS\n pl/XFCYZ18zMRVp/Us9H8Vujd50iIJsFZ2D6iCwN+PUbLKqLvZ40imny73uBtcd0JGBL/v8\n PZGNJRoZVnP0EVUNVBy3wRcokBgL2tS11ipo9Y0hHY9Y9mYtaQvMq2HTbUim89KX1oVi+Q+\n 3SL+l2SFIgTlM3UVQP97SECU7PC7V5AI7tpUW+Yco5jKbA59Kyhr7Btn37fG3kunNAuUJSG", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 1/9] net/txgbe: fix IPv6 rule in flow director", "Date": "Fri, 2 Sep 2022 11:00:03 +0800", "Message-Id": "<20220902030011.377523-2-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20220902030011.377523-1-jiawenwu@trustnetic.com>", "References": "<20220902030011.377523-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybglogicsvr:qybglogicsvr5", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Convert the correct packet type and flow type, to fix IPv6 rule in FDIR.\n\nFixes: b973ee26747a (\"net/txgbe: parse flow director filter\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_flow.c | 33 ++++++++++++++++++++++++++-------\n 1 file changed, 26 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c\nindex d0093c0163..07d0337095 100644\n--- a/drivers/net/txgbe/txgbe_flow.c\n+++ b/drivers/net/txgbe/txgbe_flow.c\n@@ -1583,9 +1583,7 @@ txgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev __rte_unused,\n \t * value. So, we need not do anything for the not provided fields later.\n \t */\n \tmemset(rule, 0, sizeof(struct txgbe_fdir_rule));\n-\tmemset(&rule->mask, 0xFF, sizeof(struct txgbe_hw_fdir_mask));\n-\trule->mask.vlan_tci_mask = 0;\n-\trule->mask.flex_bytes_mask = 0;\n+\tmemset(&rule->mask, 0, sizeof(struct txgbe_hw_fdir_mask));\n \n \t/**\n \t * The first not void item should be\n@@ -1867,7 +1865,10 @@ txgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev __rte_unused,\n \t\t * as we must have a flow type.\n \t\t */\n \t\trule->input.flow_type |= TXGBE_ATR_L4TYPE_TCP;\n-\t\tptype = txgbe_ptype_table[TXGBE_PT_IPV4_TCP];\n+\t\tif (rule->input.flow_type & TXGBE_ATR_FLOW_TYPE_IPV6)\n+\t\t\tptype = txgbe_ptype_table[TXGBE_PT_IPV6_TCP];\n+\t\telse\n+\t\t\tptype = txgbe_ptype_table[TXGBE_PT_IPV4_TCP];\n \t\t/*Not supported last point for range*/\n \t\tif (item->last) {\n \t\t\trte_flow_error_set(error, EINVAL,\n@@ -1931,7 +1932,10 @@ txgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev __rte_unused,\n \t\t * as we must have a flow type.\n \t\t */\n \t\trule->input.flow_type |= TXGBE_ATR_L4TYPE_UDP;\n-\t\tptype = txgbe_ptype_table[TXGBE_PT_IPV4_UDP];\n+\t\tif (rule->input.flow_type & TXGBE_ATR_FLOW_TYPE_IPV6)\n+\t\t\tptype = txgbe_ptype_table[TXGBE_PT_IPV6_UDP];\n+\t\telse\n+\t\t\tptype = txgbe_ptype_table[TXGBE_PT_IPV4_UDP];\n \t\t/*Not supported last point for range*/\n \t\tif (item->last) {\n \t\t\trte_flow_error_set(error, EINVAL,\n@@ -1990,7 +1994,10 @@ txgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev __rte_unused,\n \t\t * as we must have a flow type.\n \t\t */\n \t\trule->input.flow_type |= TXGBE_ATR_L4TYPE_SCTP;\n-\t\tptype = txgbe_ptype_table[TXGBE_PT_IPV4_SCTP];\n+\t\tif (rule->input.flow_type & TXGBE_ATR_FLOW_TYPE_IPV6)\n+\t\t\tptype = txgbe_ptype_table[TXGBE_PT_IPV6_SCTP];\n+\t\telse\n+\t\t\tptype = txgbe_ptype_table[TXGBE_PT_IPV4_SCTP];\n \t\t/*Not supported last point for range*/\n \t\tif (item->last) {\n \t\t\trte_flow_error_set(error, EINVAL,\n@@ -2141,6 +2148,16 @@ txgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev __rte_unused,\n \n \trule->input.pkt_type = cpu_to_be16(txgbe_encode_ptype(ptype));\n \n+\tif (rule->input.flow_type & TXGBE_ATR_FLOW_TYPE_IPV6) {\n+\t\tif (rule->input.flow_type & TXGBE_ATR_L4TYPE_MASK)\n+\t\t\trule->input.pkt_type &= 0xFFFF;\n+\t\telse\n+\t\t\trule->input.pkt_type &= 0xF8FF;\n+\n+\t\trule->input.flow_type &= TXGBE_ATR_L3TYPE_MASK |\n+\t\t\t\t\tTXGBE_ATR_L4TYPE_MASK;\n+\t}\n+\n \treturn txgbe_parse_fdir_act_attr(attr, actions, rule, error);\n }\n \n@@ -2827,8 +2844,10 @@ txgbe_flow_create(struct rte_eth_dev *dev,\n \t\t\t\tret = memcmp(&fdir_info->mask,\n \t\t\t\t\t&fdir_rule.mask,\n \t\t\t\t\tsizeof(struct txgbe_hw_fdir_mask));\n-\t\t\t\tif (ret)\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tPMD_DRV_LOG(ERR, \"only support one global mask\");\n \t\t\t\t\tgoto out;\n+\t\t\t\t}\n \n \t\t\t\tif (fdir_info->flex_bytes_offset !=\n \t\t\t\t\t\tfdir_rule.flex_bytes_offset)\n", "prefixes": [ "1/9" ] }