Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115720/?format=api
https://patches.dpdk.org/api/patches/115720/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220901103501.304471-1-brian.dooley@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220901103501.304471-1-brian.dooley@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220901103501.304471-1-brian.dooley@intel.com", "date": "2022-09-01T10:35:01", "name": "[v2] examples/fips_validation: add parsing for AES GMAC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d9c9c99638df71645e564e785cc5453bf379cceb", "submitter": { "id": 2520, "url": "https://patches.dpdk.org/api/people/2520/?format=api", "name": "Dooley, Brian", "email": "brian.dooley@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220901103501.304471-1-brian.dooley@intel.com/mbox/", "series": [ { "id": 24500, "url": "https://patches.dpdk.org/api/series/24500/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24500", "date": "2022-09-01T10:35:01", "name": "[v2] examples/fips_validation: add parsing for AES GMAC", "version": 2, "mbox": "https://patches.dpdk.org/series/24500/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/115720/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/115720/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2607DA0032;\n\tThu, 1 Sep 2022 12:35:31 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 092D740C35;\n\tThu, 1 Sep 2022 12:35:31 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id F00AF40695\n for <dev@dpdk.org>; Thu, 1 Sep 2022 12:35:28 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Sep 2022 03:35:20 -0700", "from silpixa00400883.ir.intel.com ([10.243.23.134])\n by orsmga003.jf.intel.com with ESMTP; 01 Sep 2022 03:35:18 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1662028529; x=1693564529;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=LsV347yukJorGYoaOBKchFQQBVMo8rKQQFNMJ51IHEU=;\n b=Jizd9uzKZy5YQHiuzs4dNIBYa9JJkVVeoQ7xaYTJ6evX5m3uPTBz7bdm\n lTZ/jspC5BBhyNL7RMvXkl7oLrM5Yd9cVzDdQK9G+g+ohjCC2ibJN9/me\n bb9EW8MaAUKA2DIiqSJ1ADA0P/QrpHDps53M0BHob5Qm6/WvgCRmA3kTN\n wQNtgsVGLTuXlj5JhbecP5IoKlFe3082DF7xH27YaOMRQbb/891MyL519\n QLceMesP6L/29sv/DHCmaUKEBNa9vqj319sZkzPMHGcfCPirUlRDkbsu7\n kedecJkktrKN10BdfKKOsV0Qk/hUU0f3TcdjsvU1VZ+Exo/sLUJLt18P/ g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10456\"; a=\"275428303\"", "E=Sophos;i=\"5.93,280,1654585200\"; d=\"scan'208\";a=\"275428303\"", "E=Sophos;i=\"5.93,280,1654585200\"; d=\"scan'208\";a=\"563408467\"" ], "X-ExtLoop1": "1", "From": "Brian Dooley <brian.dooley@intel.com>", "To": "Fan Zhang <roy.fan.zhang@intel.com>, Brian Dooley <brian.dooley@intel.com>", "Cc": "dev@dpdk.org, gmuthukrishn@marvell.com, gakhil@marvell.com,\n kai.ji@intel.com", "Subject": "[PATCH v2] examples/fips_validation: add parsing for AES GMAC", "Date": "Thu, 1 Sep 2022 10:35:01 +0000", "Message-Id": "<20220901103501.304471-1-brian.dooley@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220819094608.7874-1-brian.dooley@intel.com>", "References": "<20220819094608.7874-1-brian.dooley@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Added functionality to parse algorithm for AES GMAC test\n\nSigned-off-by: Brian Dooley <brian.dooley@intel.com>\n---\nv2: add random internal iv generation\n---\n examples/fips_validation/fips_validation.c | 2 ++\n examples/fips_validation/fips_validation.h | 1 +\n .../fips_validation/fips_validation_gcm.c | 13 ++++++------\n examples/fips_validation/main.c | 21 +++++++++++++++++++\n 4 files changed, 31 insertions(+), 6 deletions(-)", "diff": "diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c\nindex 12b9b03f56..5c7ecce412 100644\n--- a/examples/fips_validation/fips_validation.c\n+++ b/examples/fips_validation/fips_validation.c\n@@ -458,6 +458,8 @@ fips_test_parse_one_json_vector_set(void)\n \t/* Vector sets contain the algorithm type, and nothing else we need. */\n \tif (strstr(algo_str, \"AES-GCM\"))\n \t\tinfo.algo = FIPS_TEST_ALGO_AES_GCM;\n+\telse if (strstr(algo_str, \"AES-GMAC\"))\n+\t\tinfo.algo = FIPS_TEST_ALGO_AES_GMAC;\n \telse if (strstr(algo_str, \"HMAC\"))\n \t\tinfo.algo = FIPS_TEST_ALGO_HMAC;\n \telse if (strstr(algo_str, \"CMAC\"))\ndiff --git a/examples/fips_validation/fips_validation.h b/examples/fips_validation/fips_validation.h\nindex 5c1abcbd91..24edab68da 100644\n--- a/examples/fips_validation/fips_validation.h\n+++ b/examples/fips_validation/fips_validation.h\n@@ -36,6 +36,7 @@ enum fips_test_algorithms {\n \t\tFIPS_TEST_ALGO_AES = 0,\n \t\tFIPS_TEST_ALGO_AES_CBC,\n \t\tFIPS_TEST_ALGO_AES_GCM,\n+\t\tFIPS_TEST_ALGO_AES_GMAC,\n \t\tFIPS_TEST_ALGO_AES_CMAC,\n \t\tFIPS_TEST_ALGO_AES_CCM,\n \t\tFIPS_TEST_ALGO_AES_XTS,\ndiff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c\nindex 6b3d158629..7e1bd77faf 100644\n--- a/examples/fips_validation/fips_validation_gcm.c\n+++ b/examples/fips_validation/fips_validation_gcm.c\n@@ -291,13 +291,14 @@ parse_test_gcm_json_writeback(struct fips_val *val)\n \n \tif (info.op == FIPS_TEST_ENC_AUTH_GEN) {\n \t\tjson_t *ct;\n+\t\tif (!info.interim_info.gcm_data.is_gmac) {\n+\t\t\ttmp_val.val = val->val;\n+\t\t\ttmp_val.len = vec.pt.len;\n \n-\t\ttmp_val.val = val->val;\n-\t\ttmp_val.len = vec.pt.len;\n-\n-\t\twriteback_hex_str(\"\", info.one_line_text, &tmp_val);\n-\t\tct = json_string(info.one_line_text);\n-\t\tjson_object_set_new(json_info.json_write_case, CT_JSON_STR, ct);\n+\t\t\twriteback_hex_str(\"\", info.one_line_text, &tmp_val);\n+\t\t\tct = json_string(info.one_line_text);\n+\t\t\tjson_object_set_new(json_info.json_write_case, CT_JSON_STR, ct);\n+\t\t}\n \n \t\tif (info.interim_info.gcm_data.gen_iv) {\n \t\t\tjson_t *iv;\ndiff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c\nindex 8bd5a66889..9118ca4d92 100644\n--- a/examples/fips_validation/main.c\n+++ b/examples/fips_validation/main.c\n@@ -669,6 +669,21 @@ prepare_auth_op(void)\n \n \t__rte_crypto_op_reset(env.op, RTE_CRYPTO_OP_TYPE_SYMMETRIC);\n \n+\tif (info.interim_info.gcm_data.gen_iv == 1) {\n+\t\tuint32_t i;\n+\n+\t\tif (!vec.iv.val) {\n+\t\t\tvec.iv.val = rte_malloc(0, vec.iv.len, 0);\n+\t\t\tif (!vec.iv.val)\n+\t\t\t\treturn -ENOMEM;\n+\t\t}\n+\n+\t\tfor (i = 0; i < vec.iv.len; i++) {\n+\t\t\tint random = rand();\n+\t\t\tvec.iv.val[i] = (uint8_t)random;\n+\t\t}\n+\t}\n+\n \tif (vec.iv.len) {\n \t\tuint8_t *iv = rte_crypto_op_ctod_offset(env.op, uint8_t *,\n \t\t\t\tIV_OFF);\n@@ -1817,6 +1832,11 @@ init_test_ops(void)\n \t\telse\n \t\t\ttest_ops.test = fips_generic_test;\n \t\tbreak;\n+\tcase FIPS_TEST_ALGO_AES_GMAC:\n+\t\ttest_ops.prepare_op = prepare_auth_op;\n+\t\ttest_ops.prepare_xform = prepare_gmac_xform;\n+\t\ttest_ops.test = fips_generic_test;\n+\t\tbreak;\n \tcase FIPS_TEST_ALGO_AES_GCM:\n \t\ttest_ops.prepare_op = prepare_aead_op;\n \t\ttest_ops.prepare_xform = prepare_gcm_xform;\n@@ -1994,6 +2014,7 @@ fips_test_one_test_group(void)\n \tjson_object_set_new(json_info.json_write_group, \"tests\", write_tests);\n \n \tswitch (info.algo) {\n+\tcase FIPS_TEST_ALGO_AES_GMAC:\n \tcase FIPS_TEST_ALGO_AES_GCM:\n \t\tret = parse_test_gcm_json_init();\n \t\tbreak;\n", "prefixes": [ "v2" ] }{ "id": 115720, "url": "