Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 115681,
    "url": "https://patches.dpdk.org/api/patches/115681/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1661899911-13086-17-git-send-email-longli@linuxonhyperv.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1661899911-13086-17-git-send-email-longli@linuxonhyperv.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1661899911-13086-17-git-send-email-longli@linuxonhyperv.com",
    "date": "2022-08-30T22:51:49",
    "name": "[v6,16/18] net/mana: add function to start/stop device",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d9e60eeb9622b0643948f97ef271132dff5f73e0",
    "submitter": {
        "id": 1784,
        "url": "https://patches.dpdk.org/api/people/1784/?format=api",
        "name": "Long Li",
        "email": "longli@linuxonhyperv.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1661899911-13086-17-git-send-email-longli@linuxonhyperv.com/mbox/",
    "series": [
        {
            "id": 24471,
            "url": "https://patches.dpdk.org/api/series/24471/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24471",
            "date": "2022-08-30T22:51:33",
            "name": "Introduce Microsoft Azure Network Adatper (MANA) PMD",
            "version": 6,
            "mbox": "https://patches.dpdk.org/series/24471/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/115681/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/115681/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 154C9A00C5;\n\tWed, 31 Aug 2022 00:53:35 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D1A7242BBC;\n\tWed, 31 Aug 2022 00:52:13 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 22A6242B8B\n for <dev@dpdk.org>; Wed, 31 Aug 2022 00:52:08 +0200 (CEST)",
            "by linux.microsoft.com (Postfix, from userid 1004)\n id 884A02045E24; Tue, 30 Aug 2022 15:52:07 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 884A02045E24",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com;\n s=default; t=1661899927;\n bh=BZFAbQTih84lbWZzjRqt1X6VqKGybcgCLMjBvMzmB4U=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:Reply-To:From;\n b=ogLZkqPSNQvBIylxpXeQNglPyVV4twn4URPoywpls15NKZJVC0S30OGuGBBxxIMJe\n Ehe1S4nU/ytxTyX+mXZPHxHVcvow92y/DnKS99g1Asb8T6Fn2DfE09ML0yo5c7U+xv\n /JNCsuSv67JAlifKG8Ag03Jebk/CMfqmZSK1Z23k=",
        "From": "longli@linuxonhyperv.com",
        "To": "Ferruh Yigit <ferruh.yigit@xilinx.com>",
        "Cc": "dev@dpdk.org, Ajay Sharma <sharmaajay@microsoft.com>,\n Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>",
        "Subject": "[Patch v6 16/18] net/mana: add function to start/stop device",
        "Date": "Tue, 30 Aug 2022 15:51:49 -0700",
        "Message-Id": "<1661899911-13086-17-git-send-email-longli@linuxonhyperv.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1661899911-13086-1-git-send-email-longli@linuxonhyperv.com>",
        "References": "<1661899911-13086-1-git-send-email-longli@linuxonhyperv.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Reply-To": "longli@microsoft.com",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Long Li <longli@microsoft.com>\n\nAdd support for starting/stopping the device.\n\nSigned-off-by: Long Li <longli@microsoft.com>\n---\nChange log:\nv2:\nUse spinlock for memory registration cache.\nAdd prefix mana_ to all function names.\nv6:\nRoll back device state on error in mana_dev_start()\n\n drivers/net/mana/mana.c | 77 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 77 insertions(+)",
    "diff": "diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c\nindex 0dcd3f3124..eb37f359db 100644\n--- a/drivers/net/mana/mana.c\n+++ b/drivers/net/mana/mana.c\n@@ -97,6 +97,81 @@ static int mana_dev_configure(struct rte_eth_dev *dev)\n \n static int mana_intr_uninstall(struct mana_priv *priv);\n \n+static int\n+mana_dev_start(struct rte_eth_dev *dev)\n+{\n+\tint ret;\n+\tstruct mana_priv *priv = dev->data->dev_private;\n+\n+\trte_spinlock_init(&priv->mr_btree_lock);\n+\tret = mana_mr_btree_init(&priv->mr_btree, MANA_MR_BTREE_CACHE_N,\n+\t\t\t\t dev->device->numa_node);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"Failed to init device MR btree %d\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\tret = mana_start_tx_queues(dev);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"failed to start tx queues %d\", ret);\n+\t\tgoto failed_tx;\n+\t}\n+\n+\tret = mana_start_rx_queues(dev);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"failed to start rx queues %d\", ret);\n+\t\tgoto failed_rx;\n+\t}\n+\n+\trte_wmb();\n+\n+\tdev->tx_pkt_burst = mana_tx_burst;\n+\tdev->rx_pkt_burst = mana_rx_burst;\n+\n+\tDRV_LOG(INFO, \"TX/RX queues have started\");\n+\n+\t/* Enable datapath for secondary processes */\n+\tmana_mp_req_on_rxtx(dev, MANA_MP_REQ_START_RXTX);\n+\n+\treturn 0;\n+\n+failed_rx:\n+\tmana_stop_tx_queues(dev);\n+\n+failed_tx:\n+\tmana_mr_btree_free(&priv->mr_btree);\n+\n+\treturn ret;\n+}\n+\n+static int\n+mana_dev_stop(struct rte_eth_dev *dev __rte_unused)\n+{\n+\tint ret;\n+\n+\tdev->tx_pkt_burst = mana_tx_burst_removed;\n+\tdev->rx_pkt_burst = mana_rx_burst_removed;\n+\n+\t/* Stop datapath on secondary processes */\n+\tmana_mp_req_on_rxtx(dev, MANA_MP_REQ_STOP_RXTX);\n+\n+\trte_wmb();\n+\n+\tret = mana_stop_tx_queues(dev);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"failed to stop tx queues\");\n+\t\treturn ret;\n+\t}\n+\n+\tret = mana_stop_rx_queues(dev);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"failed to stop tx queues\");\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int\n mana_dev_close(struct rte_eth_dev *dev)\n {\n@@ -435,6 +510,8 @@ static int mana_dev_link_update(struct rte_eth_dev *dev,\n \n const struct eth_dev_ops mana_dev_ops = {\n \t.dev_configure\t\t= mana_dev_configure,\n+\t.dev_start\t\t= mana_dev_start,\n+\t.dev_stop\t\t= mana_dev_stop,\n \t.dev_close\t\t= mana_dev_close,\n \t.dev_infos_get\t\t= mana_dev_info_get,\n \t.txq_info_get\t\t= mana_dev_tx_queue_info,\n",
    "prefixes": [
        "v6",
        "16/18"
    ]
}