Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115679/?format=api
{ "id": 115679, "url": "https://patches.dpdk.org/api/patches/115679/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1661899911-13086-15-git-send-email-longli@linuxonhyperv.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1661899911-13086-15-git-send-email-longli@linuxonhyperv.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1661899911-13086-15-git-send-email-longli@linuxonhyperv.com", "date": "2022-08-30T22:51:47", "name": "[v6,14/18] net/mana: add function to receive packets", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ea319529a29e9520107dba6987aac9d8861ddbb5", "submitter": { "id": 1784, "url": "https://patches.dpdk.org/api/people/1784/?format=api", "name": "Long Li", "email": "longli@linuxonhyperv.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1661899911-13086-15-git-send-email-longli@linuxonhyperv.com/mbox/", "series": [ { "id": 24471, "url": "https://patches.dpdk.org/api/series/24471/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24471", "date": "2022-08-30T22:51:33", "name": "Introduce Microsoft Azure Network Adatper (MANA) PMD", "version": 6, "mbox": "https://patches.dpdk.org/series/24471/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/115679/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/115679/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 79414A00C5;\n\tWed, 31 Aug 2022 00:53:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AB48F42BA6;\n\tWed, 31 Aug 2022 00:52:11 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 8EBED42B84\n for <dev@dpdk.org>; Wed, 31 Aug 2022 00:52:06 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1004)\n id F41872045E1E; Tue, 30 Aug 2022 15:52:05 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com F41872045E1E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com;\n s=default; t=1661899926;\n bh=jxA9ttEhWo1qskWz4YJBCUXFGxA9wQera6gVlzGuH9o=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:Reply-To:From;\n b=dRTbmlMb5qo3u48bbTVAP2xrCOjPJb6S8XAWpVdgRBzNkuZqDYRzQDpLVMqt7p5I3\n hj/FR6FOECwFSTGGXJHJrWiY/Rmf7p1ZjXkmk3lRrFVgWL1zNUY0WPp5+CAZyMJb6f\n wF0mPrTJnQgtbZLHp9rRLgZj+iKtehMD0ylaP/2E=", "From": "longli@linuxonhyperv.com", "To": "Ferruh Yigit <ferruh.yigit@xilinx.com>", "Cc": "dev@dpdk.org, Ajay Sharma <sharmaajay@microsoft.com>,\n Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>", "Subject": "[Patch v6 14/18] net/mana: add function to receive packets", "Date": "Tue, 30 Aug 2022 15:51:47 -0700", "Message-Id": "<1661899911-13086-15-git-send-email-longli@linuxonhyperv.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1661899911-13086-1-git-send-email-longli@linuxonhyperv.com>", "References": "<1661899911-13086-1-git-send-email-longli@linuxonhyperv.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Reply-To": "longli@microsoft.com", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Li <longli@microsoft.com>\n\nWith all the RX queues created, MANA can use those queues to receive\npackets.\n\nSigned-off-by: Long Li <longli@microsoft.com>\n---\nChange log:\nv2:\nAdd mana_ to all function names.\nRename a camel case.\n\n doc/guides/nics/features/mana.ini | 2 +\n drivers/net/mana/mana.c | 2 +\n drivers/net/mana/mana.h | 37 +++++++++++\n drivers/net/mana/mp.c | 2 +\n drivers/net/mana/rx.c | 104 ++++++++++++++++++++++++++++++\n 5 files changed, 147 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/mana.ini b/doc/guides/nics/features/mana.ini\nindex 821443b292..fdbf22d335 100644\n--- a/doc/guides/nics/features/mana.ini\n+++ b/doc/guides/nics/features/mana.ini\n@@ -6,6 +6,8 @@\n [Features]\n Link status = P\n Linux = Y\n+L3 checksum offload = Y\n+L4 checksum offload = Y\n Multiprocess aware = Y\n Queue start/stop = Y\n Removal event = Y\ndiff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c\nindex d18cc4ab0e..c349822991 100644\n--- a/drivers/net/mana/mana.c\n+++ b/drivers/net/mana/mana.c\n@@ -950,6 +950,8 @@ static int mana_pci_probe_mac(struct rte_pci_driver *pci_drv __rte_unused,\n \t\t\t\t/* fd is no not used after mapping doorbell */\n \t\t\t\tclose(fd);\n \n+\t\t\t\teth_dev->rx_pkt_burst = mana_rx_burst;\n+\n \t\t\t\trte_spinlock_lock(&mana_shared_data->lock);\n \t\t\t\tmana_shared_data->secondary_cnt++;\n \t\t\t\tmana_local_data.secondary_cnt++;\ndiff --git a/drivers/net/mana/mana.h b/drivers/net/mana/mana.h\nindex dc808d363f..bafc4d6082 100644\n--- a/drivers/net/mana/mana.h\n+++ b/drivers/net/mana/mana.h\n@@ -178,6 +178,11 @@ struct gdma_work_request {\n \n enum mana_cqe_type {\n \tCQE_INVALID = 0,\n+\n+\tCQE_RX_OKAY = 1,\n+\tCQE_RX_COALESCED_4 = 2,\n+\tCQE_RX_OBJECT_FENCE = 3,\n+\tCQE_RX_TRUNCATED = 4,\n };\n \n struct mana_cqe_header {\n@@ -203,6 +208,35 @@ struct mana_cqe_header {\n \t(NDIS_HASH_TCP_IPV4 | NDIS_HASH_UDP_IPV4 | NDIS_HASH_TCP_IPV6 | \\\n \t NDIS_HASH_UDP_IPV6 | NDIS_HASH_TCP_IPV6_EX | NDIS_HASH_UDP_IPV6_EX)\n \n+struct mana_rx_comp_per_packet_info {\n+\tuint32_t packet_length\t: 16;\n+\tuint32_t reserved0\t: 16;\n+\tuint32_t reserved1;\n+\tuint32_t packet_hash;\n+}; /* HW DATA */\n+#define RX_COM_OOB_NUM_PACKETINFO_SEGMENTS 4\n+\n+struct mana_rx_comp_oob {\n+\tstruct mana_cqe_header cqe_hdr;\n+\n+\tuint32_t rx_vlan_id\t\t\t\t: 12;\n+\tuint32_t rx_vlan_tag_present\t\t\t: 1;\n+\tuint32_t rx_outer_ip_header_checksum_succeeded\t: 1;\n+\tuint32_t rx_outer_ip_header_checksum_failed\t: 1;\n+\tuint32_t reserved\t\t\t\t: 1;\n+\tuint32_t rx_hash_type\t\t\t\t: 9;\n+\tuint32_t rx_ip_header_checksum_succeeded\t: 1;\n+\tuint32_t rx_ip_header_checksum_failed\t\t: 1;\n+\tuint32_t rx_tcp_checksum_succeeded\t\t: 1;\n+\tuint32_t rx_tcp_checksum_failed\t\t\t: 1;\n+\tuint32_t rx_udp_checksum_succeeded\t\t: 1;\n+\tuint32_t rx_udp_checksum_failed\t\t\t: 1;\n+\tuint32_t reserved1\t\t\t\t: 1;\n+\tstruct mana_rx_comp_per_packet_info\n+\t\tpacket_info[RX_COM_OOB_NUM_PACKETINFO_SEGMENTS];\n+\tuint32_t received_wqe_offset;\n+}; /* HW DATA */\n+\n struct gdma_wqe_dma_oob {\n \tuint32_t reserved:24;\n \tuint32_t last_v_bytes:8;\n@@ -371,6 +405,9 @@ int gdma_post_work_request(struct mana_gdma_queue *queue,\n \t\t\t struct gdma_posted_wqe_info *wqe_info);\n uint8_t *gdma_get_wqe_pointer(struct mana_gdma_queue *queue);\n \n+uint16_t mana_rx_burst(void *dpdk_rxq, struct rte_mbuf **rx_pkts,\n+\t\t uint16_t pkts_n);\n+\n uint16_t mana_rx_burst_removed(void *dpdk_rxq, struct rte_mbuf **pkts,\n \t\t\t uint16_t pkts_n);\n \ndiff --git a/drivers/net/mana/mp.c b/drivers/net/mana/mp.c\nindex f4f78d2787..36a88c561a 100644\n--- a/drivers/net/mana/mp.c\n+++ b/drivers/net/mana/mp.c\n@@ -138,6 +138,8 @@ static int mana_mp_secondary_handle(const struct rte_mp_msg *mp_msg,\n \tcase MANA_MP_REQ_START_RXTX:\n \t\tDRV_LOG(INFO, \"Port %u starting datapath\", dev->data->port_id);\n \n+\t\tdev->rx_pkt_burst = mana_rx_burst;\n+\n \t\trte_mb();\n \n \t\tres->result = 0;\ndiff --git a/drivers/net/mana/rx.c b/drivers/net/mana/rx.c\nindex 41d0fc9f11..f2573a6d06 100644\n--- a/drivers/net/mana/rx.c\n+++ b/drivers/net/mana/rx.c\n@@ -344,3 +344,107 @@ int mana_start_rx_queues(struct rte_eth_dev *dev)\n \tmana_stop_rx_queues(dev);\n \treturn ret;\n }\n+\n+uint16_t mana_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)\n+{\n+\tuint16_t pkt_received = 0, cqe_processed = 0;\n+\tstruct mana_rxq *rxq = dpdk_rxq;\n+\tstruct mana_priv *priv = rxq->priv;\n+\tstruct gdma_comp comp;\n+\tstruct rte_mbuf *mbuf;\n+\tint ret;\n+\n+\twhile (pkt_received < pkts_n &&\n+\t gdma_poll_completion_queue(&rxq->gdma_cq, &comp) == 1) {\n+\t\tstruct mana_rxq_desc *desc;\n+\t\tstruct mana_rx_comp_oob *oob =\n+\t\t\t(struct mana_rx_comp_oob *)&comp.completion_data[0];\n+\n+\t\tif (comp.work_queue_number != rxq->gdma_rq.id) {\n+\t\t\tDRV_LOG(ERR, \"rxq comp id mismatch wqid=0x%x rcid=0x%x\",\n+\t\t\t\tcomp.work_queue_number, rxq->gdma_rq.id);\n+\t\t\trxq->stats.errors++;\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tdesc = &rxq->desc_ring[rxq->desc_ring_tail];\n+\t\trxq->gdma_rq.tail += desc->wqe_size_in_bu;\n+\t\tmbuf = desc->pkt;\n+\n+\t\tswitch (oob->cqe_hdr.cqe_type) {\n+\t\tcase CQE_RX_OKAY:\n+\t\t\t/* Proceed to process mbuf */\n+\t\t\tbreak;\n+\n+\t\tcase CQE_RX_TRUNCATED:\n+\t\t\tDRV_LOG(ERR, \"Drop a truncated packet\");\n+\t\t\trxq->stats.errors++;\n+\t\t\trte_pktmbuf_free(mbuf);\n+\t\t\tgoto drop;\n+\n+\t\tcase CQE_RX_COALESCED_4:\n+\t\t\tDRV_LOG(ERR, \"RX coalescing is not supported\");\n+\t\t\tcontinue;\n+\n+\t\tdefault:\n+\t\t\tDRV_LOG(ERR, \"Unknown RX CQE type %d\",\n+\t\t\t\toob->cqe_hdr.cqe_type);\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\tDRV_LOG(DEBUG, \"mana_rx_comp_oob CQE_RX_OKAY rxq %p\", rxq);\n+\n+\t\tmbuf->data_off = RTE_PKTMBUF_HEADROOM;\n+\t\tmbuf->nb_segs = 1;\n+\t\tmbuf->next = NULL;\n+\t\tmbuf->pkt_len = oob->packet_info[0].packet_length;\n+\t\tmbuf->data_len = oob->packet_info[0].packet_length;\n+\t\tmbuf->port = priv->port_id;\n+\n+\t\tif (oob->rx_ip_header_checksum_succeeded)\n+\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;\n+\n+\t\tif (oob->rx_ip_header_checksum_failed)\n+\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD;\n+\n+\t\tif (oob->rx_outer_ip_header_checksum_failed)\n+\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_OUTER_IP_CKSUM_BAD;\n+\n+\t\tif (oob->rx_tcp_checksum_succeeded ||\n+\t\t oob->rx_udp_checksum_succeeded)\n+\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;\n+\n+\t\tif (oob->rx_tcp_checksum_failed ||\n+\t\t oob->rx_udp_checksum_failed)\n+\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;\n+\n+\t\tif (oob->rx_hash_type == MANA_HASH_L3 ||\n+\t\t oob->rx_hash_type == MANA_HASH_L4) {\n+\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_RSS_HASH;\n+\t\t\tmbuf->hash.rss = oob->packet_info[0].packet_hash;\n+\t\t}\n+\n+\t\tpkts[pkt_received++] = mbuf;\n+\t\trxq->stats.packets++;\n+\t\trxq->stats.bytes += mbuf->data_len;\n+\n+drop:\n+\t\trxq->desc_ring_tail++;\n+\t\tif (rxq->desc_ring_tail >= rxq->num_desc)\n+\t\t\trxq->desc_ring_tail = 0;\n+\n+\t\tcqe_processed++;\n+\n+\t\t/* Post another request */\n+\t\tret = mana_alloc_and_post_rx_wqe(rxq);\n+\t\tif (ret) {\n+\t\t\tDRV_LOG(ERR, \"failed to post rx wqe ret=%d\", ret);\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\tif (cqe_processed)\n+\t\tmana_rq_ring_doorbell(rxq);\n+\n+\treturn pkt_received;\n+}\n", "prefixes": [ "v6", "14/18" ] }