Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 11566,
    "url": "https://patches.dpdk.org/api/patches/11566/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1458238145-7496-3-git-send-email-thomas.monjalon@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1458238145-7496-3-git-send-email-thomas.monjalon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1458238145-7496-3-git-send-email-thomas.monjalon@6wind.com",
    "date": "2016-03-17T18:08:59",
    "name": "[dpdk-dev,v11,2/8] ethdev: use constants for link duplex",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b22a05c1df0c5e4771df62073d9c60ca6614a1d0",
    "submitter": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/people/1/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas.monjalon@6wind.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1458238145-7496-3-git-send-email-thomas.monjalon@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/11566/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/11566/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AC84A5908;\n\tThu, 17 Mar 2016 19:10:46 +0100 (CET)",
            "from mail-wm0-f51.google.com (mail-wm0-f51.google.com\n\t[74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 97EC758DF\n\tfor <dev@dpdk.org>; Thu, 17 Mar 2016 19:10:44 +0100 (CET)",
            "by mail-wm0-f51.google.com with SMTP id p65so37762202wmp.1\n\tfor <dev@dpdk.org>; Thu, 17 Mar 2016 11:10:44 -0700 (PDT)",
            "from XPS13.localdomain (91.111.75.86.rev.sfr.net. [86.75.111.91])\n\tby smtp.gmail.com with ESMTPSA id\n\tu14sm31196179wmu.8.2016.03.17.11.10.42\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tThu, 17 Mar 2016 11:10:43 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=P1BsOfgWj5h0m634zuiHYNy1We+9o8H8eVbAipFtBwc=;\n\tb=zgTRBgE5hpYSUZHsIK+1RzeacNfrB9PvtOkLnipMRFcgfn+9jhCPhF12yJ94flZTgN\n\tzWaMn585Iw+6OUaxJc8JsBtEnZJIFZlDKKBKrj//46NQ1IDsm49n+EB0YJLtyB1Bazn9\n\tmT/bdnB2H2LKCkbsZ/Fl8rfwjOOc9EpdAJxffw6xp9hduCXr8fugc5a71VthTacox1/m\n\tY4Ea7GQbAwgb7aq8mZQnJEDlMXy/Y/hQX+CDU+tRvfAe17ysICCMdNjVp3yVO3evviSz\n\tVsyKYetDo4ge1O6eiPL8IVDp/YjuWZUzyN4Aqnywf/AfRdBf/8zXufYqACmuS+NELtZo\n\tBEVg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=P1BsOfgWj5h0m634zuiHYNy1We+9o8H8eVbAipFtBwc=;\n\tb=Dx3zdQ2p0Nq+32ze2jSUHqaq5IECN4JBSH46xrtLnK53i1QHGu6P8RPifu6sfH9LE7\n\tW30eHPLbScJS/WvmryeMBwgB7yEOyogg6XaMxiq8T+p2UTK5IkTH7ZbbaTUWMcSvfCfg\n\tIChaEb7nwcssqOcIXSYayUkERRFgrR/JjQBvnPq9GXb9BJrsK7msc7RqHTQy/zkxE6o+\n\tM4zblD0Jqc5RGdOnj852YC57njc2MMsclMJiWOZD07B5Wwd8xC79SeE7HBcMNrRh+Xe6\n\tx6RMwvAL3BzMw2X+wTfzT8QBVPfdHRuVxnW5zbNxxr400HVz4ysYFbuQpTVX6qPnsfF3\n\tcCMQ==",
        "X-Gm-Message-State": "AD7BkJIbCrUMepnOQzD5L3Jq0zpXjvXDu/GwlezBis3ud45gBlAjmok6741PmyhdIiXqB8TK",
        "X-Received": "by 10.28.105.77 with SMTP id e74mr12841742wmc.87.1458238244454; \n\tThu, 17 Mar 2016 11:10:44 -0700 (PDT)",
        "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
        "To": "marcdevel@gmail.com, bruce.richardson@intel.com, declan.doherty@intel.com,\n\tkonstantin.ananyev@intel.com, wenzhuo.lu@intel.com,\n\thelin.zhang@intel.com, jing.d.chen@intel.com, harish.patil@qlogic.com,\n\trahul.lakkireddy@chelsio.com, johndale@cisco.com, vido@cesnet.cz,\n\tadrien.mazarguil@6wind.com, alejandro.lucero@netronome.com",
        "Cc": "dev@dpdk.org",
        "Date": "Thu, 17 Mar 2016 19:08:59 +0100",
        "Message-Id": "<1458238145-7496-3-git-send-email-thomas.monjalon@6wind.com>",
        "X-Mailer": "git-send-email 2.7.0",
        "In-Reply-To": "<1458238145-7496-1-git-send-email-thomas.monjalon@6wind.com>",
        "References": "<1457992546-32230-1-git-send-email-thomas.monjalon@6wind.com>\n\t<1458238145-7496-1-git-send-email-thomas.monjalon@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH v11 2/8] ethdev: use constants for link duplex",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Marc Sune <marcdevel@gmail.com>\n\nSome duplex values are replaced from 0 to half-duplex when link is down.\n\nSome drivers are still using their own constants for duplex modes.\n\nSigned-off-by: Marc Sune <marcdevel@gmail.com>\n---\n drivers/net/e1000/em_ethdev.c      | 2 +-\n drivers/net/e1000/igb_ethdev.c     | 2 +-\n drivers/net/ixgbe/ixgbe_ethdev.c   | 2 +-\n drivers/net/virtio/virtio_ethdev.c | 2 +-\n drivers/net/virtio/virtio_ethdev.h | 2 --\n lib/librte_ether/rte_ethdev.h      | 2 +-\n 6 files changed, 5 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex 58093c6..943a270 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -1108,7 +1108,7 @@ eth_em_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n \t\tlink.link_status = ETH_LINK_UP;\n \t} else if (!link_check && (link.link_status == ETH_LINK_UP)) {\n \t\tlink.link_speed = 0;\n-\t\tlink.link_duplex = 0;\n+\t\tlink.link_duplex = ETH_LINK_HALF_DUPLEX;\n \t\tlink.link_status = ETH_LINK_DOWN;\n \t}\n \trte_em_dev_atomic_write_link_status(dev, &link);\ndiff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex 311f866..ea156ce 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -2033,7 +2033,7 @@ eth_igb_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n \t\tlink.link_status = ETH_LINK_UP;\n \t} else if (!link_check) {\n \t\tlink.link_speed = 0;\n-\t\tlink.link_duplex = 0;\n+\t\tlink.link_duplex = ETH_LINK_HALF_DUPLEX;\n \t\tlink.link_status = ETH_LINK_DOWN;\n \t}\n \trte_igb_dev_atomic_write_link_status(dev, &link);\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex be28f7e..35dac49 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2997,7 +2997,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n \n \tlink.link_status = ETH_LINK_DOWN;\n \tlink.link_speed = 0;\n-\tlink.link_duplex = 0;\n+\tlink.link_duplex = ETH_LINK_HALF_DUPLEX;\n \tmemset(&old, 0, sizeof(old));\n \trte_ixgbe_dev_atomic_read_link_status(dev, &old);\n \ndiff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 3ebc221..63a368a 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1401,7 +1401,7 @@ virtio_dev_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complet\n \tmemset(&link, 0, sizeof(link));\n \tvirtio_dev_atomic_read_link_status(dev, &link);\n \told = link;\n-\tlink.link_duplex = FULL_DUPLEX;\n+\tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n \tlink.link_speed  = SPEED_10G;\n \n \tif (vtpci_with_feature(hw, VIRTIO_NET_F_STATUS)) {\ndiff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h\nindex fed9571..66423a0 100644\n--- a/drivers/net/virtio/virtio_ethdev.h\n+++ b/drivers/net/virtio/virtio_ethdev.h\n@@ -42,8 +42,6 @@\n #define SPEED_100\t100\n #define SPEED_1000\t1000\n #define SPEED_10G\t10000\n-#define HALF_DUPLEX\t1\n-#define FULL_DUPLEX\t2\n \n #ifndef PAGE_SIZE\n #define PAGE_SIZE 4096\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex ec8d6b1..5379bee 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -246,7 +246,7 @@ struct rte_eth_stats {\n  */\n struct rte_eth_link {\n \tuint16_t link_speed;      /**< ETH_LINK_SPEED_[10, 100, 1000, 10000] */\n-\tuint16_t link_duplex;     /**< ETH_LINK_[HALF_DUPLEX, FULL_DUPLEX] */\n+\tuint16_t link_duplex;     /**< ETH_LINK_[HALF/FULL]_DUPLEX */\n \tuint8_t  link_status : 1; /**< ETH_LINK_[DOWN/UP] */\n }__attribute__((aligned(8)));     /**< aligned for atomic64 read/write */\n \n",
    "prefixes": [
        "dpdk-dev",
        "v11",
        "2/8"
    ]
}