Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115595/?format=api
{ "id": 115595, "url": "https://patches.dpdk.org/api/patches/115595/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220829081436.29945-1-iotg.dpdk.ref.app@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220829081436.29945-1-iotg.dpdk.ref.app@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220829081436.29945-1-iotg.dpdk.ref.app@intel.com", "date": "2022-08-29T08:14:36", "name": "IGC: Remove I225_I_PHY_ID checking", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d54cae61741bd80a2d8b9c4679374cf016b523c9", "submitter": { "id": 2824, "url": "https://patches.dpdk.org/api/people/2824/?format=api", "name": null, "email": "iotg.dpdk.ref.app@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220829081436.29945-1-iotg.dpdk.ref.app@intel.com/mbox/", "series": [ { "id": 24445, "url": "https://patches.dpdk.org/api/series/24445/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24445", "date": "2022-08-29T08:14:36", "name": "IGC: Remove I225_I_PHY_ID checking", "version": 1, "mbox": "https://patches.dpdk.org/series/24445/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/115595/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/115595/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 90AC4A0542;\n\tMon, 29 Aug 2022 11:55:45 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 38A6D4069D;\n\tMon, 29 Aug 2022 11:55:45 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 6637840694\n for <dev@dpdk.org>; Mon, 29 Aug 2022 10:14:42 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Aug 2022 01:14:41 -0700", "from andromeda02.png.intel.com ([10.221.253.198])\n by fmsmga002.fm.intel.com with ESMTP; 29 Aug 2022 01:14:40 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1661760882; x=1693296882;\n h=from:to:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=PuoMUcsZUz24i9emlsIf9Qh+0CtxOH9wU1GHL3ISF8Q=;\n b=AS1rz1gXKHxsCxpD+MuNwamlI20Z8Kj9/Cz1QzWGEdy2GVPRvFuwMaFu\n TzBtTP0xlnds/hEkCitGA69ILTkjMnhifnHdsKNzRCHFBPq9YlKs8ZCxK\n Z9szI/Pbj0H5YecRNXk9cfTBCJmbKIGkDM9XAcgNR41G+PVkvQ6pvWtiS\n QVktGvcdwSwRrG6eRJQKj2sYEFpe7oBm1qvKpaFPivU7lJxWtCtanwD11\n a5hlHz08XeXRmcDKorzNT1s7vtdhKgh00X6Iuj2VpfvpBlqOiWtb7+t62\n XJBGlFifbn+71iLCs2yyHsFi5NRGXH/gvfEdlDeat1Csr2LBUOKq9G6yw g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10453\"; a=\"274589931\"", "E=Sophos;i=\"5.93,272,1654585200\"; d=\"scan'208\";a=\"274589931\"", "E=Sophos;i=\"5.93,272,1654585200\"; d=\"scan'208\";a=\"714779231\"" ], "X-ExtLoop1": "1", "From": "iotg.dpdk.ref.app@intel.com", "To": "dev@dpdk.org", "Subject": "[PATCH] IGC: Remove I225_I_PHY_ID checking", "Date": "Mon, 29 Aug 2022 16:14:36 +0800", "Message-Id": "<20220829081436.29945-1-iotg.dpdk.ref.app@intel.com>", "X-Mailer": "git-send-email 2.36.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Mon, 29 Aug 2022 11:55:43 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: NSWE SWS DPDK Dev <iotg.dpdk.ref.app@intel.com>\n\ni225 devices have only one PHY vendor. There is unnecessary to check _I_PHY_ID during the link establishment\nand auto-negotiation process, the checking also caused devices like i225-IT failed. This patch is to remove the\nmentioned unnecessary checking.\n\nCc: stable@dpdk.org\nSigned-off-by: NSWE SWS DPDK Dev <iotg.dpdk.ref.app@intel.com>\n---\n drivers/net/igc/base/igc_api.c | 1 +\n drivers/net/igc/base/igc_hw.h | 1 +\n drivers/net/igc/base/igc_i225.c | 15 ++-------------\n drivers/net/igc/base/igc_phy.c | 6 ++----\n drivers/net/igc/igc_ethdev.c | 1 +\n 5 files changed, 7 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/igc/base/igc_api.c b/drivers/net/igc/base/igc_api.c\nindex 9b791dc082..c9fc9ed4b0 100644\n--- a/drivers/net/igc/base/igc_api.c\n+++ b/drivers/net/igc/base/igc_api.c\n@@ -886,6 +886,7 @@ s32 igc_set_mac_type(struct igc_hw *hw)\n \tcase IGC_DEV_ID_I225_V:\n \tcase IGC_DEV_ID_I225_K:\n \tcase IGC_DEV_ID_I225_I:\n+\tcase IGC_DEV_ID_I225_IT:\n \tcase IGC_DEV_ID_I220_V:\n \tcase IGC_DEV_ID_I225_BLANK_NVM:\n \tcase IGC_DEV_ID_I226_K:\ndiff --git a/drivers/net/igc/base/igc_hw.h b/drivers/net/igc/base/igc_hw.h\nindex 707a1883b4..e919a11c02 100644\n--- a/drivers/net/igc/base/igc_hw.h\n+++ b/drivers/net/igc/base/igc_hw.h\n@@ -164,6 +164,7 @@ struct igc_hw;\n #define IGC_DEV_ID_I225_V\t\t\t0x15F3\n #define IGC_DEV_ID_I225_K\t\t\t0x3100\n #define IGC_DEV_ID_I225_I\t\t\t0x15F8\n+#define IGC_DEV_ID_I225_IT\t\t\t0x0D9F\n #define IGC_DEV_ID_I220_V\t\t\t0x15F7\n #define IGC_DEV_ID_I225_BLANK_NVM\t\t0x15FD\n #define IGC_DEV_ID_I226_K 0x3102\ndiff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c\nindex 5f3d535490..bdc6f74976 100644\n--- a/drivers/net/igc/base/igc_i225.c\n+++ b/drivers/net/igc/base/igc_i225.c\n@@ -173,19 +173,8 @@ static s32 igc_init_phy_params_i225(struct igc_hw *hw)\n \tphy->ops.write_reg = igc_write_phy_reg_gpy;\n \n \tret_val = igc_get_phy_id(hw);\n-\t/* Verify phy id and set remaining function pointers */\n-\tswitch (phy->id) {\n-\tcase I225_I_PHY_ID:\n-\tcase I226_LM_PHY_ID:\n-\t\tphy->type\t\t= igc_phy_i225;\n-\t\tphy->ops.set_d0_lplu_state = igc_set_d0_lplu_state_i225;\n-\t\tphy->ops.set_d3_lplu_state = igc_set_d3_lplu_state_i225;\n-\t\t/* TODO - complete with GPY PHY information */\n-\t\tbreak;\n-\tdefault:\n-\t\tret_val = -IGC_ERR_PHY;\n-\t\tgoto out;\n-\t}\n+\n+\tphy->type\t\t= igc_phy_i225;\n \n out:\n \treturn ret_val;\ndiff --git a/drivers/net/igc/base/igc_phy.c b/drivers/net/igc/base/igc_phy.c\nindex 43bbe69bca..2906bae21a 100644\n--- a/drivers/net/igc/base/igc_phy.c\n+++ b/drivers/net/igc/base/igc_phy.c\n@@ -1474,8 +1474,7 @@ s32 igc_phy_setup_autoneg(struct igc_hw *hw)\n \t\t\treturn ret_val;\n \t}\n \n-\tif ((phy->autoneg_mask & ADVERTISE_2500_FULL) &&\n-\t hw->phy.id == I225_I_PHY_ID) {\n+\tif (phy->autoneg_mask & ADVERTISE_2500_FULL) {\n \t/* Read the MULTI GBT AN Control Register - reg 7.32 */\n \t\tret_val = phy->ops.read_reg(hw, (STANDARD_AN_REG_MASK <<\n \t\t\t\t\t MMD_DEVADDR_SHIFT) |\n@@ -1615,8 +1614,7 @@ s32 igc_phy_setup_autoneg(struct igc_hw *hw)\n \t\tret_val = phy->ops.write_reg(hw, PHY_1000T_CTRL,\n \t\t\t\t\t mii_1000t_ctrl_reg);\n \n-\tif ((phy->autoneg_mask & ADVERTISE_2500_FULL) &&\n-\t hw->phy.id == I225_I_PHY_ID)\n+\tif (phy->autoneg_mask & ADVERTISE_2500_FULL)\n \t\tret_val = phy->ops.write_reg(hw,\n \t\t\t\t\t (STANDARD_AN_REG_MASK <<\n \t\t\t\t\t MMD_DEVADDR_SHIFT) |\ndiff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c\nindex 7f221a5d34..2989b8d488 100644\n--- a/drivers/net/igc/igc_ethdev.c\n+++ b/drivers/net/igc/igc_ethdev.c\n@@ -97,6 +97,7 @@ static const struct rte_pci_id pci_id_igc_map[] = {\n \t{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I225_V) },\n \t{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I225_I) },\n \t{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I225_K) },\n+\t{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I225_IT) },\n \t{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_K) },\n \t{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_LMVP) },\n \t{ RTE_PCI_DEVICE(IGC_INTEL_VENDOR_ID, IGC_DEV_ID_I226_LM) },\n", "prefixes": [] }
