Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/11559/?format=api
{ "id": 11559, "url": "https://patches.dpdk.org/api/patches/11559/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1458229138-20597-2-git-send-email-adrien.mazarguil@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1458229138-20597-2-git-send-email-adrien.mazarguil@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1458229138-20597-2-git-send-email-adrien.mazarguil@6wind.com", "date": "2016-03-17T15:38:54", "name": "[dpdk-dev,v3,1/5] mlx5: add callbacks to support link (up / down) changes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a67da86729678e267e2f89c61011535c2bb0990a", "submitter": { "id": 165, "url": "https://patches.dpdk.org/api/people/165/?format=api", "name": "Adrien Mazarguil", "email": "adrien.mazarguil@6wind.com" }, "delegate": { "id": 10, "url": "https://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1458229138-20597-2-git-send-email-adrien.mazarguil@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/11559/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/11559/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 14D7E56A2;\n\tThu, 17 Mar 2016 16:39:23 +0100 (CET)", "from mail-wm0-f54.google.com (mail-wm0-f54.google.com\n\t[74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 62F0356A1\n\tfor <dev@dpdk.org>; Thu, 17 Mar 2016 16:39:19 +0100 (CET)", "by mail-wm0-f54.google.com with SMTP id l68so31760649wml.0\n\tfor <dev@dpdk.org>; Thu, 17 Mar 2016 08:39:19 -0700 (PDT)", "from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tr62sm8674354wmd.15.2016.03.17.08.39.17\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tThu, 17 Mar 2016 08:39:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=wlRGPq0ZcGTE0zteq/ehELfpqlsB/Hvtp6rjihBS81k=;\n\tb=cXGF68+Pb29z3GSGJpk+hZBFHlOsXiAhRxEWAgH0EhfSqsQmBaEATlk7OvnIPoaKSo\n\tAU45/Gn4ycbXgzTWGzY3O3w56t+OaIxBDnMG8TZbsbREhrFCDHAu0zXDdQls4W7xwNOh\n\tJ1wSERW+OaBIgpWxkWPpZzH1Dr08mc8ToxO8nIGFtOmn3Vo3u4uBt8rXUTj1Dxk2hisP\n\t6hkRUf4xz20h4Sc8gh3rFJCgma3fFg5cPQg+S+ScPYFlhaKcC6EaDlHq+EnniVr+hGhd\n\t0ppsXhpkBwwyx1yERE1dfmsTXGm76vFPvtecYSc8SxxTT+fzwTJT9C44F8gXkCNYPebM\n\t4ytg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=wlRGPq0ZcGTE0zteq/ehELfpqlsB/Hvtp6rjihBS81k=;\n\tb=dsZKF9/OZBt6tboengykieU3WVJTeSL0DgDgCXvQfEqkJdk5j3RH/ggXnk8IuIztd0\n\tlbFoBHPYomsfo5mQvvIb7lFPj6543sfRnpSYJkcC1nRwWl0IL8jVx1MEV/kAqklEMe51\n\tF3oh3WBxPiGO+2DvkOspMeW9iNUF21wmp6+jX/rzp2cG1rNjSVK6k6Q3SN40UmFSBb8S\n\tn/QwOG6e5gtCm4JBaWd2rlrhLeGRryMKNtNpl+ZlwMZvQQNjHA9dXQfuwHEJgkTlh/51\n\tuqWD7RrnWoSXn4BGPipxvIZ1lBpEsPqXsgrcDZCpnMLkDpRBXMDCM4/5Y3CJyr8+T8T2\n\t5QvQ==", "X-Gm-Message-State": "AD7BkJJ0wOJ/GSKTUTVMfSHWiWILrsT3x/75lnC0jBONocCr2t15bDRjgq57KbCWY33/Ptrj", "X-Received": "by 10.28.0.148 with SMTP id 142mr11083367wma.72.1458229159289;\n\tThu, 17 Mar 2016 08:39:19 -0700 (PDT)", "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "To": "dev@dpdk.org", "Cc": "Or Ami <ora@mellanox.com>", "Date": "Thu, 17 Mar 2016 16:38:54 +0100", "Message-Id": "<1458229138-20597-2-git-send-email-adrien.mazarguil@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1458229138-20597-1-git-send-email-adrien.mazarguil@6wind.com>", "References": "<1457015279-3089-1-git-send-email-adrien.mazarguil@6wind.com>\n\t<1458229138-20597-1-git-send-email-adrien.mazarguil@6wind.com>", "Subject": "[dpdk-dev] [PATCH v3 1/5] mlx5: add callbacks to support link (up /\n\tdown) changes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Or Ami <ora@mellanox.com>\n\nBurst functions are updated to make sure applications cannot attempt to\nsend/receive after link is brought down.\n\nSigned-off-by: Or Ami <ora@mellanox.com>\n---\n doc/guides/rel_notes/release_16_04.rst | 4 ++\n drivers/net/mlx5/mlx5.c | 2 +\n drivers/net/mlx5/mlx5.h | 2 +\n drivers/net/mlx5/mlx5_ethdev.c | 85 ++++++++++++++++++++++++++++++++++\n 4 files changed, 93 insertions(+)", "diff": "diff --git a/doc/guides/rel_notes/release_16_04.rst b/doc/guides/rel_notes/release_16_04.rst\nindex 5f9eb3e..a011f0b 100644\n--- a/doc/guides/rel_notes/release_16_04.rst\n+++ b/doc/guides/rel_notes/release_16_04.rst\n@@ -130,6 +130,10 @@ This section should contain new features added in this release. Sample format:\n \n Only available with Mellanox OFED >= 3.2.\n \n+* **Added mlx5 link up/down callbacks.**\n+\n+ Implemented callbacks to bring link up and down.\n+\n * **Added af_packet dynamic removal function.**\n \n Af_packet device can now be detached using API, like other PMD devices.\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex ad69ec2..14ac4ba 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -148,6 +148,8 @@ static const struct eth_dev_ops mlx5_dev_ops = {\n \t.dev_configure = mlx5_dev_configure,\n \t.dev_start = mlx5_dev_start,\n \t.dev_stop = mlx5_dev_stop,\n+\t.dev_set_link_down = mlx5_set_link_down,\n+\t.dev_set_link_up = mlx5_set_link_up,\n \t.dev_close = mlx5_dev_close,\n \t.promiscuous_enable = mlx5_promiscuous_enable,\n \t.promiscuous_disable = mlx5_promiscuous_disable,\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 43b24fb..9a3f240 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -168,6 +168,8 @@ void mlx5_dev_link_status_handler(void *);\n void mlx5_dev_interrupt_handler(struct rte_intr_handle *, void *);\n void priv_dev_interrupt_handler_uninstall(struct priv *, struct rte_eth_dev *);\n void priv_dev_interrupt_handler_install(struct priv *, struct rte_eth_dev *);\n+int mlx5_set_link_down(struct rte_eth_dev *dev);\n+int mlx5_set_link_up(struct rte_eth_dev *dev);\n \n /* mlx5_mac.c */\n \ndiff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex 6704382..f609e0f 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -968,3 +968,88 @@ priv_dev_interrupt_handler_install(struct priv *priv, struct rte_eth_dev *dev)\n \t\t\t\t\t dev);\n \t}\n }\n+\n+/**\n+ * Change the link state (UP / DOWN).\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device structure.\n+ * @param up\n+ * Nonzero for link up, otherwise link down.\n+ *\n+ * @return\n+ * 0 on success, errno value on failure.\n+ */\n+static int\n+priv_set_link(struct priv *priv, int up)\n+{\n+\tstruct rte_eth_dev *dev = priv->dev;\n+\tint err;\n+\tunsigned int i;\n+\n+\tif (up) {\n+\t\terr = priv_set_flags(priv, ~IFF_UP, IFF_UP);\n+\t\tif (err)\n+\t\t\treturn err;\n+\t\tfor (i = 0; i < priv->rxqs_n; i++)\n+\t\t\tif ((*priv->rxqs)[i]->sp)\n+\t\t\t\tbreak;\n+\t\t/* Check if an sp queue exists.\n+\t\t * Note: Some old frames might be received.\n+\t\t */\n+\t\tif (i == priv->rxqs_n)\n+\t\t\tdev->rx_pkt_burst = mlx5_rx_burst;\n+\t\telse\n+\t\t\tdev->rx_pkt_burst = mlx5_rx_burst_sp;\n+\t\tdev->tx_pkt_burst = mlx5_tx_burst;\n+\t} else {\n+\t\terr = priv_set_flags(priv, ~IFF_UP, ~IFF_UP);\n+\t\tif (err)\n+\t\t\treturn err;\n+\t\tdev->rx_pkt_burst = removed_rx_burst;\n+\t\tdev->tx_pkt_burst = removed_tx_burst;\n+\t}\n+\treturn 0;\n+}\n+\n+/**\n+ * DPDK callback to bring the link DOWN.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device structure.\n+ *\n+ * @return\n+ * 0 on success, errno value on failure.\n+ */\n+int\n+mlx5_set_link_down(struct rte_eth_dev *dev)\n+{\n+\tstruct priv *priv = dev->data->dev_private;\n+\tint err;\n+\n+\tpriv_lock(priv);\n+\terr = priv_set_link(priv, 0);\n+\tpriv_unlock(priv);\n+\treturn err;\n+}\n+\n+/**\n+ * DPDK callback to bring the link UP.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device structure.\n+ *\n+ * @return\n+ * 0 on success, errno value on failure.\n+ */\n+int\n+mlx5_set_link_up(struct rte_eth_dev *dev)\n+{\n+\tstruct priv *priv = dev->data->dev_private;\n+\tint err;\n+\n+\tpriv_lock(priv);\n+\terr = priv_set_link(priv, 1);\n+\tpriv_unlock(priv);\n+\treturn err;\n+}\n", "prefixes": [ "dpdk-dev", "v3", "1/5" ] }