Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115348/?format=api
https://patches.dpdk.org/api/patches/115348/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1661229305-240952-9-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1661229305-240952-9-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1661229305-240952-9-git-send-email-andy.pei@intel.com", "date": "2022-08-23T04:35:05", "name": "[8/8] vhost: vDPA BLK devices configure device when all queue callfds are set", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "29311be6885e7a85c4da8c34fa9ff707177045c2", "submitter": { "id": 1185, "url": "https://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1661229305-240952-9-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 24387, "url": "https://patches.dpdk.org/api/series/24387/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24387", "date": "2022-08-23T04:34:57", "name": "add multi queue support to vDPA ifc driver", "version": 1, "mbox": "https://patches.dpdk.org/series/24387/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/115348/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/115348/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4E9CEA0093;\n\tTue, 23 Aug 2022 07:25:29 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CE31942B70;\n\tTue, 23 Aug 2022 07:25:04 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 724BA42B6F\n for <dev@dpdk.org>; Tue, 23 Aug 2022 07:25:03 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Aug 2022 22:25:03 -0700", "from dpdk-dipei.sh.intel.com ([10.67.110.251])\n by fmsmga008.fm.intel.com with ESMTP; 22 Aug 2022 22:25:01 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1661232303; x=1692768303;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=58gDnf8ey0Q8kguTYs8CrVnN3GCNq7cMGJ9BV4Hrs1w=;\n b=nTHoRhfYGV/TyRnH0csKjN+sSxI/R/M4pu5bwVKYBjM0sQbcGe//TQDx\n cMMoYSCf7ioY4m8Sg92nHhQpcW+c2SxDIlfjiirZi4FkdSA1bjEHCC0wb\n tN/ho+1DzoprJA1o58gsuw+1I/mmRxGKLAkzI1iTkEaWxHH5oVb32eDWY\n oiBSxMlZ60t/HyPvUjACw0yR3r+yArLuoUB2O/WAiv9LQ8p9EatnUapjF\n UQ/QJnxRHy0vyMnIyXO24GwSs1+C41F8wPF1QoohQTawXrXGcjYcUpqi+\n EFI6cSuwAmLb4GIQqVtEBPD9t0fxqDmmk+F12WcgbUxnAyx0LucxMSCH0 Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10447\"; a=\"355325335\"", "E=Sophos;i=\"5.93,256,1654585200\"; d=\"scan'208\";a=\"355325335\"", "E=Sophos;i=\"5.93,256,1654585200\"; d=\"scan'208\";a=\"669864808\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, rosen.xu@intel.com, wei.huang@intel.com,\n gang.cao@intel.com, maxime.coquelin@redhat.com", "Subject": "[PATCH 8/8] vhost: vDPA BLK devices configure device when all queue\n callfds are set", "Date": "Tue, 23 Aug 2022 12:35:05 +0800", "Message-Id": "<1661229305-240952-9-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1661229305-240952-1-git-send-email-andy.pei@intel.com>", "References": "<1661229305-240952-1-git-send-email-andy.pei@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In the virtio blk vDPA live migration use case, before the live\nmigration process, QEMU will set call fd to vDPA back-end. QEMU\nand vDPA back-end stand by until live migration starts.\nDuring live migration process, QEMU sets kick fd and a new call\nfd. However, after the kick fd is set to the vDPA back-end, the\nvDPA back-end configures device and data path starts. The new\ncall fd will cause some kind of \"re-configuration\", this kind\nof \"re-configuration\" cause IO drop.\nAfter this patch, vDPA back-end configures device after kick fd\nand call fd are well set and make sure no IO drops.\nThis patch only impact virtio blk vDPA device and does not impact\nnet device.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n lib/vhost/vhost_user.c | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex b65fba3..568030a 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -2994,6 +2994,7 @@ static int is_vring_iotlb(struct virtio_net *dev,\n \tuint32_t vdpa_type = 0;\n \tuint32_t request;\n \tuint32_t i;\n+\tuint16_t blk_call_fd;\n \n \tdev = get_device(vid);\n \tif (dev == NULL)\n@@ -3227,9 +3228,15 @@ static int is_vring_iotlb(struct virtio_net *dev,\n \tif (!vdpa_dev)\n \t\tgoto out;\n \n-\tif (vdpa_type == RTE_VHOST_VDPA_DEVICE_TYPE_BLK\n-\t\t&& request != VHOST_USER_SET_VRING_CALL)\n-\t\tgoto out;\n+\tif (vdpa_type == RTE_VHOST_VDPA_DEVICE_TYPE_BLK) {\n+\t\tif (request == VHOST_USER_SET_VRING_CALL) {\n+\t\t\tblk_call_fd = ctx.msg.payload.u64 & VHOST_USER_VRING_IDX_MASK;\n+\t\t\tif (blk_call_fd != dev->nr_vring - 1)\n+\t\t\t\tgoto out;\n+\t\t} else {\n+\t\t\tgoto out;\n+\t\t}\n+\t}\n \n \tif (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) {\n \t\tif (vdpa_dev->ops->dev_conf(dev->vid))\n", "prefixes": [ "8/8" ] }{ "id": 115348, "url": "