Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115313/?format=api
{ "id": 115313, "url": "https://patches.dpdk.org/api/patches/115313/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220821231950.5957-1-shinae@alkira.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220821231950.5957-1-shinae@alkira.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20220821231950.5957-1-shinae@alkira.net", "date": "2022-08-21T23:19:50", "name": "linux/igb_uio: make module parameters visible in sysfs", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "97a819d85fb8c21cc13c479f3ac246a018a0f920", "submitter": { "id": 2808, "url": "https://patches.dpdk.org/api/people/2808/?format=api", "name": "Shinae Woo", "email": "shinae@alkira.net" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220821231950.5957-1-shinae@alkira.net/mbox/", "series": [ { "id": 24371, "url": "https://patches.dpdk.org/api/series/24371/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24371", "date": "2022-08-21T23:19:50", "name": "linux/igb_uio: make module parameters visible in sysfs", "version": 1, "mbox": "https://patches.dpdk.org/series/24371/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/115313/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/115313/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 70E9DA00C2;\n\tMon, 22 Aug 2022 01:20:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 426AC41132;\n\tMon, 22 Aug 2022 01:20:05 +0200 (CEST)", "from mail-pj1-f48.google.com (mail-pj1-f48.google.com\n [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id E95B0410FA\n for <dev@dpdk.org>; Mon, 22 Aug 2022 01:20:03 +0200 (CEST)", "by mail-pj1-f48.google.com with SMTP id\n s31-20020a17090a2f2200b001faaf9d92easo12288167pjd.3\n for <dev@dpdk.org>; Sun, 21 Aug 2022 16:20:03 -0700 (PDT)", "from ip-10-30-0-101.us-west-2.compute.internal\n (ec2-35-160-186-240.us-west-2.compute.amazonaws.com. [35.160.186.240])\n by smtp.gmail.com with ESMTPSA id\n h6-20020a170902680600b0016c57657977sm6985690plk.41.2022.08.21.16.20.02\n for <dev@dpdk.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 21 Aug 2022 16:20:02 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=alkira-net.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:message-id:date:subject:to\n :from:from:to:cc;\n bh=62V9H5/vwngnmuyDkLvkrDSaRGkTc++Cw/6w2qt596A=;\n b=O9QW60y1jPOR7AMisxuCLlW86tAzBTzd+1HjT0xu9cUPJ9DebOGEwkYgZvdIDVOfCo\n dBRe/NcWHA1AeRwURWJRJ/qc/JCSLn6/3kK4hWYUp7PKNir8wEHVBstSeO8hy0xD67rh\n QMX4XjFTIePBNsDfwAz2J8OtDvdBmVHs73S3NXe2tRuVgDiI+ykDcwkbcj6Vyif91xmn\n Bw/6vM0GrwuMpM0NEgb0JNrPN+0YGviMyyD+G+34XOHJln6TQxGYjR4pXKPYUuEwrlgN\n CEaUssKJMg3bDoCm9pZpY1K0l0VdVMz5/jCELZKvC1Mlo6oUexUl5pN9anZxCD0lhUKX\n zGIA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:message-id:date:subject:to\n :from:x-gm-message-state:from:to:cc;\n bh=62V9H5/vwngnmuyDkLvkrDSaRGkTc++Cw/6w2qt596A=;\n b=yPsEIW5OzTHeckLA+o92m1dwXD1NoVaUOsxvMKJNhm69cN/YEPy2SJJ6kGBxqeQa8X\n biAPsVB9tBSC5SHKPBX44BflRUFiVVBJOmkPvlGbYgNmp06gdYvehl9welLk4PVRGhfC\n NXmlr+D9iHsgS77c8LVayRT7HpLTmAy5ba74ef7OKJzTJltuNK4azAmEN16cXOeBuM4Y\n +I6bX98dPoD53QkjUlbOaEym0xkXWHSBkbmbafH3uUiZlQdLLd6X80CNYy8SCdyvvNFi\n 7vf8rdZ8/aR2TcOhKt3Jf/wS1/H4+QorKr6m3m01m1oW9mD52ZmeDhQjlgXMeTwglaVM\n Qc7g==", "X-Gm-Message-State": "ACgBeo2FQXgsaXIRWrTLkhV+woNRnUAG/QSK2392J4DbgRlm6QTTegzS\n DigB1r1IQsSZeHuOpD2OCGIDwqdLqUETuA==", "X-Google-Smtp-Source": "\n AA6agR5yDn6h1JvWPc978p+2ict5s60BVxQuv4T0Awfyx590O5bISZzTxxRBPkq36F3AG2tBFspwTQ==", "X-Received": "by 2002:a17:902:f609:b0:168:dcbe:7c4d with SMTP id\n n9-20020a170902f60900b00168dcbe7c4dmr17223067plg.169.1661124002669;\n Sun, 21 Aug 2022 16:20:02 -0700 (PDT)", "From": "Shinae Woo <shinae@alkira.net>", "To": "dev@dpdk.org", "Subject": "[PATCH] linux/igb_uio: make module parameters visible in sysfs", "Date": "Sun, 21 Aug 2022 16:19:50 -0700", "Message-Id": "<20220821231950.5957-1-shinae@alkira.net>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- explicitly set default value for intr_mode\n- give read permission on wc_activate\n- applying patch gives below visibility\n\n```\n$ more /sys/module/igb_uio/parameters/* | cat\n::::::::::::::\n/sys/module/igb_uio/parameters/intr_mode\n::::::::::::::\nmsix\n::::::::::::::\n/sys/module/igb_uio/parameters/wc_activate\n::::::::::::::\n0\n```\n\nSigned-off-by: Shinae Woo <shinae@alkira.net>\n---\n linux/igb_uio/igb_uio.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c\nindex 33e0e02..c927ae6 100644\n--- a/linux/igb_uio/igb_uio.c\n+++ b/linux/igb_uio/igb_uio.c\n@@ -44,7 +44,7 @@ struct rte_uio_pci_dev {\n };\n \n static int wc_activate;\n-static char *intr_mode;\n+static char *intr_mode = RTE_INTR_MODE_MSIX_NAME;\n static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX;\n /* sriov sysfs */\n static ssize_t\n@@ -663,7 +663,7 @@ MODULE_PARM_DESC(intr_mode,\n \" \" RTE_INTR_MODE_LEGACY_NAME \" Use Legacy interrupt\\n\"\n \"\\n\");\n \n-module_param(wc_activate, int, 0);\n+module_param(wc_activate, int, S_IRUGO);\n MODULE_PARM_DESC(wc_activate,\n \"Activate support for write combining (WC) (default=0)\\n\"\n \" 0 - disable\\n\"\n", "prefixes": [] }