Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115279/?format=api
{ "id": 115279, "url": "https://patches.dpdk.org/api/patches/115279/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220820023157.189047-22-hernan.vargas@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220820023157.189047-22-hernan.vargas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220820023157.189047-22-hernan.vargas@intel.com", "date": "2022-08-20T02:31:41", "name": "[v2,21/37] baseband/acc100: check for unlikely operation vals", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4f9c4ea35ac654fd6c86d72a3ae537ea02b9bd48", "submitter": { "id": 2659, "url": "https://patches.dpdk.org/api/people/2659/?format=api", "name": "Hernan Vargas", "email": "hernan.vargas@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220820023157.189047-22-hernan.vargas@intel.com/mbox/", "series": [ { "id": 24365, "url": "https://patches.dpdk.org/api/series/24365/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24365", "date": "2022-08-20T02:31:20", "name": "baseband/acc100: changes for 22.11", "version": 2, "mbox": "https://patches.dpdk.org/series/24365/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/115279/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/115279/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F0CA8A034C;\n\tFri, 19 Aug 2022 20:38:30 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B0D6742B80;\n\tFri, 19 Aug 2022 20:36:34 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 044D942B70\n for <dev@dpdk.org>; Fri, 19 Aug 2022 20:36:21 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Aug 2022 11:36:21 -0700", "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by orsmga002.jf.intel.com with ESMTP; 19 Aug 2022 11:36:21 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1660934182; x=1692470182;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Cud/rgIEDZq1mlJOs7mDIYaJwysXJyoZGF0nP12h8zQ=;\n b=khEUT2QDPDD0rZuJF+MYNbhu1WMotcUeRAVPCnfki1tMAAQzE0RMkvoA\n mRmnODrQM99q/Z8tmcPSixJj3yEOu/gIwExSR6KJMT2pFfgFE2w2kdkqi\n XJhhHqvF/woM7g2++3QbIKG/ojFgeYYXDCdiITLOyVn2GTl/f1gc1TVaT\n M+Wy/dJAPbksFeriA+uU9T1cfuuYxJGsoCQ6t81WfklpaLjaBtXyWI3Wk\n 02AB85TkRdq8RZv6ZQsh+dFx8aIWU3vWXnpOO/MyjaOp6CyCT90hAHkTq\n 2DZ+1QHpRddCkN1mcKQFH2y21u99ZbQiteCP7WbrQA0iY759prrvVm1jt w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10444\"; a=\"319107284\"", "E=Sophos;i=\"5.93,248,1654585200\"; d=\"scan'208\";a=\"319107284\"", "E=Sophos;i=\"5.93,248,1654585200\"; d=\"scan'208\";a=\"608296316\"" ], "X-ExtLoop1": "1", "From": "Hernan Vargas <hernan.vargas@intel.com>", "To": "dev@dpdk.org,\n\tgakhil@marvell.com,\n\ttrix@redhat.com", "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>", "Subject": "[PATCH v2 21/37] baseband/acc100: check for unlikely operation vals", "Date": "Fri, 19 Aug 2022 19:31:41 -0700", "Message-Id": "<20220820023157.189047-22-hernan.vargas@intel.com>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20220820023157.189047-1-hernan.vargas@intel.com>", "References": "<20220820023157.189047-1-hernan.vargas@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add unlikely checks for NULL operation values.\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\n---\n drivers/baseband/acc100/rte_acc100_pmd.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c\nindex 70a29f92a1..ea850e2d7f 100644\n--- a/drivers/baseband/acc100/rte_acc100_pmd.c\n+++ b/drivers/baseband/acc100/rte_acc100_pmd.c\n@@ -3148,6 +3148,10 @@ enqueue_enc_one_op_tb(struct acc100_queue *q, struct rte_bbdev_enc_op *op,\n \tr = op->turbo_enc.tb_params.r;\n \n \twhile (mbuf_total_left > 0 && r < c) {\n+\t\tif (unlikely(input == 0)) {\n+\t\t\trte_bbdev_log(ERR, \"Not enough input segment\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t\tseg_total_left = rte_pktmbuf_data_len(input) - in_offset;\n \t\t/* Set up DMA descriptor */\n \t\tdesc = q->ring_addr + ((q->sw_ring_head + total_enqueued_cbs)\n@@ -4491,6 +4495,8 @@ acc100_enqueue_ldpc_dec_tb(struct rte_bbdev_queue_data *q_data,\n \t\t}\n \t\tenqueued_cbs += ret;\n \t}\n+\tif (unlikely(enqueued_cbs == 0))\n+\t\treturn 0; /* Nothing to enqueue */\n \n \tacc100_dma_enqueue(q, enqueued_cbs, &q_data->queue_stats);\n \n@@ -5051,6 +5057,8 @@ acc100_dequeue_dec(struct rte_bbdev_queue_data *q_data,\n \tfor (i = 0; i < dequeue_num; ++i) {\n \t\top = (q->ring_addr + ((q->sw_ring_tail + dequeued_cbs)\n \t\t\t& q->sw_ring_wrap_mask))->req.op_addr;\n+\t\tif (unlikely(op == NULL))\n+\t\t\tbreak;\n \t\tif (op->turbo_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)\n \t\t\tret = dequeue_dec_one_op_tb(q, &ops[i], dequeued_cbs,\n \t\t\t\t\t&aq_dequeued);\n@@ -5096,6 +5104,8 @@ acc100_dequeue_ldpc_dec(struct rte_bbdev_queue_data *q_data,\n \tfor (i = 0; i < dequeue_num; ++i) {\n \t\top = (q->ring_addr + ((q->sw_ring_tail + dequeued_cbs)\n \t\t\t& q->sw_ring_wrap_mask))->req.op_addr;\n+\t\tif (unlikely(op == NULL))\n+\t\t\tbreak;\n \t\tif (op->ldpc_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)\n \t\t\tret = dequeue_dec_one_op_tb(q, &ops[i], dequeued_cbs,\n \t\t\t\t\t&aq_dequeued);\n", "prefixes": [ "v2", "21/37" ] }