Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115167/?format=api
{ "id": 115167, "url": "https://patches.dpdk.org/api/patches/115167/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20220816090408.3421482-1-weix.ling@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20220816090408.3421482-1-weix.ling@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20220816090408.3421482-1-weix.ling@intel.com", "date": "2022-08-16T09:04:08", "name": "[V5,2/2] tests/vhost_virtio_user_interrupt_cbdma: modify testsuite to test virtio dequeue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ea0844a0d1a6f1b39a39c129e7e9481671e505b4", "submitter": { "id": 1828, "url": "https://patches.dpdk.org/api/people/1828/?format=api", "name": "Ling, WeiX", "email": "weix.ling@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20220816090408.3421482-1-weix.ling@intel.com/mbox/", "series": [ { "id": 24322, "url": "https://patches.dpdk.org/api/series/24322/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=24322", "date": "2022-08-16T09:03:49", "name": "modify vhost_virtio_user_interrupt_cbdma to test virito dequeue", "version": 5, "mbox": "https://patches.dpdk.org/series/24322/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/115167/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/115167/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 50E36A00C3;\n\tTue, 16 Aug 2022 11:08:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4C22C40694;\n\tTue, 16 Aug 2022 11:08:22 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 0D59640150\n for <dts@dpdk.org>; Tue, 16 Aug 2022 11:08:19 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Aug 2022 02:08:19 -0700", "from unknown (HELO localhost.localdomain) ([10.239.252.222])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Aug 2022 02:08:17 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1660640900; x=1692176900;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=AvbgEBy3PRN+7uZrQiBy+G1N/fFxfr+M7I80IUHgsGk=;\n b=IcCW1yl+4B6vYfHaERx6sCilXgAO6YTDJ6/ZM0PGBOR6PDYWUcI+QlfV\n zumFa8TWWv8jXpuGQbmtab0MSwMB6+VjMK7+WhM4W0lj7Gn07rXrpGl2y\n UzzaDvVlALoEiVtjJJkPSDoJuhTRtANl9T2ryNMHwUIdp7XmMlutEYfw5\n eAkmtltwPpjKlaKvk7HrvknqwScUbGBdB2UP5H/W6CULk9uietMdU43w2\n ZXE9orl6MTzDMK0ZMZforD+f18cO4ZN1HdIgjYuMzfoG5jBJ+ggCeXbqV\n cvtWbLgWTzjO846zZyViqOqGjcRLGjQgU5hyubo/k5H2hsMeBqmWoqthh g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10440\"; a=\"378458953\"", "E=Sophos;i=\"5.93,240,1654585200\";\n d=\"scan'208,223\";a=\"378458953\"", "E=Sophos;i=\"5.93,240,1654585200\";\n d=\"scan'208,223\";a=\"635814188\"" ], "From": "Wei Ling <weix.ling@intel.com>", "To": "dts@dpdk.org", "Cc": "Wei Ling <weix.ling@intel.com>", "Subject": "[dts][PATCH V5 2/2] tests/vhost_virtio_user_interrupt_cbdma: modify\n testsuite to test virtio dequeue", "Date": "Tue, 16 Aug 2022 05:04:08 -0400", "Message-Id": "<20220816090408.3421482-1-weix.ling@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "From DPDK-22.07, virtio support async dequeue for split and packed ring\npath, so modify vhost_virtio_user_interrupt_cbdma testsuite to test the \nsplit and packed ring async dequeue feature.\n\nSigned-off-by: Wei Ling <weix.ling@intel.com>\n---\n ...Suite_vhost_virtio_user_interrupt_cbdma.py | 101 ++++++++++--------\n 1 file changed, 54 insertions(+), 47 deletions(-)", "diff": "diff --git a/tests/TestSuite_vhost_virtio_user_interrupt_cbdma.py b/tests/TestSuite_vhost_virtio_user_interrupt_cbdma.py\nindex a89ae5d7..e3dc51a9 100644\n--- a/tests/TestSuite_vhost_virtio_user_interrupt_cbdma.py\n+++ b/tests/TestSuite_vhost_virtio_user_interrupt_cbdma.py\n@@ -31,11 +31,11 @@ class TestVirtioUserInterruptCbdma(TestCase):\n self.core_list = self.dut.get_core_list(\n self.core_config, socket=self.ports_socket\n )\n- self.core_list_vhost = self.core_list[0:2]\n- self.core_list_l3fwd = self.core_list[2:4]\n- self.core_mask_vhost = utils.create_mask(self.core_list_vhost)\n- self.core_mask_l3fwd = utils.create_mask(self.core_list_l3fwd)\n- self.core_mask_virtio = self.core_mask_l3fwd\n+ self.vhost_core_list = self.core_list[0:2]\n+ self.l3fwd_core_list = self.core_list[2:4]\n+ self.core_mask_vhost = utils.create_mask(self.vhost_core_list)\n+ self.l3fwd_core_mask = utils.create_mask(self.l3fwd_core_list)\n+ self.virtio_core_mask = self.l3fwd_core_mask\n self.pci_info = self.dut.ports_info[0][\"pci\"]\n self.cbdma_dev_infos = []\n self.dmas_info = None\n@@ -78,14 +78,14 @@ class TestVirtioUserInterruptCbdma(TestCase):\n return True if out == \"2048\" else False\n \n def launch_l3fwd(self, path, packed=False):\n- self.core_interrupt = self.core_list_l3fwd[0]\n+ self.core_interrupt = self.l3fwd_core_list[0]\n example_para = \"./%s \" % self.app_l3fwd_power_path\n if not packed:\n vdev = \"virtio_user0,path=%s,cq=1\" % path\n else:\n vdev = \"virtio_user0,path=%s,cq=1,packed_vq=1\" % path\n eal_params = self.dut.create_eal_parameters(\n- cores=self.core_list_l3fwd, prefix=\"l3fwd-pwd\", no_pci=True, vdevs=[vdev]\n+ cores=self.l3fwd_core_list, prefix=\"l3fwd-pwd\", no_pci=True, vdevs=[vdev]\n )\n if self.check_2M_env:\n eal_params += \" --single-file-segments\"\n@@ -102,16 +102,13 @@ class TestVirtioUserInterruptCbdma(TestCase):\n else:\n self.logger.info(\"Launch l3fwd-power sample finished\")\n \n- def check_interrupt_log(self, status):\n- out = self.l3fwd.get_session_before()\n- self.logger.info(out)\n+ def check_interrupt_log(self, status, out):\n if status == \"waked up\":\n info = \"lcore %s is waked up from rx interrupt on port 0 queue 0\"\n elif status == \"sleeps\":\n info = \"lcore %s sleeps until interrupt triggers\"\n info = info % self.core_interrupt\n self.verify(info in out, \"The CPU status not right for %s\" % info)\n- self.logger.info(info)\n \n def check_virtio_side_link_status(self, status):\n out = self.virtio_pmd.execute_cmd(\"show port info 0\")\n@@ -171,21 +168,21 @@ class TestVirtioUserInterruptCbdma(TestCase):\n 60,\n )\n \n- def test_lsc_event_between_vhost_user_and_virtio_user_with_split_ring_and_cbdma_enabled(\n+ def test_split_ring_lsc_event_between_vhost_user_and_virtio_user_with_cbdma_enable(\n self,\n ):\n \"\"\"\n- Test Case1: LSC event between vhost-user and virtio-user with split ring and cbdma enabled\n+ Test Case1: Split ring LSC event between vhost-user and virtio-user with cbdma enable\n \"\"\"\n- self.get_cbdma_ports_info_and_bind_to_dpdk(1)\n- lcore_dma = \"[lcore{}@{}]\".format(self.core_list_vhost[1], self.cbdma_list[0])\n- vhost_param = \"--lcore-dma={}\".format(lcore_dma)\n+ self.get_cbdma_ports_info_and_bind_to_dpdk(cbdma_num=1)\n+ lcore_dma = \"lcore%s@%s\" % (self.vhost_core_list[1], self.cbdma_list[0])\n+ vhost_param = \"--lcore-dma=[%s]\" % lcore_dma\n vhost_eal_param = (\n- \"--vdev 'net_vhost0,iface=vhost-net,queues=1,client=0,dmas=[txq0]'\"\n+ \"--vdev 'net_vhost0,iface=vhost-net,queues=1,client=0,dmas=[txq0;rxq0]'\"\n )\n ports = self.cbdma_list\n self.vhost_pmd.start_testpmd(\n- cores=self.core_list_vhost,\n+ cores=self.vhost_core_list,\n ports=ports,\n prefix=\"vhost\",\n eal_param=vhost_eal_param,\n@@ -198,7 +195,7 @@ class TestVirtioUserInterruptCbdma(TestCase):\n \"--vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net\"\n )\n self.virtio_pmd.start_testpmd(\n- cores=self.core_list_l3fwd,\n+ cores=self.l3fwd_core_list,\n no_pci=True,\n prefix=\"virtio\",\n eal_param=virtio_eal_param,\n@@ -210,26 +207,28 @@ class TestVirtioUserInterruptCbdma(TestCase):\n self.vhost_pmd.quit()\n self.check_virtio_side_link_status(\"down\")\n \n- def test_split_ring_virtio_user_interrupt_test_with_vhost_user_as_backend_and_cbdma_enabled(\n+ def test_split_ring_virtio_user_interrupt_test_with_vhost_user_as_backend_and_cbdma_enable(\n self,\n ):\n \"\"\"\n- Test Case2: Split ring virtio-user interrupt test with vhost-user as backend and cbdma enabled\n+ Test Case2: Split ring virtio-user interrupt test with vhost-user as backend and cbdma enable\n \"\"\"\n- self.get_cbdma_ports_info_and_bind_to_dpdk(2)\n- lcore_dma = \"[lcore{}@{},lcore{}@{}]\".format(\n- self.core_list_vhost[1],\n+ self.get_cbdma_ports_info_and_bind_to_dpdk(cbdma_num=2)\n+ lcore_dma = \"lcore%s@%s,lcore%s@%s\" % (\n+ self.vhost_core_list[1],\n self.cbdma_list[0],\n- self.core_list_vhost[1],\n+ self.vhost_core_list[1],\n self.cbdma_list[1],\n )\n- vhost_param = \"--rxq=1 --txq=1 --lcore-dma={}\".format(lcore_dma)\n- vhost_eal_param = \"--vdev 'net_vhost0,iface=vhost-net,queues=1,dmas=[txq0]'\"\n+ vhost_param = \"--rxq=1 --txq=1 --lcore-dma=[%s]\" % lcore_dma\n+ vhost_eal_param = (\n+ \"--vdev 'net_vhost0,iface=vhost-net,queues=1,dmas=[txq0;rxq0]'\"\n+ )\n ports = self.cbdma_list\n ports.append(self.dut.ports_info[0][\"pci\"])\n self.logger.info(ports)\n self.vhost_pmd.start_testpmd(\n- cores=self.core_list_vhost,\n+ cores=self.vhost_core_list,\n ports=ports,\n prefix=\"vhost\",\n eal_param=vhost_eal_param,\n@@ -247,23 +246,26 @@ class TestVirtioUserInterruptCbdma(TestCase):\n )\n self.tester.scapy_execute()\n time.sleep(3)\n- self.check_interrupt_log(status=\"waked up\")\n+ out = self.l3fwd.get_session_before()\n+ self.logger.info(out)\n+ self.check_interrupt_log(status=\"waked up\", out=out)\n+ self.check_interrupt_log(status=\"sleeps\", out=out)\n \n- def test_lsc_event_between_vhost_user_and_virtio_user_with_packed_ring_and_cbdma_enabled(\n+ def test_packed_ring_lsc_event_between_vhost_user_and_virtio_user_with_cbdma_enable(\n self,\n ):\n \"\"\"\n- Test Case3: LSC event between vhost-user and virtio-user with packed ring and cbdma enabled\n+ Test Case3: Packed ring LSC event between vhost-user and virtio-user with cbdma enable\n \"\"\"\n- self.get_cbdma_ports_info_and_bind_to_dpdk(1)\n- lcore_dma = \"[lcore{}@{}]\".format(self.core_list_vhost[1], self.cbdma_list[0])\n- vhost_param = \"--lcore-dma={}\".format(lcore_dma)\n+ self.get_cbdma_ports_info_and_bind_to_dpdk(cbdma_num=1)\n+ lcore_dma = \"lcore%s@%s\" % (self.vhost_core_list[1], self.cbdma_list[0])\n+ vhost_param = \"--lcore-dma=[%s]\" % lcore_dma\n vhost_eal_param = (\n- \"--vdev 'net_vhost0,iface=vhost-net,queues=1,client=0,dmas=[txq0]'\"\n+ \"--vdev 'net_vhost0,iface=vhost-net,queues=1,client=0,dmas=[txq0;rxq0]'\"\n )\n ports = self.cbdma_list\n self.vhost_pmd.start_testpmd(\n- cores=self.core_list_vhost,\n+ cores=self.vhost_core_list,\n ports=ports,\n prefix=\"vhost\",\n eal_param=vhost_eal_param,\n@@ -276,7 +278,7 @@ class TestVirtioUserInterruptCbdma(TestCase):\n \"--vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,packed_vq=1\"\n )\n self.virtio_pmd.start_testpmd(\n- cores=self.core_list_l3fwd,\n+ cores=self.l3fwd_core_list,\n no_pci=True,\n prefix=\"virtio\",\n eal_param=virtio_eal_param,\n@@ -288,25 +290,27 @@ class TestVirtioUserInterruptCbdma(TestCase):\n self.vhost_pmd.quit()\n self.check_virtio_side_link_status(\"down\")\n \n- def test_packed_ring_virtio_user_interrupt_test_with_vhost_user_as_backend_and_cbdma_enabled(\n+ def test_packed_ring_virtio_user_interrupt_test_with_vhost_user_as_backend_and_cbdma_enable(\n self,\n ):\n \"\"\"\n- Test Case4: Packed ring virtio-user interrupt test with vhost-user as backend and cbdma enabled\n+ Test Case4: Packed ring virtio-user interrupt test with vhost-user as backend and cbdma enable\n \"\"\"\n- self.get_cbdma_ports_info_and_bind_to_dpdk(2)\n- lcore_dma = \"[lcore{}@{},lcore{}@{}]\".format(\n- self.core_list_vhost[1],\n+ self.get_cbdma_ports_info_and_bind_to_dpdk(cbdma_num=2)\n+ lcore_dma = \"lcore%s@%s,lcore%s@%s\" % (\n+ self.vhost_core_list[1],\n self.cbdma_list[0],\n- self.core_list_vhost[1],\n+ self.vhost_core_list[1],\n self.cbdma_list[1],\n )\n- vhost_param = \"--rxq=1 --txq=1 --lcore-dma={}\".format(lcore_dma)\n- vhost_eal_param = \"--vdev 'net_vhost0,iface=vhost-net,queues=1,dmas=[txq0]'\"\n+ vhost_param = \"--rxq=1 --txq=1 --lcore-dma=[%s]\" % lcore_dma\n+ vhost_eal_param = (\n+ \"--vdev 'net_vhost0,iface=vhost-net,queues=1,dmas=[txq0;rxq0]'\"\n+ )\n ports = self.cbdma_list\n ports.append(self.dut.ports_info[0][\"pci\"])\n self.vhost_pmd.start_testpmd(\n- cores=self.core_list_vhost,\n+ cores=self.vhost_core_list,\n ports=ports,\n prefix=\"vhost\",\n eal_param=vhost_eal_param,\n@@ -324,7 +328,10 @@ class TestVirtioUserInterruptCbdma(TestCase):\n )\n self.tester.scapy_execute()\n time.sleep(3)\n- self.check_interrupt_log(status=\"waked up\")\n+ out = self.l3fwd.get_session_before()\n+ self.logger.info(out)\n+ self.check_interrupt_log(status=\"waked up\", out=out)\n+ self.check_interrupt_log(status=\"sleeps\", out=out)\n \n def tear_down(self):\n \"\"\"\n", "prefixes": [ "V5", "2/2" ] }