Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 114291,
    "url": "https://patches.dpdk.org/api/patches/114291/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220727223639.598932-13-cristian.dumitrescu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220727223639.598932-13-cristian.dumitrescu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220727223639.598932-13-cristian.dumitrescu@intel.com",
    "date": "2022-07-27T22:36:35",
    "name": "[V3,13/17] examples/pipeline: remove the obsolete mirroring configuration CLI command",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "0c47141361346f6eeee5e79b345876e090e1b78f",
    "submitter": {
        "id": 19,
        "url": "https://patches.dpdk.org/api/people/19/?format=api",
        "name": "Cristian Dumitrescu",
        "email": "cristian.dumitrescu@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220727223639.598932-13-cristian.dumitrescu@intel.com/mbox/",
    "series": [
        {
            "id": 24106,
            "url": "https://patches.dpdk.org/api/series/24106/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24106",
            "date": "2022-07-27T22:36:23",
            "name": "[V3,01/17] pipeline: add pipeline name",
            "version": 3,
            "mbox": "https://patches.dpdk.org/series/24106/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/114291/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/114291/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5BC89A00C4;\n\tThu, 28 Jul 2022 00:37:57 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8146242BA6;\n\tThu, 28 Jul 2022 00:36:59 +0200 (CEST)",
            "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 2F71942B75\n for <dev@dpdk.org>; Thu, 28 Jul 2022 00:36:54 +0200 (CEST)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Jul 2022 15:36:53 -0700",
            "from silpixa00400573.ir.intel.com (HELO\n silpixa00400573.ger.corp.intel.com.) ([10.237.223.157])\n by orsmga008.jf.intel.com with ESMTP; 27 Jul 2022 15:36:52 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1658961414; x=1690497414;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=7DIJdGBhhTi2g2X6BRxSQ0emsktRdh2ueXI7HokequQ=;\n b=VGnZ5bN6sqWIpyJxn+JqV4J5sulWruEmP/l6eqQDsdoL7bf9Dj0xzBSt\n ANykh4t/u6kDh02W0q/1jjzw2B2u49JhWhlC850xSI8owxwBCPjvl2KkG\n Qi3M8nfGAdWo2/sWaOmCtmDpaLIzfEAD09ACfJNYFkawwb8w0eOSJjmEb\n fw8VQguFD2bn306eu9p5ur4sjfRH1+vR8L2Jow7OFAt1LsuLMWRGgCHfZ\n vACJMZmKGcoohpS0Bizk7H9z3ygK9xxxiuACjhVaDbvgqgLKXJhD2EZvx\n 5H8pz1MxG+MfDArRN3E/gq0KdEbpNxA90dxBcRYPZucMmoExOrfl4Yz7F Q==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6400,9594,10421\"; a=\"350068842\"",
            "E=Sophos;i=\"5.93,196,1654585200\"; d=\"scan'208\";a=\"350068842\"",
            "E=Sophos;i=\"5.93,196,1654585200\"; d=\"scan'208\";a=\"628567667\""
        ],
        "X-ExtLoop1": "1",
        "From": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "\"Kamalakannan R .\" <kamalakannan.r@intel.com>",
        "Subject": "[PATCH V3 13/17] examples/pipeline: remove the obsolete mirroring\n configuration CLI command",
        "Date": "Wed, 27 Jul 2022 22:36:35 +0000",
        "Message-Id": "<20220727223639.598932-13-cristian.dumitrescu@intel.com>",
        "X-Mailer": "git-send-email 2.34.1",
        "In-Reply-To": "<20220727223639.598932-1-cristian.dumitrescu@intel.com>",
        "References": "<20220718132603.339314-1-cristian.dumitrescu@intel.com>\n <20220727223639.598932-1-cristian.dumitrescu@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The pipeline mirroring configuration is done through the I/O\nspecification file, so this CLI command is no longer needed.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\nSigned-off-by: Kamalakannan R. <kamalakannan.r@intel.com>\n---\n examples/pipeline/cli.c | 76 -----------------------------------------\n 1 file changed, 76 deletions(-)",
    "diff": "diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c\nindex b26e73c706..fa828c008b 100644\n--- a/examples/pipeline/cli.c\n+++ b/examples/pipeline/cli.c\n@@ -2457,68 +2457,6 @@ cmd_pipeline_stats(char **tokens,\n \t}\n }\n \n-static const char cmd_pipeline_mirror_help[] =\n-\"pipeline <pipeline_name> mirror slots <n_slots> sessions <n_sessions>\\n\";\n-\n-static void\n-cmd_pipeline_mirror(char **tokens,\n-\tuint32_t n_tokens,\n-\tchar *out,\n-\tsize_t out_size,\n-\tvoid *obj)\n-{\n-\tstruct rte_swx_pipeline_mirroring_params params;\n-\tstruct pipeline *p;\n-\tint status;\n-\n-\tif (n_tokens != 7) {\n-\t\tsnprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);\n-\t\treturn;\n-\t}\n-\n-\tif (strcmp(tokens[0], \"pipeline\")) {\n-\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"pipeline\");\n-\t\treturn;\n-\t}\n-\n-\tp = pipeline_find(obj, tokens[1]);\n-\tif (!p) {\n-\t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"pipeline_name\");\n-\t\treturn;\n-\t}\n-\n-\tif (strcmp(tokens[2], \"mirror\")) {\n-\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"mirror\");\n-\t\treturn;\n-\t}\n-\n-\tif (strcmp(tokens[3], \"slots\")) {\n-\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"slots\");\n-\t\treturn;\n-\t}\n-\n-\tif (parser_read_uint32(&params.n_slots, tokens[4])) {\n-\t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"n_slots\");\n-\t\treturn;\n-\t}\n-\n-\tif (strcmp(tokens[5], \"sessions\")) {\n-\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"sessions\");\n-\t\treturn;\n-\t}\n-\n-\tif (parser_read_uint32(&params.n_sessions, tokens[6])) {\n-\t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"n_sessions\");\n-\t\treturn;\n-\t}\n-\n-\tstatus = rte_swx_pipeline_mirroring_config(p->p, &params);\n-\tif (status) {\n-\t\tsnprintf(out, out_size, \"Command failed!\\n\");\n-\t\treturn;\n-\t}\n-}\n-\n static const char cmd_pipeline_mirror_session_help[] =\n \"pipeline <pipeline_name> mirror session <session_id> port <port_id> clone fast | slow \"\n \"truncate <truncation_length>\\n\";\n@@ -2746,7 +2684,6 @@ cmd_help(char **tokens,\n \t\t\t\"\\tpipeline meter set\\n\"\n \t\t\t\"\\tpipeline meter stats\\n\"\n \t\t\t\"\\tpipeline stats\\n\"\n-\t\t\t\"\\tpipeline mirror\\n\"\n \t\t\t\"\\tpipeline mirror session\\n\"\n \t\t\t\"\\tthread pipeline enable\\n\"\n \t\t\t\"\\tthread pipeline disable\\n\\n\");\n@@ -2958,12 +2895,6 @@ cmd_help(char **tokens,\n \t\treturn;\n \t}\n \n-\tif (!strcmp(tokens[0], \"pipeline\") &&\n-\t\t(n_tokens == 2) && !strcmp(tokens[1], \"mirror\")) {\n-\t\tsnprintf(out, out_size, \"\\n%s\\n\", cmd_pipeline_mirror_help);\n-\t\treturn;\n-\t}\n-\n \tif (!strcmp(tokens[0], \"pipeline\") &&\n \t\t(n_tokens == 3) && !strcmp(tokens[1], \"mirror\")\n \t\t&& !strcmp(tokens[2], \"session\")) {\n@@ -3217,13 +3148,6 @@ cli_process(char *in, char *out, size_t out_size, void *obj)\n \t\t\treturn;\n \t\t}\n \n-\t\tif ((n_tokens >= 4) &&\n-\t\t\t(strcmp(tokens[2], \"mirror\") == 0) &&\n-\t\t\t(strcmp(tokens[3], \"slots\") == 0)) {\n-\t\t\tcmd_pipeline_mirror(tokens, n_tokens, out, out_size, obj);\n-\t\t\treturn;\n-\t\t}\n-\n \t\tif ((n_tokens >= 4) &&\n \t\t\t(strcmp(tokens[2], \"mirror\") == 0) &&\n \t\t\t(strcmp(tokens[3], \"session\") == 0)) {\n",
    "prefixes": [
        "V3",
        "13/17"
    ]
}