Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 113990,
    "url": "https://patches.dpdk.org/api/patches/113990/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1658110002-191064-1-git-send-email-andy.pei@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1658110002-191064-1-git-send-email-andy.pei@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1658110002-191064-1-git-send-email-andy.pei@intel.com",
    "date": "2022-07-18T02:06:42",
    "name": "vhost: use another variable to store vhost msg result code",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "a61991fe7fe6489048d1cca5719800369a0caa9d",
    "submitter": {
        "id": 1185,
        "url": "https://patches.dpdk.org/api/people/1185/?format=api",
        "name": "Pei, Andy",
        "email": "andy.pei@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1658110002-191064-1-git-send-email-andy.pei@intel.com/mbox/",
    "series": [
        {
            "id": 24008,
            "url": "https://patches.dpdk.org/api/series/24008/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=24008",
            "date": "2022-07-18T02:06:42",
            "name": "vhost: use another variable to store vhost msg result code",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/24008/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/113990/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/113990/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4BD0BA0547;\n\tMon, 18 Jul 2022 04:54:47 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E694340A87;\n\tMon, 18 Jul 2022 04:54:46 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 8E9C14069F\n for <dev@dpdk.org>; Mon, 18 Jul 2022 04:54:44 +0200 (CEST)",
            "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jul 2022 19:54:43 -0700",
            "from dpdk-dipei.sh.intel.com ([10.67.110.251])\n by orsmga006.jf.intel.com with ESMTP; 17 Jul 2022 19:54:41 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1658112884; x=1689648884;\n h=from:to:cc:subject:date:message-id;\n bh=CqsEE4T9tAZOtjUaaekDbC9cu/yf2R4HOxjdUaRBQ5A=;\n b=Zhto/hvYDazgIh1Hoi19UfUe902nHuBOb03vuJlz3krIgqaJEodzZTwM\n kQ/Una3YdTAoM1HEUYl0IbLdkV4ZBY+scrQx1BSmI8n47iDUNYNZPnS/P\n tTnNGUAfGfAOKxwlo0cmCB3FajI/Fr8+MNeuXVeU34zJwpChepkD6LDOK\n GVkI5LVa5DSx/owWPlO4PWvEgLpOMn20158CH2j+UhXSpOG2jG9VPXtWC\n vAAGeZl5Ps8F/27AKPEHfqyNoaXeXT0plkGlXDJKVdWl3lyNdyKEfYSFg\n IW7UZ3DQcLqKEzypnssRfxB3HkTtcnrCUMHdGPwApPYbzE96BKuNzSFSf g==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6400,9594,10411\"; a=\"372426707\"",
            "E=Sophos;i=\"5.92,280,1650956400\"; d=\"scan'208\";a=\"372426707\"",
            "E=Sophos;i=\"5.92,280,1650956400\"; d=\"scan'208\";a=\"572223951\""
        ],
        "X-ExtLoop1": "1",
        "From": "Andy Pei <andy.pei@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "maxime.coquelin@redhat.com,\n\tChenbo.Xia@intel.com,\n\tWenwuX.Ma@intel.com",
        "Subject": "[PATCH] vhost: use another variable to store vhost msg result code",
        "Date": "Mon, 18 Jul 2022 10:06:42 +0800",
        "Message-Id": "<1658110002-191064-1-git-send-email-andy.pei@intel.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Currently in function vhost_user_msg_handler, variable ret is used to\nstore both vhost msg result code and function call return value.\nAfter this patch, variable ret is used only to store function call\nreturn value, a new variable msg_result is used to store vhost msg\nresult. This can improve readability.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n lib/vhost/vhost_user.c | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)",
    "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 4ad28ba..dac06c9 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -2969,6 +2969,7 @@ static int is_vring_iotlb(struct virtio_net *dev,\n \tstruct vhu_msg_context ctx;\n \tvhost_message_handler_t *msg_handler;\n \tstruct rte_vdpa_device *vdpa_dev;\n+\tint msg_result = RTE_VHOST_MSG_RESULT_OK;\n \tint ret;\n \tint unlock_required = 0;\n \tbool handled;\n@@ -3061,8 +3062,8 @@ static int is_vring_iotlb(struct virtio_net *dev,\n \thandled = false;\n \tif (dev->extern_ops.pre_msg_handle) {\n \t\tRTE_BUILD_BUG_ON(offsetof(struct vhu_msg_context, msg) != 0);\n-\t\tret = (*dev->extern_ops.pre_msg_handle)(dev->vid, &ctx);\n-\t\tswitch (ret) {\n+\t\tmsg_result = (*dev->extern_ops.pre_msg_handle)(dev->vid, &ctx);\n+\t\tswitch (msg_result) {\n \t\tcase RTE_VHOST_MSG_RESULT_REPLY:\n \t\t\tsend_vhost_reply(dev, fd, &ctx);\n \t\t\t/* Fall-through */\n@@ -3080,12 +3081,12 @@ static int is_vring_iotlb(struct virtio_net *dev,\n \t\tgoto skip_to_post_handle;\n \n \tif (!msg_handler->accepts_fd && validate_msg_fds(dev, &ctx, 0) != 0) {\n-\t\tret = RTE_VHOST_MSG_RESULT_ERR;\n+\t\tmsg_result = RTE_VHOST_MSG_RESULT_ERR;\n \t} else {\n-\t\tret = msg_handler->callback(&dev, &ctx, fd);\n+\t\tmsg_result = msg_handler->callback(&dev, &ctx, fd);\n \t}\n \n-\tswitch (ret) {\n+\tswitch (msg_result) {\n \tcase RTE_VHOST_MSG_RESULT_ERR:\n \t\tVHOST_LOG_CONFIG(dev->ifname, ERR,\n \t\t\t\"processing %s failed.\\n\",\n@@ -3110,11 +3111,11 @@ static int is_vring_iotlb(struct virtio_net *dev,\n \t}\n \n skip_to_post_handle:\n-\tif (ret != RTE_VHOST_MSG_RESULT_ERR &&\n+\tif (msg_result != RTE_VHOST_MSG_RESULT_ERR &&\n \t\t\tdev->extern_ops.post_msg_handle) {\n \t\tRTE_BUILD_BUG_ON(offsetof(struct vhu_msg_context, msg) != 0);\n-\t\tret = (*dev->extern_ops.post_msg_handle)(dev->vid, &ctx);\n-\t\tswitch (ret) {\n+\t\tmsg_result = (*dev->extern_ops.post_msg_handle)(dev->vid, &ctx);\n+\t\tswitch (msg_result) {\n \t\tcase RTE_VHOST_MSG_RESULT_REPLY:\n \t\t\tsend_vhost_reply(dev, fd, &ctx);\n \t\t\t/* Fall-through */\n@@ -3133,7 +3134,7 @@ static int is_vring_iotlb(struct virtio_net *dev,\n \t\t\t\"vhost message (req: %d) was not handled.\\n\",\n \t\t\trequest);\n \t\tclose_msg_fds(&ctx);\n-\t\tret = RTE_VHOST_MSG_RESULT_ERR;\n+\t\tmsg_result = RTE_VHOST_MSG_RESULT_ERR;\n \t}\n \n \t/*\n@@ -3142,17 +3143,16 @@ static int is_vring_iotlb(struct virtio_net *dev,\n \t * VHOST_USER_NEED_REPLY was cleared in send_vhost_reply().\n \t */\n \tif (ctx.msg.flags & VHOST_USER_NEED_REPLY) {\n-\t\tctx.msg.payload.u64 = ret == RTE_VHOST_MSG_RESULT_ERR;\n+\t\tctx.msg.payload.u64 = msg_result == RTE_VHOST_MSG_RESULT_ERR;\n \t\tctx.msg.size = sizeof(ctx.msg.payload.u64);\n \t\tctx.fd_num = 0;\n \t\tsend_vhost_reply(dev, fd, &ctx);\n-\t} else if (ret == RTE_VHOST_MSG_RESULT_ERR) {\n+\t} else if (msg_result == RTE_VHOST_MSG_RESULT_ERR) {\n \t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"vhost message handling failed.\\n\");\n \t\tret = -1;\n \t\tgoto unlock;\n \t}\n \n-\tret = 0;\n \tfor (i = 0; i < dev->nr_vring; i++) {\n \t\tstruct vhost_virtqueue *vq = dev->virtqueue[i];\n \t\tbool cur_ready = vq_is_ready(dev, vq);\n",
    "prefixes": []
}