Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113164/?format=api
{ "id": 113164, "url": "https://patches.dpdk.org/api/patches/113164/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1655807588-7320-9-git-send-email-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1655807588-7320-9-git-send-email-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1655807588-7320-9-git-send-email-chaoyong.he@corigine.com", "date": "2022-06-21T10:33:04", "name": "[v2,08/12] net/nfp: move common rxtx function for flower use", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d4030cfb3369e65c2e15d76afe35533e9143e448", "submitter": { "id": 2554, "url": "https://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 3961, "url": "https://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1655807588-7320-9-git-send-email-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 23653, "url": "https://patches.dpdk.org/api/series/23653/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=23653", "date": "2022-06-21T10:32:56", "name": "preparation for the rte_flow offload of nfp PMD", "version": 2, "mbox": "https://patches.dpdk.org/series/23653/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/113164/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/113164/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 96351A00C5;\n\tTue, 21 Jun 2022 12:34:59 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B7BC242B81;\n\tTue, 21 Jun 2022 12:34:14 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2134.outbound.protection.outlook.com [40.107.237.134])\n by mails.dpdk.org (Postfix) with ESMTP id 0467042B81\n for <dev@dpdk.org>; Tue, 21 Jun 2022 12:34:13 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by MN2PR13MB3086.namprd13.prod.outlook.com (2603:10b6:208:135::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Tue, 21 Jun\n 2022 10:34:11 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::5d9e:9ce5:51d1:2021]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::5d9e:9ce5:51d1:2021%7]) with mapi id 15.20.5373.015; Tue, 21 Jun 2022\n 10:34:11 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=AomeQroWW1QBdyC4hjN0N6bPYDrWdYBloLayoqZSh9Jjjc1u1Kzj2jHa3DQDKyxFgh3bfYGXCwG4Qpk8msnUGibz6YbwDlbW1gYvpHFcd2Z+cidN7ezfrEwpC0Nxscm361nTIa0JPzOP47ZOewqmHv6nk0EhqELBlbio6XCrv3UiXkjexEogBhjBcJTu88WTNlalqg8vHsICl7txmTIDII0cDeBea40+UAa1OeKEEKW6FeLdHLWpV5fJACZmwpTonLwuDfp8Cfwhi7hU8DGNszF/eziNFK9saGigwlpygMjT+r+86BJE1VzDqGXJumhSiQqqec93Y68YTp+zi/XL4A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=b8bT9YKGR9pqmupZtfvWnjJTxPMp3Qi+aLlqBvHztxk=;\n b=RhqHwZ8X7vTKSL0Y3tsCrUM+WMK/qSLFpkrfsAX30b0tk9/Ir6lmBfutTjBAxjlYBSEKaqQ4P0HDjgJoo23xr3lQY699pJsPHdiZVnGnFidJd7gh72UCwUuxG8IqGYPz8/T+pBxSDEDQcOMdkbncavP/msro6IO6j1oK/n0igc8xTLMyrxygGhTpUw0AT1WF7QvFkXHdXttJZIqoFE6S7/Z4MKP45QKg+Nghl4FAP3WTAMxPt1J8ZStamr+x61it/GdDWUko4tcAc3Ca4ANJ6bwKXe7un4tsMrIku3EuOLU467BrCLIle6voQsgYVQ79bBWTiVKa+K3bfmdrsgbGSA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=b8bT9YKGR9pqmupZtfvWnjJTxPMp3Qi+aLlqBvHztxk=;\n b=UxykG/NbmG8fv6iga6K7mihW3brFmZxRX2A+4jBp3ekuvX45w0iGVrXe3vX1qx7nWpvCqK3IFMCI2aAZSL1z3QEGlRtEILXJ7bDCkJtpKUYT8mb67hmzEu/RZqtn4WQuNmrXqqRKnbD6P2XKzEmRypMh+HL5HGBpe301y7tYS/k=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "niklas.soderlund@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n Heinrich Kuhn <heinrich.kuhn@corigine.com>", "Subject": "[PATCH v2 08/12] net/nfp: move common rxtx function for flower use", "Date": "Tue, 21 Jun 2022 18:33:04 +0800", "Message-Id": "<1655807588-7320-9-git-send-email-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1655807588-7320-1-git-send-email-chaoyong.he@corigine.com>", "References": "<1655807588-7320-1-git-send-email-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "OS0PR01CA0018.jpnprd01.prod.outlook.com\n (2603:1096:604:24::23) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "82d25f83-629d-4b35-3eba-08da5371947a", "X-MS-TrafficTypeDiagnostic": "MN2PR13MB3086:EE_", "X-Microsoft-Antispam-PRVS": "\n <MN2PR13MB30862B58CF7129604EE5EA869EB39@MN2PR13MB3086.namprd13.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n hjGzEnXhYTVQTJxTgnB9E/n3t42X5zJEaYQl37a56fx3l8l4ePLEtKZ+wKE6/Xuy4XssjIdE/9o8iE0bBru5XXMYPl/HD1C2mdElGCwyGkitFLVbJ6BweRjA58M4h0E1R5/AB4ZK4Jc9qH0rLT8YxoVRvlqbl461oWAiOV7508+67duLdnCS8sfJmbxJXt5lv3qC6rCKOoIFlUMN3NXuNJwf/fwrUdIqVZ/We79uncHhr9Sw3ypAhb0RAyozjk6zfIAa1Fef/mI3Io6A8E83MYVB24H23jaRJYWH53bgDsnY3mwKjwCh0fmBMe8oFI5ADQ0RldFWutx2hAIZC2OhCp0lFd0N7t8Dz1IMEHEqQogFp7ynRqzHbaPfZcfBjZphVutYtTVJ5ZVSS9eWJnxpAH3exTdXsVYJHdv7Sv8JDgU4n6Bwqo2H/b8yCVpEmjFDlyE8NTpTHFzIPVB5IL1fJ5EEn3XpLKdV3L8vweaWwOfRmn/olwm03U0R9tJmXdnrTY88e9BSm3JSnE3spWKiweirrMAj7WUrO9Rmo4NQbneeTaH+Q80lQ54RexIwzKCJ3X0nfyOtM96kpd/VO+3/r1AewRQRaAcC9BQjXu2J9L9dJi/j1+eRidkLpDHHBHzvvOvecfUVzSg6gwVL428rGord6tW8A/yyKJ+WRDYuhbgEf6NTy32WmiylKWOLQoDzdbTWOuaK4fHKEJnbTEpzrIs+HX3TsBv+WyfR8buOsTmEKEIz8IT67TX60sO/CC2O", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230016)(4636009)(376002)(396003)(136003)(366004)(39830400003)(346002)(83380400001)(107886003)(186003)(41300700001)(2616005)(38100700002)(38350700002)(6666004)(66476007)(4326008)(86362001)(5660300002)(8936002)(44832011)(6506007)(2906002)(52116002)(26005)(6512007)(6916009)(54906003)(316002)(8676002)(66556008)(66946007)(6486002)(478600001)(36756003);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?qi7/0qAtxZaoo6zy6bo7XukaFAOE?=\n\t=?utf-8?q?jG/CyYDn0iSdJ9IPgCW/QnjjqT61vEz0Ne3iiggljB654HgTj/sSHOBHdstS+sfdW?=\n\t=?utf-8?q?d68BfThSOKyRaIgvi4Trsm4ijA+TJehH5my46hFYqaRTXBXdwLV+dHaYl9GJBSQXd?=\n\t=?utf-8?q?wywfBUOQByNKQy1aWY7tiNo2TnSudLCH9i/MDYkXKuLo1G5cXTmWWJIFzQa/ixPZ9?=\n\t=?utf-8?q?vZnjzUlaLaAfz908RAefi4sn6yzsTiFYb/UvtLzfqeAeM3Shi+CuZCZ3FIy+lDaQB?=\n\t=?utf-8?q?CzrsJbiXzMuCfdY5irD78xSPl2tA7DL2hHFqzK+0sZ9t0M3NTUrJlsqo3mrBpspnA?=\n\t=?utf-8?q?8PWmczaSeXvD1cRYbDa7lE/VRCQOwJGYfvRKonlAOMFKMGAh0tjHfsO5LL7Xuz3Tf?=\n\t=?utf-8?q?8/lmVKrqvjO3XaaiNx02aFw5aoZHEKc8VZtGKzP1WTt8tfq7CfmWg9nYiQ+FXpSGQ?=\n\t=?utf-8?q?x8V+rRzQOLMmPFvbWW9hR6z8+aXKq53T63IvjOzeRNahP17uxeNxpw/SL+v7iRYbi?=\n\t=?utf-8?q?H8ECXfEj2t8irKkSbNJfHNMBCw+n5FxhV+xb5RN4kilercvsIE5jnw55KgQNKNHhz?=\n\t=?utf-8?q?XBgYZNAHki4XSs1ONKDTG5w2olJSbZIYgJ2O0tWMb9kR1JrzL8KTZ1NipXtRpVHbQ?=\n\t=?utf-8?q?W8WOCcQ83JxXxd2C95wFKIlAEw22WcSD4w59B5rLaR5aIfEvTnGic/nJuWUxWxdKq?=\n\t=?utf-8?q?B6w6UcK3cHmpqZ3WNRTy9vqYvzQFcFPy66HA+POLUSacFK56ko6QZ8augZiLOOEVf?=\n\t=?utf-8?q?h50cMYcw2GhWhM+ecfXvriOTSyoFUsU5IMG6MlNqwU3WABge4GeD9RjOAQbxnZyQY?=\n\t=?utf-8?q?A9O6YAqSbKvPKbjLuj5PMJ9n6H2kyjK/dJCpg2o4n0qNQyG91ZZsdhoH75znE5ylS?=\n\t=?utf-8?q?XYcy9aT+SnHhK77kwkVr+wm45vSZ4MxlDn468xUSIaQkBf0us6Y1+mAYVic7FYZnr?=\n\t=?utf-8?q?gfTZCK4T94DrPeJLUcVPIq+TcOSOifHYaE9oNqAO7yQ8kxgeIn1l2SwBqUAA8CEen?=\n\t=?utf-8?q?weLL7f2xf1L50Pf5w4fvY4Ih6aysa+G1KvA84OaLjsXOHANcOO1v+owzh0g3BzLak?=\n\t=?utf-8?q?Ns017EtQQo9r6jkHJqM4PvQpqNvhhwmHvrLiIVeRexWjqQnB9GIlBcRgGT6J9xRlJ?=\n\t=?utf-8?q?V+qikClkP7OjFEO4bSslkGOuJhZUYkjrwOQbO5DPr42S+/kgSDfcUM5eWvg9OCW0R?=\n\t=?utf-8?q?jgd35auO/619GaQvGGjFNMHtB67qy3FyA6reXsrou15KOQEo7ZfhPAC2QNblKqv7R?=\n\t=?utf-8?q?YIqB1lDKxzuRXLf2rfKhFgGDXsmFpBWvINTdlA/CyAgtQbGordc/aye61mwK9t9dI?=\n\t=?utf-8?q?XYPloi8p1qmU9q1sH/YNMMDIUaiQzMw/bzMnLahQErVnWSqAL+Q6EKsc56q+5c/LX?=\n\t=?utf-8?q?0mz6V6UxYtn4PjsdPEgl5xJUdV6xZeaSUnn9VCC/0sYZf8dU16T/MuKZqIKWMemvR?=\n\t=?utf-8?q?iM0AxCs0fhzBv/SWQDt7PXd8pugr6GYDAdISfdUk8pmu4CE9NuQwxam1Bqd6b1YKD?=\n\t=?utf-8?q?58tOu1zV6YpFIhyX69kHcjIzfxtt6fFKvlyksYyvVB1VtSl3Xdkar4Apd/nhLAlru?=\n\t=?utf-8?q?VziWsRGXdi/5xwNbUJ/c45xhB85EFjlWstOEI2Qn32vbrYEF9PYiy2rxwocuEW8l5?=\n\t=?utf-8?q?9x89aDL0ataGjL2C9pW666XzpZUD+CY1iW5AFNIYV2KPDvvf9hrXA=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 82d25f83-629d-4b35-3eba-08da5371947a", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Jun 2022 10:34:11.7402 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n JeTfUl5yZ7UOh6Ob86ceAVCn6efny40DgGC6wiFJ4zlFRFWdVamrLfFMAhRJ5uuO+Px+nuO4P9bqG/5TC7y7GJ/UDamqsZof69WodgJwGZ8=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR13MB3086", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This commit move some common Rx and Tx logic to the rxtx header file so\nthat they can be re-used by flower tx and rx logic.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nSigned-off-by: Heinrich Kuhn <heinrich.kuhn@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfp_rxtx.c | 32 +-------------------------------\n drivers/net/nfp/nfp_rxtx.h | 31 +++++++++++++++++++++++++++++++\n 2 files changed, 32 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c\nindex 7414c51..cdcf5c2 100644\n--- a/drivers/net/nfp/nfp_rxtx.c\n+++ b/drivers/net/nfp/nfp_rxtx.c\n@@ -116,12 +116,6 @@\n \treturn count;\n }\n \n-static inline void\n-nfp_net_mbuf_alloc_failed(struct nfp_net_rxq *rxq)\n-{\n-\trte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed++;\n-}\n-\n /*\n * nfp_net_set_hash - Set mbuf hash data\n *\n@@ -583,7 +577,7 @@\n * @txq: TX queue to work with\n * Returns number of descriptors freed\n */\n-static int\n+int\n nfp_net_tx_free_bufs(struct nfp_net_txq *txq)\n {\n \tuint32_t qcp_rd_p;\n@@ -774,30 +768,6 @@\n \treturn 0;\n }\n \n-/* Leaving always free descriptors for avoiding wrapping confusion */\n-static inline\n-uint32_t nfp_net_nfd3_free_tx_desc(struct nfp_net_txq *txq)\n-{\n-\tif (txq->wr_p >= txq->rd_p)\n-\t\treturn txq->tx_count - (txq->wr_p - txq->rd_p) - 8;\n-\telse\n-\t\treturn txq->rd_p - txq->wr_p - 8;\n-}\n-\n-/*\n- * nfp_net_txq_full - Check if the TX queue free descriptors\n- * is below tx_free_threshold\n- *\n- * @txq: TX queue to check\n- *\n- * This function uses the host copy* of read/write pointers\n- */\n-static inline\n-uint32_t nfp_net_nfd3_txq_full(struct nfp_net_txq *txq)\n-{\n-\treturn (nfp_net_nfd3_free_tx_desc(txq) < txq->tx_free_thresh);\n-}\n-\n /* nfp_net_tx_tso - Set TX descriptor for TSO */\n static inline void\n nfp_net_nfd3_tx_tso(struct nfp_net_txq *txq, struct nfp_net_nfd3_tx_desc *txd,\ndiff --git a/drivers/net/nfp/nfp_rxtx.h b/drivers/net/nfp/nfp_rxtx.h\nindex 5c005d7..a30171f 100644\n--- a/drivers/net/nfp/nfp_rxtx.h\n+++ b/drivers/net/nfp/nfp_rxtx.h\n@@ -330,6 +330,36 @@ struct nfp_net_rxq {\n \tint rx_qcidx;\n } __rte_aligned(64);\n \n+static inline void\n+nfp_net_mbuf_alloc_failed(struct nfp_net_rxq *rxq)\n+{\n+\trte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed++;\n+}\n+\n+/* Leaving always free descriptors for avoiding wrapping confusion */\n+static inline uint32_t\n+nfp_net_nfd3_free_tx_desc(struct nfp_net_txq *txq)\n+{\n+\tif (txq->wr_p >= txq->rd_p)\n+\t\treturn txq->tx_count - (txq->wr_p - txq->rd_p) - 8;\n+\telse\n+\t\treturn txq->rd_p - txq->wr_p - 8;\n+}\n+\n+/*\n+ * nfp_net_nfd3_txq_full - Check if the TX queue free descriptors\n+ * is below tx_free_threshold\n+ *\n+ * @txq: TX queue to check\n+ *\n+ * This function uses the host copy* of read/write pointers\n+ */\n+static inline uint32_t\n+nfp_net_nfd3_txq_full(struct nfp_net_txq *txq)\n+{\n+\treturn (nfp_net_nfd3_free_tx_desc(txq) < txq->tx_free_thresh);\n+}\n+\n int nfp_net_rx_freelist_setup(struct rte_eth_dev *dev);\n uint32_t nfp_net_rx_queue_count(void *rx_queue);\n uint16_t nfp_net_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n@@ -355,6 +385,7 @@ int nfp_net_nfdk_tx_queue_setup(struct rte_eth_dev *dev,\n uint16_t nfp_net_nfdk_xmit_pkts(void *tx_queue,\n \t\tstruct rte_mbuf **tx_pkts,\n \t\tuint16_t nb_pkts);\n+int nfp_net_tx_free_bufs(struct nfp_net_txq *txq);\n \n #endif /* _NFP_RXTX_H_ */\n /*\n", "prefixes": [ "v2", "08/12" ] }