Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1131/?format=api
{ "id": 1131, "url": "https://patches.dpdk.org/api/patches/1131/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1415152183-119796-2-git-send-email-yongwang@vmware.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1415152183-119796-2-git-send-email-yongwang@vmware.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1415152183-119796-2-git-send-email-yongwang@vmware.com", "date": "2014-11-05T01:49:38", "name": "[dpdk-dev,v2,1/6] vmxnet3: Fix VLAN Rx stripping", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d1cd448a5058b8c77ba07fec6956c79f818507c5", "submitter": { "id": 93, "url": "https://patches.dpdk.org/api/people/93/?format=api", "name": "Yong Wang", "email": "yongwang@vmware.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1415152183-119796-2-git-send-email-yongwang@vmware.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1131/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1131/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 13A2D7F18;\n\tWed, 5 Nov 2014 02:40:43 +0100 (CET)", "from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com\n\t[208.91.2.12]) by dpdk.org (Postfix) with ESMTP id 0B5BB7E97\n\tfor <dev@dpdk.org>; Wed, 5 Nov 2014 02:40:33 +0100 (CET)", "from sc9-mailhost1.vmware.com (sc9-mailhost1.vmware.com\n\t[10.113.161.71])\n\tby smtp-outbound-1.vmware.com (Postfix) with ESMTP id 5A03828942\n\tfor <dev@dpdk.org>; Tue, 4 Nov 2014 17:49:46 -0800 (PST)", "from sc9-mailhost2.vmware.com (unknown [10.32.43.10])\n\tby sc9-mailhost1.vmware.com (Postfix) with ESMTP id 37F39191B1\n\tfor <dev@dpdk.org>; Tue, 4 Nov 2014 17:49:46 -0800 (PST)" ], "From": "Yong Wang <yongwang@vmware.com>", "To": "dev@dpdk.org", "Date": "Tue, 4 Nov 2014 17:49:38 -0800", "Message-Id": "<1415152183-119796-2-git-send-email-yongwang@vmware.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1415152183-119796-1-git-send-email-yongwang@vmware.com>", "References": "<1415152183-119796-1-git-send-email-yongwang@vmware.com>", "Subject": "[dpdk-dev] [PATCH v2 1/6] vmxnet3: Fix VLAN Rx stripping", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped.\n\nSigned-off-by: Yong Wang <yongwang@vmware.com>\n---\n lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c\nindex 263f9ce..986e5e5 100644\n--- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c\n+++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c\n@@ -540,21 +540,19 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \n \t\t\t/* Check for hardware stripped VLAN tag */\n \t\t\tif (rcd->ts) {\n-\n \t\t\t\tPMD_RX_LOG(ERR, \"Received packet with vlan ID: %d.\",\n \t\t\t\t\t rcd->tci);\n \t\t\t\trxm->ol_flags = PKT_RX_VLAN_PKT;\n-\n #ifdef RTE_LIBRTE_VMXNET3_DEBUG_DRIVER\n \t\t\t\tVMXNET3_ASSERT(rxm &&\n \t\t\t\t\t rte_pktmbuf_mtod(rxm, void *));\n #endif\n \t\t\t\t/* Copy vlan tag in packet buffer */\n-\t\t\t\trxm->vlan_tci = rte_le_to_cpu_16(\n-\t\t\t\t\t\t(uint16_t)rcd->tci);\n-\n-\t\t\t} else\n+\t\t\t\trxm->vlan_tci = rte_le_to_cpu_16((uint16_t)rcd->tci);\n+\t\t\t} else {\n \t\t\t\trxm->ol_flags = 0;\n+\t\t\t\trxm->vlan_tci = 0;\n+\t\t\t}\n \n \t\t\t/* Initialize newly received packet buffer */\n \t\t\trxm->port = rxq->port_id;\n@@ -563,11 +561,9 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\t\trxm->pkt_len = (uint16_t)rcd->len;\n \t\t\trxm->data_len = (uint16_t)rcd->len;\n \t\t\trxm->port = rxq->port_id;\n-\t\t\trxm->vlan_tci = 0;\n \t\t\trxm->data_off = RTE_PKTMBUF_HEADROOM;\n \n \t\t\trx_pkts[nb_rx++] = rxm;\n-\n rcd_done:\n \t\t\trxq->cmd_ring[ring_idx].next2comp = idx;\n \t\t\tVMXNET3_INC_RING_IDX_ONLY(rxq->cmd_ring[ring_idx].next2comp, rxq->cmd_ring[ring_idx].size);\n", "prefixes": [ "dpdk-dev", "v2", "1/6" ] }