Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112673/?format=api
{ "id": 112673, "url": "https://patches.dpdk.org/api/patches/112673/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220611074227.30276-2-liudongdong3@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220611074227.30276-2-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220611074227.30276-2-liudongdong3@huawei.com", "date": "2022-06-11T07:42:26", "name": "[1/2] net/hns3: fix fail to obtain VF LSC capability", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e8b8799ee508260f20de3bfecf76709a669d6186", "submitter": { "id": 2718, "url": "https://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220611074227.30276-2-liudongdong3@huawei.com/mbox/", "series": [ { "id": 23481, "url": "https://patches.dpdk.org/api/series/23481/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=23481", "date": "2022-06-11T07:42:25", "name": "net/hns3: support backplane media type", "version": 1, "mbox": "https://patches.dpdk.org/series/23481/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/112673/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/112673/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EF0FAA0553;\n\tSat, 11 Jun 2022 09:42:55 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8BBBB427F9;\n\tSat, 11 Jun 2022 09:42:51 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id D0B9C40689;\n Sat, 11 Jun 2022 09:42:49 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.55])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LKqXW21TmzjX8g;\n Sat, 11 Jun 2022 15:41:47 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Sat, 11 Jun 2022 15:42:47 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<stable@dpdk.org>, Huisong Li <lihuisong@huawei.com>, Dongdong Liu\n <liudongdong3@huawei.com>, \"Min Hu (Connor)\" <humin29@huawei.com>, Yisen\n Zhuang <yisen.zhuang@huawei.com>, Lijun Ou <oulijun@huawei.com>, Chengwen\n Feng <fengchengwen@huawei.com>", "Subject": "[PATCH 1/2] net/hns3: fix fail to obtain VF LSC capability", "Date": "Sat, 11 Jun 2022 15:42:26 +0800", "Message-ID": "<20220611074227.30276-2-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20220611074227.30276-1-liudongdong3@huawei.com>", "References": "<20220611074227.30276-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nCurrently, the VF LSC capability is obtained from PF driver in\nthe interrupt mailbox interrupt thread, it is asynchronous.\nThe VF driver waits for 500ms to get this capability in probe\nprocess.\n\nThe primary process will receive a message and do probe in the\ninterrupt thread context when attach a device in the secondary\nprocess. At this case, VF driver never obtains this capability\nfrom PF.\n\nThe root cause is that 'vf->pf_push_lsc_cap' is not updated by\nthe handling mailbox thread until finishing probe. The reason\nthis update wouldn't be done is that the handling mailbox interrupt\nthread and the probe alarm thread are both in epool thread, and\nthe probe alarm thread is before the mailbox interrupt thread.\n\nFixes: 9bc2289fe5ea (\"net/hns3: refactor VF LSC event report\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev_vf.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex bebfaa6417..3abd4aafcb 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -777,6 +777,14 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw)\n \n \twhile (remain_ms > 0) {\n \t\trte_delay_ms(HNS3_POLL_RESPONE_MS);\n+\t\t/*\n+\t\t * The probe process may perform in interrupt thread context.\n+\t\t * For example, users attach a device in the secondary process.\n+\t\t * At the moment, the handling mailbox task will be blocked. So\n+\t\t * driver has to actively handle the HNS3_MBX_LINK_STAT_CHANGE\n+\t\t * mailbox from PF driver to get this capability.\n+\t\t */\n+\t\thns3_dev_handle_mbx_msg(hw);\n \t\tif (__atomic_load_n(&vf->pf_push_lsc_cap, __ATOMIC_ACQUIRE) !=\n \t\t\tHNS3_PF_PUSH_LSC_CAP_UNKNOWN)\n \t\t\tbreak;\n", "prefixes": [ "1/2" ] }