Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112532/?format=api
{ "id": 112532, "url": "https://patches.dpdk.org/api/patches/112532/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1654673642-151882-1-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1654673642-151882-1-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1654673642-151882-1-git-send-email-andy.pei@intel.com", "date": "2022-06-08T07:34:02", "name": "vdpa/ifc: fix null pointer dereference", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c8baabb356682d9de10f6e640c61c3a968dd0faf", "submitter": { "id": 1185, "url": "https://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1654673642-151882-1-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 23407, "url": "https://patches.dpdk.org/api/series/23407/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=23407", "date": "2022-06-08T07:34:02", "name": "vdpa/ifc: fix null pointer dereference", "version": 1, "mbox": "https://patches.dpdk.org/series/23407/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/112532/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/112532/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5B7ADA0544;\n\tWed, 8 Jun 2022 10:23:20 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4E70341132;\n\tWed, 8 Jun 2022 10:23:20 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id D7BF240687\n for <dev@dpdk.org>; Wed, 8 Jun 2022 10:23:18 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Jun 2022 01:23:05 -0700", "from dpdk-dipei.sh.intel.com ([10.67.110.238])\n by fmsmga005.fm.intel.com with ESMTP; 08 Jun 2022 01:23:03 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1654676599; x=1686212599;\n h=from:to:cc:subject:date:message-id;\n bh=3xPJny590EM5xCmn7faaXQ62bt4lB8iyCRqUWa9IeUE=;\n b=ngON/N3CaELt3wCTbfJB86VHf7SZa3od5Oh59bwQFFtWbW9m9xKpV0wz\n UDoKM9mQdDHLgrBrJuNZpEPotlMdkGQAobwrm1I2ARPQmIf0Qugysqedq\n bAwpvhSglB3wYtwY9CNYMcxS9fZwgqUlKigEyUsJiP3iqYyTbNYOk/Acn\n 6Fg9EUQslFCRmxindR44HcRwXDFkRC0DuocLKhwbRulhFC8lZ57O5ByM6\n cXoXv6ADWsgLFNeeq9LpJO5hHyqUG09NHh0/jCdUawU7OqM5in4HxR0zi\n Psdr6+ofkfooATeMCNPo4FCMPkZQr+TCza6nrTR04ZmE3lcYnvSTGVSUS w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10371\"; a=\"277996866\"", "E=Sophos;i=\"5.91,285,1647327600\"; d=\"scan'208\";a=\"277996866\"", "E=Sophos;i=\"5.91,285,1647327600\"; d=\"scan'208\";a=\"907548079\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, maxime.coquelin@redhat.com, xiao.w.wang@intel.com,\n rosen.xu@intel.com, qimaix.xiao@intel.com", "Subject": "[PATCH] vdpa/ifc: fix null pointer dereference", "Date": "Wed, 8 Jun 2022 15:34:02 +0800", "Message-Id": "<1654673642-151882-1-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix null pointer dereference reported in coverity scan.\n\nCoverity issue: 378882\nFixes: 8162a4a9 (\"vdpa/ifc/base: access correct register for blk device\")\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n drivers/vdpa/ifc/base/ifcvf.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c\nindex dd475a7..0a9f71a 100644\n--- a/drivers/vdpa/ifc/base/ifcvf.c\n+++ b/drivers/vdpa/ifc/base/ifcvf.c\n@@ -255,6 +255,10 @@\n \tu32 ring_state;\n \n \tcfg = hw->common_cfg;\n+\tif (!cfg) {\n+\t\tDEBUGOUT(\"common_cfg in HW is NULL.\\n\");\n+\t\treturn;\n+\t}\n \n \tIFCVF_WRITE_REG16(IFCVF_MSI_NO_VECTOR, &cfg->msix_config);\n \tfor (i = 0; i < hw->nr_vring; i++) {\n@@ -262,6 +266,11 @@\n \t\tIFCVF_WRITE_REG16(0, &cfg->queue_enable);\n \t\tIFCVF_WRITE_REG16(IFCVF_MSI_NO_VECTOR, &cfg->queue_msix_vector);\n \n+\t\tif (!hw->lm_cfg) {\n+\t\t\tDEBUGOUT(\"live migration cfg in HW is NULL.\\n\");\n+\t\t\tcontinue;\n+\t\t}\n+\n \t\tif (hw->device_type == IFCVF_BLK)\n \t\t\tring_state = *(u32 *)(hw->lm_cfg +\n \t\t\t\t\tIFCVF_LM_RING_STATE_OFFSET +\n", "prefixes": [] }