Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112375/?format=api
{ "id": 112375, "url": "https://patches.dpdk.org/api/patches/112375/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220606114650.209612-2-lizh@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220606114650.209612-2-lizh@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220606114650.209612-2-lizh@nvidia.com", "date": "2022-06-06T11:46:34", "name": "[v1,01/17] vdpa/mlx5: fix usage of capability for max number of virtqs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "05eb31c4054db9fdb38df8fa76c38985b80399df", "submitter": { "id": 1967, "url": "https://patches.dpdk.org/api/people/1967/?format=api", "name": "Li Zhang", "email": "lizh@nvidia.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220606114650.209612-2-lizh@nvidia.com/mbox/", "series": [ { "id": 23355, "url": "https://patches.dpdk.org/api/series/23355/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=23355", "date": "2022-06-06T11:46:34", "name": "[v1,01/17] vdpa/mlx5: fix usage of capability for max number of virtqs", "version": 1, "mbox": "https://patches.dpdk.org/series/23355/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/112375/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/112375/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5F476A0542;\n\tMon, 6 Jun 2022 13:47:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2ADD241611;\n\tMon, 6 Jun 2022 13:47:21 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2078.outbound.protection.outlook.com [40.107.92.78])\n by mails.dpdk.org (Postfix) with ESMTP id 462F9415D7;\n Mon, 6 Jun 2022 13:47:20 +0200 (CEST)", "from MW4PR04CA0126.namprd04.prod.outlook.com (2603:10b6:303:84::11)\n by BY5PR12MB3793.namprd12.prod.outlook.com (2603:10b6:a03:1ad::26)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Mon, 6 Jun\n 2022 11:47:17 +0000", "from CO1NAM11FT013.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:84:cafe::65) by MW4PR04CA0126.outlook.office365.com\n (2603:10b6:303:84::11) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12 via Frontend\n Transport; Mon, 6 Jun 2022 11:47:17 +0000", "from mail.nvidia.com (12.22.5.236) by\n CO1NAM11FT013.mail.protection.outlook.com (10.13.174.227) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.5314.12 via Frontend Transport; Mon, 6 Jun 2022 11:47:17 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL109.nvidia.com\n (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.32;\n Mon, 6 Jun 2022 11:47:16 +0000", "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 6 Jun 2022\n 04:47:13 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=lzbKNdp5JHsBNJff/KdeV5id3hik30FlWY2nOoBT4qYJQ5VrOKmwj7Wv9kJHWuypYi2jyLKAANOWUQ/CpzIwH1ulE9S97KUEFOmfLzJtOMzRBN2+tnOIflNqJhTeV9MywWa/k1RIfFtzExrkJp6634Jng5SJfVL5/3K1CV20irdqAPIaV5fyhbvwDM792bS7lI7kfvOurj0drDVEysQsIezyWGfHfvc8ErGvAdM0Tp+prvLmcb5QH2pw8l1IdN5Y0ywj0hiKcwo3wkr5k8zANZTLnKr+gww8rTN0OAwaUzsPWk2Q1MXAZVyoO2iA9T+k4GwIhpVwlkyFGQZzyyRVJA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=RAN/gXubkThMQrVMf7+vEVmRYwtqH62xGWmAZeglDoQ=;\n b=iscg21psD16F08Vwi27VPDAtZnxmHBJaTewEdjUJUOh60joFejZx+762re6tTJyu9t86I8epzLnmEDCdHF52pNZn8Wcoj3CCI1Bkhnh3zfPrzZV9EGL1oNt575i5Oq0LazBfGMA/EU4SxG2TRuGfuJ+oAQC2XW9mTHkmYjwVWkxxBQK2NLFbtYfCWz1P8Zd0G9idUlFKZlJaEQGDh0fDyv8Pklem4tXO93WDinTa1fC1eLaaz5q5zCoBhKeucjyNcscDYKt8ApiWnOr5gw6K7WbGvGO8kh92Bk5Knw7WoixwNtQegVFaFkhV6yfhEqgEgw/5nC+ziQcJMTrpj4ZVJA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 12.22.5.236) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=RAN/gXubkThMQrVMf7+vEVmRYwtqH62xGWmAZeglDoQ=;\n b=Bi1pvCNrhnxP79AtqeN6eL6HJn8pRvf0v7LpIqqhQU8DnhXdqr+7Gx1RxPi7+9NvZIWfh2lKyHMjj47mFrexe5d8HPtwEarY133y9zxfjra6ttOIxIGSG3fG8QRS3k+eqLyJRhPgczH2jexRRhp1+1Xta2wFNf1KfCKKozzmg5xpuMxWM7keHhY13bONIL4nK7YuVffbRIE4mwWvnzgujGgiusnUCYGbkKk6uC+9Q1fdSh3Zr+krFaAX2aS32MAcsgvg0//G5yU1X3Dw2w8MUKFVC2V5xWbTMuv+OglxaHKyaoJzT9/YFybtyOIMR2J9AH4I/WZMnSXKKgY02fMZWg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 12.22.5.236)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 12.22.5.236 as permitted sender) receiver=protection.outlook.com;\n client-ip=12.22.5.236; helo=mail.nvidia.com; pr=C", "From": "Li Zhang <lizh@nvidia.com>", "To": "<orika@nvidia.com>, <viacheslavo@nvidia.com>, <matan@nvidia.com>,\n <shahafs@nvidia.com>, Maxime Coquelin <maxime.coquelin@redhat.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <rasland@nvidia.com>,\n <roniba@nvidia.com>, <stable@dpdk.org>", "Subject": "[PATCH v1 01/17] vdpa/mlx5: fix usage of capability for max number of\n virtqs", "Date": "Mon, 6 Jun 2022 14:46:34 +0300", "Message-ID": "<20220606114650.209612-2-lizh@nvidia.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220606114650.209612-1-lizh@nvidia.com>", "References": "<20220408075606.33056-1-lizh@nvidia.com>\n <20220606114650.209612-1-lizh@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "43cdf559-2a3a-4c6c-92ea-08da47b24e73", "X-MS-TrafficTypeDiagnostic": "BY5PR12MB3793:EE_", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <BY5PR12MB3793777B617E6BE2AD1B8341BFA29@BY5PR12MB3793.namprd12.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n LHYPv4SZSCub9i0++IUs96BMcMPOhNHiQwsNBoSNbTzRItZ7gf/9NxPy/KMQdBZ5ltxAHt1uInW+Cz9egbDB4XDCY9bW/CPAJRNn+M1uvwkmg5ubTpC/+iNBu3SmrsLsRoF4FpRbA6v/9WcmvFNSp5doEys7dgAIFlwJbofoWE7wRl9LM/g4nvKoHP1IisS0KavYaO0Iaa6NfkF+u7vGlUz+sSa8CcA94dCqXyc88loHbJZTK6pNmIyb2JvJG8IE2hC97o/3mY3XyIZgPxQIHbJc42ziH/nugptEjnZuKtVSC7UZfvvGbOD4qyVxUEd6k1irlLxNG6TAJrT1yCGDc2RtaIqjcZHOddoD3hHhSfEmAj7mW9rfSFr4aM9u7R7jWzKc0xOArtc+4afYusGVHES6A03+BZo+HukWsnW7HwKEuyYqajP1hJvQJP4pu60Q0zvWVTDX922uJzCycmLsm9SFMc+RZyoHW4PYkCHDABmWU6pZHOdHBfJZTOvolUSWQyreNIn5lbJf4X4S6cffv1bmTDfPzx7IxCqwNgbseNA0Y8FCqlb33PwScmuuNrDnUAEW+yBH6ntCmAtOTfhJQQOioREvZtR2/XCxJ/vTZbuV5ppuWA/SljhExuX0V0T7fPk/3rdmyqel+GlyT03FTbhSlvPMTpYwRdLOXSQMdCsZx/kqdCM53fBrCKO5+LxwZAaea5doeKEidoQVGwKyUw==", "X-Forefront-Antispam-Report": "CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE;\n SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(86362001)(40460700003)(8676002)(4326008)(5660300002)(70586007)(70206006)(36860700001)(7696005)(356005)(1076003)(6666004)(8936002)(54906003)(110136005)(6286002)(26005)(16526019)(82310400005)(186003)(83380400001)(316002)(2906002)(508600001)(55016003)(36756003)(2616005)(81166007)(426003)(47076005)(336012)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "06 Jun 2022 11:47:17.1200 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 43cdf559-2a3a-4c6c-92ea-08da47b24e73", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT013.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR12MB3793", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The driver wrongly takes the capability value for\nthe number of virtq pairs instead of just the number of virtqs.\n\nAdjust all the usages of it to be the number of virtqs.\n\nFixes: c2eb33a (\"vdpa/mlx5: manage virtqs by array\")\nCc: stable@dpdk.org\n\nSigned-off-by: Li Zhang <lizh@nvidia.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa.c | 12 ++++++------\n drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 6 +++---\n 2 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex 76fa5d4299..ee71339b78 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -84,7 +84,7 @@ mlx5_vdpa_get_queue_num(struct rte_vdpa_device *vdev, uint32_t *queue_num)\n \t\tDRV_LOG(ERR, \"Invalid vDPA device: %s.\", vdev->device->name);\n \t\treturn -1;\n \t}\n-\t*queue_num = priv->caps.max_num_virtio_queues;\n+\t*queue_num = priv->caps.max_num_virtio_queues / 2;\n \treturn 0;\n }\n \n@@ -141,7 +141,7 @@ mlx5_vdpa_set_vring_state(int vid, int vring, int state)\n \t\tDRV_LOG(ERR, \"Invalid vDPA device: %s.\", vdev->device->name);\n \t\treturn -EINVAL;\n \t}\n-\tif (vring >= (int)priv->caps.max_num_virtio_queues * 2) {\n+\tif (vring >= (int)priv->caps.max_num_virtio_queues) {\n \t\tDRV_LOG(ERR, \"Too big vring id: %d.\", vring);\n \t\treturn -E2BIG;\n \t}\n@@ -388,7 +388,7 @@ mlx5_vdpa_get_stats(struct rte_vdpa_device *vdev, int qid,\n \t\tDRV_LOG(ERR, \"Invalid device: %s.\", vdev->device->name);\n \t\treturn -ENODEV;\n \t}\n-\tif (qid >= (int)priv->caps.max_num_virtio_queues * 2) {\n+\tif (qid >= (int)priv->caps.max_num_virtio_queues) {\n \t\tDRV_LOG(ERR, \"Too big vring id: %d for device %s.\", qid,\n \t\t\t\tvdev->device->name);\n \t\treturn -E2BIG;\n@@ -411,7 +411,7 @@ mlx5_vdpa_reset_stats(struct rte_vdpa_device *vdev, int qid)\n \t\tDRV_LOG(ERR, \"Invalid device: %s.\", vdev->device->name);\n \t\treturn -ENODEV;\n \t}\n-\tif (qid >= (int)priv->caps.max_num_virtio_queues * 2) {\n+\tif (qid >= (int)priv->caps.max_num_virtio_queues) {\n \t\tDRV_LOG(ERR, \"Too big vring id: %d for device %s.\", qid,\n \t\t\t\tvdev->device->name);\n \t\treturn -E2BIG;\n@@ -624,7 +624,7 @@ mlx5_vdpa_dev_probe(struct mlx5_common_device *cdev,\n \t\tDRV_LOG(DEBUG, \"No capability to support virtq statistics.\");\n \tpriv = rte_zmalloc(\"mlx5 vDPA device private\", sizeof(*priv) +\n \t\t\t sizeof(struct mlx5_vdpa_virtq) *\n-\t\t\t attr->vdpa.max_num_virtio_queues * 2,\n+\t\t\t attr->vdpa.max_num_virtio_queues,\n \t\t\t RTE_CACHE_LINE_SIZE);\n \tif (!priv) {\n \t\tDRV_LOG(ERR, \"Failed to allocate private memory.\");\n@@ -685,7 +685,7 @@ mlx5_vdpa_release_dev_resources(struct mlx5_vdpa_priv *priv)\n \tuint32_t i;\n \n \tmlx5_vdpa_dev_cache_clean(priv);\n-\tfor (i = 0; i < priv->caps.max_num_virtio_queues * 2; i++) {\n+\tfor (i = 0; i < priv->caps.max_num_virtio_queues; i++) {\n \t\tif (!priv->virtqs[i].counters)\n \t\t\tcontinue;\n \t\tclaim_zero(mlx5_devx_cmd_destroy(priv->virtqs[i].counters));\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\nindex e025be47d2..c258eb3024 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n@@ -72,7 +72,7 @@ mlx5_vdpa_virtqs_cleanup(struct mlx5_vdpa_priv *priv)\n {\n \tunsigned int i, j;\n \n-\tfor (i = 0; i < priv->caps.max_num_virtio_queues * 2; i++) {\n+\tfor (i = 0; i < priv->caps.max_num_virtio_queues; i++) {\n \t\tstruct mlx5_vdpa_virtq *virtq = &priv->virtqs[i];\n \n \t\tfor (j = 0; j < RTE_DIM(virtq->umems); ++j) {\n@@ -492,9 +492,9 @@ mlx5_vdpa_virtqs_prepare(struct mlx5_vdpa_priv *priv)\n \t\tDRV_LOG(INFO, \"TSO is enabled without CSUM, force CSUM.\");\n \t\tpriv->features |= (1ULL << VIRTIO_NET_F_CSUM);\n \t}\n-\tif (nr_vring > priv->caps.max_num_virtio_queues * 2) {\n+\tif (nr_vring > priv->caps.max_num_virtio_queues) {\n \t\tDRV_LOG(ERR, \"Do not support more than %d virtqs(%d).\",\n-\t\t\t(int)priv->caps.max_num_virtio_queues * 2,\n+\t\t\t(int)priv->caps.max_num_virtio_queues,\n \t\t\t(int)nr_vring);\n \t\treturn -1;\n \t}\n", "prefixes": [ "v1", "01/17" ] }