Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1117/?format=api
https://patches.dpdk.org/api/patches/1117/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1415088494-10248-1-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1415088494-10248-1-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1415088494-10248-1-git-send-email-helin.zhang@intel.com", "date": "2014-11-04T08:08:14", "name": "[dpdk-dev] i40e: fix of PF interrupt handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8aa76d8f109d6b52bf494f740cd0f21715bfce08", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1415088494-10248-1-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1117/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1117/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8E540592E;\n\tTue, 4 Nov 2014 08:59:12 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id C22452A9\n\tfor <dev@dpdk.org>; Tue, 4 Nov 2014 08:59:10 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 04 Nov 2014 00:06:28 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 04 Nov 2014 00:08:20 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sA488Ixv002145;\n\tTue, 4 Nov 2014 16:08:18 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sA488GYt010282; Tue, 4 Nov 2014 16:08:18 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sA488GUv010278; \n\tTue, 4 Nov 2014 16:08:16 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,312,1413270000\"; d=\"scan'208\";a=\"601813936\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 4 Nov 2014 16:08:14 +0800", "Message-Id": "<1415088494-10248-1-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "Subject": "[dpdk-dev] [PATCH] i40e: fix of PF interrupt handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "'PFINT_ICR0_ENA' shouldn't be cleared in user space ISR,\notherwise adminq interrupts might be missed during\nco-working with VF initialization.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex 661d146..ea10c26 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -3574,7 +3574,6 @@ i40e_dev_interrupt_delayed_handler(void *param)\n \ti40e_dev_link_update(dev, 0);\n \t_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC);\n \n-\tI40E_WRITE_REG(hw, I40E_PFINT_ICR0_ENA, I40E_PFINT_ICR0_ENA_MASK);\n \ti40e_pf_enable_irq0(hw);\n \trte_intr_enable(&(dev->pci_dev->intr_handle));\n }\n@@ -3601,7 +3600,6 @@ i40e_dev_interrupt_handler(__rte_unused struct rte_intr_handle *handle,\n \n \t/* Disable interrupt */\n \ti40e_pf_disable_irq0(hw);\n-\tI40E_WRITE_REG(hw, I40E_PFINT_ICR0_ENA, 0);\n \n \t/* read out interrupt causes */\n \ticr0 = I40E_READ_REG(hw, I40E_PFINT_ICR0);\n@@ -3663,7 +3661,6 @@ i40e_dev_interrupt_handler(__rte_unused struct rte_intr_handle *handle,\n \n done:\n \t/* Enable interrupt */\n-\tI40E_WRITE_REG(hw, I40E_PFINT_ICR0_ENA, I40E_PFINT_ICR0_ENA_MASK);\n \ti40e_pf_enable_irq0(hw);\n \trte_intr_enable(&(dev->pci_dev->intr_handle));\n }\n", "prefixes": [ "dpdk-dev" ] }{ "id": 1117, "url": "