Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111518/?format=api
https://patches.dpdk.org/api/patches/111518/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-35-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220520055445.40063-35-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220520055445.40063-35-arkadiuszx.kusztal@intel.com", "date": "2022-05-20T05:54:39", "name": "[34/40] crypto/cnxk: reduce rsa struct to only necessary fields", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5a4f05f6db8c54a36a3c0c3bc37c7a8fdc03ec53", "submitter": { "id": 452, "url": "https://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-35-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 23057, "url": "https://patches.dpdk.org/api/series/23057/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=23057", "date": "2022-05-20T05:54:05", "name": "cryptodev: rsa, dh, ecdh changes", "version": 1, "mbox": "https://patches.dpdk.org/series/23057/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/111518/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/111518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D9185A0503;\n\tFri, 20 May 2022 09:06:02 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 73C3442BB7;\n\tFri, 20 May 2022 09:03:59 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 474C942BB7\n for <dev@dpdk.org>; Fri, 20 May 2022 09:03:57 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 May 2022 00:03:56 -0700", "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by orsmga008.jf.intel.com with ESMTP; 20 May 2022 00:03:55 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653030237; x=1684566237;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=nayuCYs73MpvIci/iJTsBqfQPH/oM40oPPfsr2bqZzc=;\n b=n+BV19Tr2crt/lD8YLxlk3JP01UR3Lr4gmAnqSqH0wLvnB+2KdPfL5Q0\n EQEuEzGuynUhRmx1Tr19wl1ZZ3KYe7h7eOWrP6eXkp+8JABn0O9aECeZJ\n LK/27mcUKnDUasnY7qyieKqYIM9XA/cp4hjXIotfLDmMqEikTopwYSN8b\n 5y3jbKLo5RpT+TfoqGQe36Omi2SA6IrH/Dy4olV+FxIZx8XqkN+Wx5H1H\n MB4eeEYkxGo+BciFudumSHb88OlwURg5vWVCoiJdxKSTlNXL8OGp0Yn9M\n LFZd0sTMBNVZH+Pl6fFjk/sHJLL/QyQMB7esfRIQ6ANksLuc37AfRmuUn g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10352\"; a=\"333140486\"", "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"333140486\"", "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"599058608\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, anoobj@marvell.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Subject": "[PATCH 34/40] crypto/cnxk: reduce rsa struct to only necessary fields", "Date": "Fri, 20 May 2022 06:54:39 +0100", "Message-Id": "<20220520055445.40063-35-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>", "References": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- reduced rsa struct to only necessary fields.\nThis commit reflects changes to the asymmetric crypto API.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n drivers/crypto/cnxk/cnxk_ae.h | 36 ++++++++++++++++++------------------\n 1 file changed, 18 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cnxk_ae.h b/drivers/crypto/cnxk/cnxk_ae.h\nindex 0562f72270..ea6964dd37 100644\n--- a/drivers/crypto/cnxk/cnxk_ae.h\n+++ b/drivers/crypto/cnxk/cnxk_ae.h\n@@ -380,19 +380,19 @@ cnxk_ae_enqueue_rsa_op(struct rte_crypto_op *op,\n \n \tswitch (rsa->op_type) {\n \tcase RTE_CRYPTO_ASYM_OP_VERIFY:\n-\t\tcnxk_ae_rsa_prep(op, meta_buf, &sess->rsa_ctx, &rsa->sign,\n+\t\tcnxk_ae_rsa_prep(op, meta_buf, &sess->rsa_ctx, &rsa->input,\n \t\t\t\t inst);\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_OP_ENCRYPT:\n-\t\tcnxk_ae_rsa_prep(op, meta_buf, &sess->rsa_ctx, &rsa->message,\n+\t\tcnxk_ae_rsa_prep(op, meta_buf, &sess->rsa_ctx, &rsa->input,\n \t\t\t\t inst);\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_OP_SIGN:\n \t\tcnxk_ae_rsa_crt_prep(op, meta_buf, &sess->rsa_ctx,\n-\t\t\t\t &rsa->message, inst);\n+\t\t\t\t &rsa->input, inst);\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_OP_DECRYPT:\n-\t\tcnxk_ae_rsa_crt_prep(op, meta_buf, &sess->rsa_ctx, &rsa->cipher,\n+\t\tcnxk_ae_rsa_crt_prep(op, meta_buf, &sess->rsa_ctx, &rsa->input,\n \t\t\t\t inst);\n \t\tbreak;\n \tdefault:\n@@ -671,44 +671,44 @@ cnxk_ae_dequeue_rsa_op(struct rte_crypto_op *cop, uint8_t *rptr,\n \n \tswitch (rsa->op_type) {\n \tcase RTE_CRYPTO_ASYM_OP_ENCRYPT:\n-\t\trsa->cipher.length = rsa_ctx->n.length;\n-\t\tmemcpy(rsa->cipher.data, rptr, rsa->cipher.length);\n+\t\trsa->output.length = rsa_ctx->n.length;\n+\t\tmemcpy(rsa->output.data, rptr, rsa->output.length);\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_OP_DECRYPT:\n \t\tif (rsa->padding.type == RTE_CRYPTO_RSA_PADDING_NONE) {\n-\t\t\trsa->message.length = rsa_ctx->n.length;\n-\t\t\tmemcpy(rsa->message.data, rptr, rsa->message.length);\n+\t\t\trsa->output.length = rsa_ctx->n.length;\n+\t\t\tmemcpy(rsa->output.data, rptr, rsa->output.length);\n \t\t} else {\n \t\t\t/* Get length of decrypted output */\n-\t\t\trsa->message.length =\n+\t\t\trsa->output.length =\n \t\t\t\trte_cpu_to_be_16(*((uint16_t *)rptr));\n \t\t\t/*\n \t\t\t * Offset output data pointer by length field\n \t\t\t * (2 bytes) and copy decrypted data.\n \t\t\t */\n-\t\t\tmemcpy(rsa->message.data, rptr + 2,\n-\t\t\t rsa->message.length);\n+\t\t\tmemcpy(rsa->output.data, rptr + 2,\n+\t\t\t rsa->output.length);\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_OP_SIGN:\n-\t\trsa->sign.length = rsa_ctx->n.length;\n-\t\tmemcpy(rsa->sign.data, rptr, rsa->sign.length);\n+\t\trsa->input.length = rsa_ctx->n.length;\n+\t\tmemcpy(rsa->output.data, rptr, rsa->output.length);\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_OP_VERIFY:\n \t\tif (rsa->padding.type == RTE_CRYPTO_RSA_PADDING_NONE) {\n-\t\t\trsa->sign.length = rsa_ctx->n.length;\n-\t\t\tmemcpy(rsa->sign.data, rptr, rsa->sign.length);\n+\t\t\trsa->output.length = rsa_ctx->n.length;\n+\t\t\tmemcpy(rsa->output.data, rptr, rsa->output.length);\n \t\t} else {\n \t\t\t/* Get length of signed output */\n-\t\t\trsa->sign.length =\n+\t\t\trsa->output.length =\n \t\t\t\trte_cpu_to_be_16(*((uint16_t *)rptr));\n \t\t\t/*\n \t\t\t * Offset output data pointer by length field\n \t\t\t * (2 bytes) and copy signed data.\n \t\t\t */\n-\t\t\tmemcpy(rsa->sign.data, rptr + 2, rsa->sign.length);\n+\t\t\tmemcpy(rsa->output.data, rptr + 2, rsa->output.length);\n \t\t}\n-\t\tif (memcmp(rsa->sign.data, rsa->message.data,\n+\t\tif (memcmp(rsa->output.data, rsa->message.data,\n \t\t\t rsa->message.length)) {\n \t\t\tcop->status = RTE_CRYPTO_OP_STATUS_ERROR;\n \t\t}\n", "prefixes": [ "34/40" ] }{ "id": 111518, "url": "