Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111488/?format=api
https://patches.dpdk.org/api/patches/111488/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-5-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220520055445.40063-5-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220520055445.40063-5-arkadiuszx.kusztal@intel.com", "date": "2022-05-20T05:54:09", "name": "[04/40] cryptodev: reduce number of comments in asym xform", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "910b2626bd364af767afff21e69f2d5d5e9b8c23", "submitter": { "id": 452, "url": "https://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-5-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 23057, "url": "https://patches.dpdk.org/api/series/23057/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=23057", "date": "2022-05-20T05:54:05", "name": "cryptodev: rsa, dh, ecdh changes", "version": 1, "mbox": "https://patches.dpdk.org/series/23057/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/111488/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/111488/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 641C4A0503;\n\tFri, 20 May 2022 09:02:53 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 64FA442B8C;\n\tFri, 20 May 2022 09:02:46 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 2E2A342B89\n for <dev@dpdk.org>; Fri, 20 May 2022 09:02:44 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 May 2022 00:02:43 -0700", "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by orsmga008.jf.intel.com with ESMTP; 20 May 2022 00:02:42 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653030164; x=1684566164;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=F01b3iqMeaMAiM1bZtNJumN6/wjHbECm79nd4WIQV2k=;\n b=mMiWYq1+OG1dmqynCA51kgtGjknGhiRK8iUR1riJN6N/QZUopn/NXaB6\n Q/EgnFSz/6ImhPNvLzzQlFVKdwDBMo4qMXonRdyK91UFSkTHBMpsdOy03\n CDJL7Dlh3kE8sIN9bi/ZDmv7f/TU8ZZMaiQpvBAGc/0ssWFjhJKvFmV2y\n CMeqdHqJPu8LBnbGBQq6sL5gB3/JrqQGORiFNOAqwA2YTOaD6dvDVet2q\n yDa9DUVaZm01FMxMxrvJ/GgL9qhmmLpqT3KYyQ4gZ/CHIqapyJSU27Y8O\n xgCJBWwRQtXGFcyrj9mXfTCxZg1bu+otYJRjzVB7ys+D5SqfwDcAr6v4C A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10352\"; a=\"333140216\"", "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"333140216\"", "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"599058104\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, anoobj@marvell.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Subject": "[PATCH 04/40] cryptodev: reduce number of comments in asym xform", "Date": "Fri, 20 May 2022 06:54:09 +0100", "Message-Id": "<20220520055445.40063-5-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>", "References": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- Reduced number of comments in asymmetric xform.\nInformation describing basic functionality of well known\nalgorithms are unnecessary.\n- Added information about data memory lifetime.\nIt was specified how user should work with private data,\nand it is user's responsability to clear it.\n- Removed NONE asymetric xform.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n lib/cryptodev/rte_crypto_asym.h | 45 +++++++++++++----------------------------\n lib/cryptodev/rte_cryptodev.c | 1 -\n 2 files changed, 14 insertions(+), 32 deletions(-)", "diff": "diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h\nindex a474b6acd1..0251e8caae 100644\n--- a/lib/cryptodev/rte_crypto_asym.h\n+++ b/lib/cryptodev/rte_crypto_asym.h\n@@ -55,46 +55,29 @@ enum rte_crypto_curve_id {\n };\n \n /**\n- * Asymmetric crypto transformation types.\n- * Each xform type maps to one asymmetric algorithm\n- * performing specific operation\n- *\n+ * Asymmetric crypto algorithm static data.\n+ * Data that may be used more than once (e.g. RSA private key).\n+ * It is the USER responsibility to keep track of private data memory\n+ * lifetime and security of the this data in xform. The same way\n+ * it is the USER responsibility to call cryptodev session_clear()\n+ * function if a session was created. If session-less not used\n+ * xform data should be cleared after successful session creation.\n */\n enum rte_crypto_asym_xform_type {\n-\tRTE_CRYPTO_ASYM_XFORM_UNSPECIFIED = 0,\n+\tRTE_CRYPTO_ASYM_XFORM_UNSPECIFIED,\n \t/**< Invalid xform. */\n-\tRTE_CRYPTO_ASYM_XFORM_NONE,\n-\t/**< Xform type None.\n-\t * May be supported by PMD to support\n-\t * passthrough op for debugging purpose.\n-\t * if xform_type none , op_type is disregarded.\n-\t */\n \tRTE_CRYPTO_ASYM_XFORM_RSA,\n-\t/**< RSA. Performs Encrypt, Decrypt, Sign and Verify.\n-\t * Refer to rte_crypto_asym_op_type\n-\t */\n+\t/**< RSA */\n \tRTE_CRYPTO_ASYM_XFORM_DH,\n-\t/**< Diffie-Hellman.\n-\t * Performs Key Generate and Shared Secret Compute.\n-\t * Refer to rte_crypto_asym_op_type\n-\t */\n+\t/**< Diffie-Hellman */\n \tRTE_CRYPTO_ASYM_XFORM_DSA,\n-\t/**< Digital Signature Algorithm\n-\t * Performs Signature Generation and Verification.\n-\t * Refer to rte_crypto_asym_op_type\n-\t */\n+\t/**< Digital Signature Algorithm */\n \tRTE_CRYPTO_ASYM_XFORM_MODINV,\n-\t/**< Modular Multiplicative Inverse\n-\t * Perform Modular Multiplicative Inverse b^(-1) mod n\n-\t */\n+\t/**< Modular Multiplicative Inverse */\n \tRTE_CRYPTO_ASYM_XFORM_MODEX,\n-\t/**< Modular Exponentiation\n-\t * Perform Modular Exponentiation b^e mod n\n-\t */\n+\t/**< Modular Exponentiation */\n \tRTE_CRYPTO_ASYM_XFORM_ECDSA,\n-\t/**< Elliptic Curve Digital Signature Algorithm\n-\t * Perform Signature Generation and Verification.\n-\t */\n+\t/**< Elliptic Curve Digital Signature Algorithm */\n \tRTE_CRYPTO_ASYM_XFORM_ECPM\n \t/**< Elliptic Curve Point Multiplication */\n };\ndiff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c\nindex e16e6802aa..691625bd04 100644\n--- a/lib/cryptodev/rte_cryptodev.c\n+++ b/lib/cryptodev/rte_cryptodev.c\n@@ -160,7 +160,6 @@ rte_crypto_aead_operation_strings[] = {\n * Asymmetric crypto transform operation strings identifiers.\n */\n const char *rte_crypto_asym_xform_strings[] = {\n-\t[RTE_CRYPTO_ASYM_XFORM_NONE]\t= \"none\",\n \t[RTE_CRYPTO_ASYM_XFORM_RSA]\t= \"rsa\",\n \t[RTE_CRYPTO_ASYM_XFORM_MODEX]\t= \"modexp\",\n \t[RTE_CRYPTO_ASYM_XFORM_MODINV]\t= \"modinv\",\n", "prefixes": [ "04/40" ] }{ "id": 111488, "url": "