Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111455/?format=api
{ "id": 111455, "url": "https://patches.dpdk.org/api/patches/111455/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220519213642.2647946-7-ed.czeck@atomicrules.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220519213642.2647946-7-ed.czeck@atomicrules.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220519213642.2647946-7-ed.czeck@atomicrules.com", "date": "2022-05-19T21:36:42", "name": "[v2,7/7] net/ark: add PMD support for devices as virtual functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f40638826958ada052023c996ddd20aa9f86f4e2", "submitter": { "id": 699, "url": "https://patches.dpdk.org/api/people/699/?format=api", "name": "Ed Czeck", "email": "ed.czeck@atomicrules.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220519213642.2647946-7-ed.czeck@atomicrules.com/mbox/", "series": [ { "id": 23049, "url": "https://patches.dpdk.org/api/series/23049/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=23049", "date": "2022-05-19T21:36:36", "name": "[v2,1/7] devtools: add Atomic Rules acronyms for commit checks", "version": 2, "mbox": "https://patches.dpdk.org/series/23049/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/111455/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/111455/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3721DA0503;\n\tThu, 19 May 2022 23:38:28 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A225842B82;\n\tThu, 19 May 2022 23:38:06 +0200 (CEST)", "from mail-qv1-f66.google.com (mail-qv1-f66.google.com\n [209.85.219.66]) by mails.dpdk.org (Postfix) with ESMTP id 751A442B79\n for <dev@dpdk.org>; Thu, 19 May 2022 23:38:01 +0200 (CEST)", "by mail-qv1-f66.google.com with SMTP id j3so5562495qvn.0\n for <dev@dpdk.org>; Thu, 19 May 2022 14:38:01 -0700 (PDT)", "from z390.czeck.local (pool-173-48-102-189.bstnma.fios.verizon.net.\n [173.48.102.189]) by smtp.gmail.com with ESMTPSA id\n ca22-20020a05622a1f1600b002f39b99f6bcsm1889607qtb.86.2022.05.19.14.37.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 May 2022 14:37:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=atomicrules-com.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=YaNMOORVXDvVl4tF9+IeIVMZZ62bObbwunbbs51UBxc=;\n b=YQyd18ZgmZnpT9cl9/MQ0MswvJmATxE6Umj2+PK8w9uadk5IQ2QaHTVHY3VLmtq6I8\n gBBddBXMdxcWGN9fGPZaUTzfDVlSi0TEWEZl5O9sUimT8aGuF/o8tnMYqhcXT9Sw/Gyp\n maioOlfsRzr25AQuEUvM4cXvc/fXBqRcJqv0vh+KeQbM27GX3zkqvyjH0qU09QKebw5c\n o3wEiwaFPCRE2rw1IX65c/Izeve1em6JzOy1yBqYcN7/BZshUheeqsjg7N+w1ALJFgHG\n vHVAFFhLuKBdhoHCbE6haP+gQjSC+0HJhvuehShh1kma9fKu0kMGQP0bBIAqbmjmap6r\n s1DA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=YaNMOORVXDvVl4tF9+IeIVMZZ62bObbwunbbs51UBxc=;\n b=nhOV4Kp/FVHKpFNXJa69sDTOITvBIbAuFGvPbsfubuOoKzquWJ0BGKmIzoZzriklaD\n 62ZMQrpTylYg3qyuGHC5VUGWHU8Nsx77un8m4+XjAFlteWF7eDyH5H1XMh8u0smQMWCI\n sB5uUV65J5jdrzgpyUf4TXJ63e7AiW2QaSdB2FHVSYrPKNc3jZ74z2OFAdTSCv1skpt3\n yFzmUO9EYaWVDYn2L6Vhp72WHLqpN7KOMMz3hbUdmvW5VVtx323jvNtzS0s/PSc8c+Qm\n rvzflLnKRHbPDpgqKUn9aLtFiORSDWJ+rGciC2peNGXVA43bb687i967dp+DP3INj4pl\n az0A==", "X-Gm-Message-State": "AOAM531Pv5IG6yfx+ZUA4cdD68SLekk+d5a1Qm9Kd+6gcOYAp0v9Yhtt\n Kk4weropDteXl96puWcbMewdEsEi5QZLDEmD", "X-Google-Smtp-Source": "\n ABdhPJyUy/5efwNu/nB9Sb3Ll4Vhy/pxjPPcqsYjaz8SqqI//GSsM/f1Dr0yYy19D5N+CEeRUtKxGg==", "X-Received": "by 2002:a05:6214:c6f:b0:45a:a2f2:6d23 with SMTP id\n t15-20020a0562140c6f00b0045aa2f26d23mr5992948qvj.55.1652996280520;\n Thu, 19 May 2022 14:38:00 -0700 (PDT)", "From": "Ed Czeck <ed.czeck@atomicrules.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@xilinx.com, ktraynor@redhat.com, bluca@debian.org,\n Shepard Siegel <shepard.siegel@atomicrules.com>,\n John Miller <john.miller@atomicrules.com>", "Subject": "[PATCH v2 7/7] net/ark: add PMD support for devices as virtual\n functions", "Date": "Thu, 19 May 2022 17:36:42 -0400", "Message-Id": "<20220519213642.2647946-7-ed.czeck@atomicrules.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220519213642.2647946-1-ed.czeck@atomicrules.com>", "References": "<20220502212232.1283-1-ed.czeck@atomicrules.com>\n <20220519213642.2647946-1-ed.czeck@atomicrules.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add capabilities field isvf to dev struct\nDisable configuration calls as required by vf\n\nSigned-off-by: Ed Czeck <ed.czeck@atomicrules.com>\n\n---\nv2: feature Arkville vf support int release notes\n---\n doc/guides/rel_notes/release_22_07.rst | 4 ++\n drivers/net/ark/ark_ethdev.c | 83 +++++++++++++++-----------\n drivers/net/ark/ark_global.h | 1 +\n 3 files changed, 53 insertions(+), 35 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst\nindex 42a5f2d990..a57c406163 100644\n--- a/doc/guides/rel_notes/release_22_07.rst\n+++ b/doc/guides/rel_notes/release_22_07.rst\n@@ -55,6 +55,10 @@ New Features\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n+* **Updated Atomic Rules' Arkville PMD.**\n+\n+ Added support for virtual functions and new Atomic Rules PCI device\n+ IDs ``0x101a, 0x101b, 0x101c``.\n \n Removed Items\n -------------\ndiff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c\nindex 7cf896f6f1..ec6c5a9525 100644\n--- a/drivers/net/ark/ark_ethdev.c\n+++ b/drivers/net/ark/ark_ethdev.c\n@@ -113,28 +113,29 @@ static const struct rte_pci_id pci_id_ark_map[] = {\n */\n struct ark_caps {\n \tbool rqpacing;\n+\tbool isvf;\n };\n struct ark_dev_caps {\n \tuint32_t device_id;\n \tstruct ark_caps caps;\n };\n-#define SET_DEV_CAPS(id, rqp) \\\n-\t{id, {.rqpacing = rqp} }\n+#define SET_DEV_CAPS(id, rqp, vf)\t\t\t\\\n+\t{id, {.rqpacing = rqp, .isvf = vf} }\n \n static const struct ark_dev_caps\n ark_device_caps[] = {\n-\t\t SET_DEV_CAPS(0x100d, true),\n-\t\t SET_DEV_CAPS(0x100e, true),\n-\t\t SET_DEV_CAPS(0x100f, true),\n-\t\t SET_DEV_CAPS(0x1010, false),\n-\t\t SET_DEV_CAPS(0x1017, true),\n-\t\t SET_DEV_CAPS(0x1018, true),\n-\t\t SET_DEV_CAPS(0x1019, true),\n-\t\t SET_DEV_CAPS(0x101a, true),\n-\t\t SET_DEV_CAPS(0x101b, true),\n-\t\t SET_DEV_CAPS(0x101c, false),\n-\t\t SET_DEV_CAPS(0x101e, false),\n-\t\t SET_DEV_CAPS(0x101f, false),\n+\t\t SET_DEV_CAPS(0x100d, true, false),\n+\t\t SET_DEV_CAPS(0x100e, true, false),\n+\t\t SET_DEV_CAPS(0x100f, true, false),\n+\t\t SET_DEV_CAPS(0x1010, false, false),\n+\t\t SET_DEV_CAPS(0x1017, true, false),\n+\t\t SET_DEV_CAPS(0x1018, true, false),\n+\t\t SET_DEV_CAPS(0x1019, true, false),\n+\t\t SET_DEV_CAPS(0x101a, true, false),\n+\t\t SET_DEV_CAPS(0x101b, true, false),\n+\t\t SET_DEV_CAPS(0x101c, true, true),\n+\t\t SET_DEV_CAPS(0x101e, false, false),\n+\t\t SET_DEV_CAPS(0x101f, false, false),\n \t\t {.device_id = 0,}\n };\n \n@@ -317,6 +318,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)\n \twhile (ark_device_caps[p].device_id != 0) {\n \t\tif (pci_dev->id.device_id == ark_device_caps[p].device_id) {\n \t\t\trqpacing = ark_device_caps[p].caps.rqpacing;\n+\t\t\tark->isvf = ark_device_caps[p].caps.isvf;\n \t\t\tbreak;\n \t\t}\n \t\tp++;\n@@ -498,20 +500,21 @@ ark_config_device(struct rte_eth_dev *dev)\n \t * Make sure that the packet director, generator and checker are in a\n \t * known state\n \t */\n-\tark->start_pg = 0;\n-\tark->pg_running = 0;\n-\tark->pg = ark_pktgen_init(ark->pktgen.v, 0, 1);\n-\tif (ark->pg == NULL)\n-\t\treturn -1;\n-\tark_pktgen_reset(ark->pg);\n-\tark->pc = ark_pktchkr_init(ark->pktchkr.v, 0, 1);\n-\tif (ark->pc == NULL)\n-\t\treturn -1;\n-\tark_pktchkr_stop(ark->pc);\n-\tark->pd = ark_pktdir_init(ark->pktdir.v);\n-\tif (ark->pd == NULL)\n-\t\treturn -1;\n-\n+\tif (!ark->isvf) {\n+\t\tark->start_pg = 0;\n+\t\tark->pg_running = 0;\n+\t\tark->pg = ark_pktgen_init(ark->pktgen.v, 0, 1);\n+\t\tif (ark->pg == NULL)\n+\t\t\treturn -1;\n+\t\tark_pktgen_reset(ark->pg);\n+\t\tark->pc = ark_pktchkr_init(ark->pktchkr.v, 0, 1);\n+\t\tif (ark->pc == NULL)\n+\t\t\treturn -1;\n+\t\tark_pktchkr_stop(ark->pc);\n+\t\tark->pd = ark_pktdir_init(ark->pktdir.v);\n+\t\tif (ark->pd == NULL)\n+\t\t\treturn -1;\n+\t}\n \t/* Verify HW */\n \tif (ark_udm_verify(ark->udm.v))\n \t\treturn -1;\n@@ -533,7 +536,7 @@ ark_config_device(struct rte_eth_dev *dev)\n \t\tmpu = RTE_PTR_ADD(mpu, ARK_MPU_QOFFSET);\n \t}\n \n-\tif (ark->rqpacing)\n+\tif (!ark->isvf && ark->rqpacing)\n \t\tark_rqp_stats_reset(ark->rqpacing);\n \n \treturn 0;\n@@ -551,8 +554,10 @@ eth_ark_dev_uninit(struct rte_eth_dev *dev)\n \t\tark->user_ext.dev_uninit(dev,\n \t\t\t ark->user_data[dev->data->port_id]);\n \n-\tark_pktgen_uninit(ark->pg);\n-\tark_pktchkr_uninit(ark->pc);\n+\tif (!ark->isvf) {\n+\t\tark_pktgen_uninit(ark->pg);\n+\t\tark_pktchkr_uninit(ark->pc);\n+\t}\n \n \treturn 0;\n }\n@@ -588,10 +593,10 @@ eth_ark_dev_start(struct rte_eth_dev *dev)\n \tdev->rx_pkt_burst = ð_ark_recv_pkts;\n \tdev->tx_pkt_burst = ð_ark_xmit_pkts;\n \n-\tif (ark->start_pg)\n+\tif (!ark->isvf && ark->start_pg)\n \t\tark_pktchkr_run(ark->pc);\n \n-\tif (ark->start_pg && !ark->pg_running) {\n+\tif (!ark->isvf && ark->start_pg && !ark->pg_running) {\n \t\tpthread_t thread;\n \n \t\t/* Delay packet generatpr start allow the hardware to be ready\n@@ -635,7 +640,7 @@ eth_ark_dev_stop(struct rte_eth_dev *dev)\n \t\t ark->user_data[dev->data->port_id]);\n \n \t/* Stop the packet generator */\n-\tif (ark->start_pg && ark->pg_running) {\n+\tif (!ark->isvf && ark->start_pg && ark->pg_running) {\n \t\tark_pktgen_pause(ark->pg);\n \t\tark->pg_running = 0;\n \t}\n@@ -661,7 +666,7 @@ eth_ark_dev_stop(struct rte_eth_dev *dev)\n \t\teth_ark_rx_dump_queue(dev, i, __func__);\n \n \t/* Stop the packet checker if it is running */\n-\tif (ark->start_pg) {\n+\tif (!ark->isvf && ark->start_pg) {\n \t\tark_pktchkr_dump_stats(ark->pc);\n \t\tark_pktchkr_stop(ark->pc);\n \t}\n@@ -690,6 +695,10 @@ eth_ark_dev_close(struct rte_eth_dev *dev)\n \tif (ark->rqpacing)\n \t\tark_rqp_dump(ark->rqpacing);\n \n+\t/* return to power-on state */\n+\tif (ark->pd)\n+\t\tark_pktdir_setup(ark->pd, ARK_PKT_DIR_INIT_VAL);\n+\n \tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n \t\teth_ark_tx_queue_release(dev->data->tx_queues[i]);\n \t\tdev->data->tx_queues[i] = 0;\n@@ -974,6 +983,10 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params)\n \t\tgoto free_kvlist;\n \t}\n \n+\tif (ark->isvf) {\n+\t\tret = 0;\n+\t\tgoto free_kvlist;\n+\t}\n \tARK_PMD_LOG(INFO, \"packet director set to 0x%x\\n\", ark->pkt_dir_v);\n \t/* Setup the packet director */\n \tark_pktdir_setup(ark->pd, ark->pkt_dir_v);\ndiff --git a/drivers/net/ark/ark_global.h b/drivers/net/ark/ark_global.h\nindex 3c3a712bc8..748db590c1 100644\n--- a/drivers/net/ark/ark_global.h\n+++ b/drivers/net/ark/ark_global.h\n@@ -113,6 +113,7 @@ struct ark_adapter {\n \tark_pkt_dir_t pd;\n \n \tint num_ports;\n+\tbool isvf;\n \n \t/* Packet generator/checker args */\n \tchar pkt_gen_args[ARK_MAX_ARG_LEN];\n", "prefixes": [ "v2", "7/7" ] }