Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111423/?format=api
{ "id": 111423, "url": "https://patches.dpdk.org/api/patches/111423/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220519122917.2334-12-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220519122917.2334-12-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220519122917.2334-12-humin29@huawei.com", "date": "2022-05-19T12:29:16", "name": "[11/12] net/hns3: fix a segfault from secondary process", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "4b8c66444e1297cfbeddaa84161c8d6c4838014b", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 3961, "url": "https://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220519122917.2334-12-humin29@huawei.com/mbox/", "series": [ { "id": 23037, "url": "https://patches.dpdk.org/api/series/23037/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=23037", "date": "2022-05-19T12:29:05", "name": "bugfix for hns3 PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/23037/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/111423/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/111423/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5B06CA0503;\n\tThu, 19 May 2022 14:31:35 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 09B5842B96;\n\tThu, 19 May 2022 14:30:40 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 5C2974281F\n for <dev@dpdk.org>; Thu, 19 May 2022 14:30:31 +0200 (CEST)", "from kwepemi500012.china.huawei.com (unknown [172.30.72.54])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4L3pyt2W1YzQkLf;\n Thu, 19 May 2022 20:27:34 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Thu, 19 May 2022 20:30:29 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>", "Subject": "[PATCH 11/12] net/hns3: fix a segfault from secondary process", "Date": "Thu, 19 May 2022 20:29:16 +0800", "Message-ID": "<20220519122917.2334-12-humin29@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20220519122917.2334-1-humin29@huawei.com>", "References": "<20220519122917.2334-1-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n kwepemi500012.china.huawei.com (7.221.188.12)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nIf a hns3 device in the secondary process is attached to do probing\noperation, 'rx_queues' and 'tx_queues' in dev->data are null in\neth_dev_fp_ops_setup when calling rte_eth_dev_probing_finish. The primary\nprocess calls dev_start to re-setup their fp_ops. But the secondary process\ncan't call dev_start and has no chance to do it. If the application sends\nand receives packets at this time, a segfault will occur. So this patch\nuses the MP communication of the PMD to update the fp_ops of the device in\nthe secondary process.\n\nFixes: 9e311d8f93b9 (\"net/hns3: fix Rx/Tx when fast path operation introduced\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_rxtx.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex 3f576fbf4b..0dc1d8cb60 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -4420,6 +4420,8 @@ hns3_eth_dev_fp_ops_config(const struct rte_eth_dev *dev)\n \tfpo[port_id].tx_pkt_prepare = dev->tx_pkt_prepare;\n \tfpo[port_id].rx_descriptor_status = dev->rx_descriptor_status;\n \tfpo[port_id].tx_descriptor_status = dev->tx_descriptor_status;\n+\tfpo[port_id].rxq.data = dev->data->rx_queues;\n+\tfpo[port_id].txq.data = dev->data->tx_queues;\n }\n \n void\n", "prefixes": [ "11/12" ] }