Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111180/?format=api
{ "id": 111180, "url": "https://patches.dpdk.org/api/patches/111180/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220516111041.63914-3-xuan.ding@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220516111041.63914-3-xuan.ding@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220516111041.63914-3-xuan.ding@intel.com", "date": "2022-05-16T11:10:38", "name": "[v8,2/5] vhost: prepare async for descriptor to mbuf refactoring", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "73351dab664c5beb3f625a38161f668e4f56c036", "submitter": { "id": 1401, "url": "https://patches.dpdk.org/api/people/1401/?format=api", "name": "Ding, Xuan", "email": "xuan.ding@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220516111041.63914-3-xuan.ding@intel.com/mbox/", "series": [ { "id": 22951, "url": "https://patches.dpdk.org/api/series/22951/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22951", "date": "2022-05-16T11:10:36", "name": "vhost: support async dequeue data path", "version": 8, "mbox": "https://patches.dpdk.org/series/22951/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/111180/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/111180/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3D716A00BE;\n\tMon, 16 May 2022 13:16:00 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4249942B53;\n\tMon, 16 May 2022 13:15:52 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id C27BC42686\n for <dev@dpdk.org>; Mon, 16 May 2022 13:15:48 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 May 2022 04:15:41 -0700", "from npg-dpdk-xuan-cbdma.sh.intel.com ([10.67.110.228])\n by orsmga007.jf.intel.com with ESMTP; 16 May 2022 04:15:39 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1652699748; x=1684235748;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=w56xqCmLDCgaivu1u3wG2gymPSOMMnT97D/z/E0XGJM=;\n b=AWgKyGcBmYxmEuidDMz0lPMCBE8Mjqp1T/7jkdKLu4f0U03/BDZW7iC2\n t9qKe/k2gowOObOP21S9nqN6Or64hhwT9xwqlrcvREggsF+SzS4zab432\n /NRQK7MvME+jpI6mYfOE7gdbWRQ/wnCANFZ/JrhsA3XiCzVPF13M2EIGX\n 9pQhl+dbWgRN2vbyf6V/nI8OaVvRR5SKyIChLgCmO12ZWYe2E6tFvtZTm\n 0TcP62mC8y5560BC1qqf0lh8LB64yEkRKnGZMk87mxNpyU9taALcC1eqp\n Wd0LHSCUDd65GPHHH2vN24qTjrHu6maFLZe7FfzCRorWYqotHocTdMfn3 g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10348\"; a=\"296063056\"", "E=Sophos;i=\"5.91,229,1647327600\"; d=\"scan'208\";a=\"296063056\"", "E=Sophos;i=\"5.91,229,1647327600\"; d=\"scan'208\";a=\"568272363\"" ], "X-ExtLoop1": "1", "From": "xuan.ding@intel.com", "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "dev@dpdk.org, jiayu.hu@intel.com, cheng1.jiang@intel.com,\n sunil.pai.g@intel.com, liangma@liangbit.com,\n Xuan Ding <xuan.ding@intel.com>", "Subject": "[PATCH v8 2/5] vhost: prepare async for descriptor to mbuf\n refactoring", "Date": "Mon, 16 May 2022 11:10:38 +0000", "Message-Id": "<20220516111041.63914-3-xuan.ding@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20220516111041.63914-1-xuan.ding@intel.com>", "References": "<20220407152546.38167-1-xuan.ding@intel.com>\n <20220516111041.63914-1-xuan.ding@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Xuan Ding <xuan.ding@intel.com>\n\nThis patch refactors vhost async enqueue path and dequeue path to use\nthe same function async_fill_seg() for preparing batch elements,\nwhich simplifies the code without performance degradation.\n\nSigned-off-by: Xuan Ding <xuan.ding@intel.com>\nTested-by: Yvonne Yang <yvonnex.yang@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/virtio_net.c | 22 ++++++++++++++--------\n 1 file changed, 14 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c\nindex d4c94d2a9b..a9e2dcd9ce 100644\n--- a/lib/vhost/virtio_net.c\n+++ b/lib/vhost/virtio_net.c\n@@ -997,13 +997,14 @@ async_iter_reset(struct vhost_async *async)\n }\n \n static __rte_always_inline int\n-async_mbuf_to_desc_seg(struct virtio_net *dev, struct vhost_virtqueue *vq,\n+async_fill_seg(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\tstruct rte_mbuf *m, uint32_t mbuf_offset,\n-\t\tuint64_t buf_iova, uint32_t cpy_len)\n+\t\tuint64_t buf_iova, uint32_t cpy_len, bool to_desc)\n {\n \tstruct vhost_async *async = vq->async;\n \tuint64_t mapped_len;\n \tuint32_t buf_offset = 0;\n+\tvoid *src, *dst;\n \tvoid *host_iova;\n \n \twhile (cpy_len) {\n@@ -1015,10 +1016,15 @@ async_mbuf_to_desc_seg(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t\treturn -1;\n \t\t}\n \n-\t\tif (unlikely(async_iter_add_iovec(dev, async,\n-\t\t\t\t\t\t(void *)(uintptr_t)rte_pktmbuf_iova_offset(m,\n-\t\t\t\t\t\t\tmbuf_offset),\n-\t\t\t\t\t\thost_iova, (size_t)mapped_len)))\n+\t\tif (to_desc) {\n+\t\t\tsrc = (void *)(uintptr_t)rte_pktmbuf_iova_offset(m, mbuf_offset);\n+\t\t\tdst = host_iova;\n+\t\t} else {\n+\t\t\tsrc = host_iova;\n+\t\t\tdst = (void *)(uintptr_t)rte_pktmbuf_iova_offset(m, mbuf_offset);\n+\t\t}\n+\n+\t\tif (unlikely(async_iter_add_iovec(dev, async, src, dst, (size_t)mapped_len)))\n \t\t\treturn -1;\n \n \t\tcpy_len -= (uint32_t)mapped_len;\n@@ -1167,8 +1173,8 @@ mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\tcpy_len = RTE_MIN(buf_avail, mbuf_avail);\n \n \t\tif (is_async) {\n-\t\t\tif (async_mbuf_to_desc_seg(dev, vq, m, mbuf_offset,\n-\t\t\t\t\t\tbuf_iova + buf_offset, cpy_len) < 0)\n+\t\t\tif (async_fill_seg(dev, vq, m, mbuf_offset,\n+\t\t\t\t\t buf_iova + buf_offset, cpy_len, true) < 0)\n \t\t\t\tgoto error;\n \t\t} else {\n \t\t\tsync_fill_seg(dev, vq, m, mbuf_offset,\n", "prefixes": [ "v8", "2/5" ] }