Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111118/?format=api
{ "id": 111118, "url": "https://patches.dpdk.org/api/patches/111118/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220513072049.149333-1-wenxuanx.wu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220513072049.149333-1-wenxuanx.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220513072049.149333-1-wenxuanx.wu@intel.com", "date": "2022-05-13T07:20:49", "name": "[v3] net/i40e: fix max frame size config at port level", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "be28d197c8c01a9ceed11f1838b92adab24ed3cf", "submitter": { "id": 2515, "url": "https://patches.dpdk.org/api/people/2515/?format=api", "name": "Wu, WenxuanX", "email": "wenxuanx.wu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220513072049.149333-1-wenxuanx.wu@intel.com/mbox/", "series": [ { "id": 22924, "url": "https://patches.dpdk.org/api/series/22924/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22924", "date": "2022-05-13T07:20:49", "name": "[v3] net/i40e: fix max frame size config at port level", "version": 3, "mbox": "https://patches.dpdk.org/series/22924/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/111118/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/111118/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F3A6AA00C3;\n\tFri, 13 May 2022 09:43:57 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A21AE410EE;\n\tFri, 13 May 2022 09:43:57 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 6D53540DDE;\n Fri, 13 May 2022 09:43:55 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 May 2022 00:43:54 -0700", "from unknown (HELO localhost.localdomain) ([10.239.251.3])\n by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 May 2022 00:43:51 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1652427835; x=1683963835;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=p2eHNR22qdqXPG5vgO8OxuBuJRPFVfKEE6MY+1m1lGs=;\n b=L3wVmxf0+Jixxw1tDLDRUv6qnVPgdNei1ISgVtBTPYFYN6POaljnsgjk\n yI+lvgr+ND8uFjnbyMoV2TAkB7jR6QUFuirFvflrMThpnr5ELNU44BTvH\n kGe4lPcfK/1mhm6bWafSkpI/J2+8qijAllxW2eSU+WJjvfNreDEnfAgEq\n 3EaWPJRJcQm4V1e3MsBLjkSjNYM//9wQFBCs6RgsDYaqLsg/XZtjFp48z\n E09Bz6MPmpjmlUR3rZZEI24euMa6jWU1rRv7ih1qGLMzWBRMgng+06JBA\n OPd9rHkfjfG9HA9EQl/GVaD8Zaw8mHovULLjlta5yy2DeEckAIiodW1IW Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10345\"; a=\"270179336\"", "E=Sophos;i=\"5.91,221,1647327600\"; d=\"scan'208\";a=\"270179336\"", "E=Sophos;i=\"5.91,221,1647327600\"; d=\"scan'208\";a=\"712298412\"" ], "From": "wenxuanx.wu@intel.com", "To": "beilei.xing@intel.com,\n\tyuying.zhang@intel.com,\n\tdev@dpdk.org", "Cc": "wenxuanx.wu@intel.com,\n\tyidingx.zhou@intel.com,\n\tstable@dpdk.org", "Subject": "[PATCH v3] net/i40e: fix max frame size config at port level", "Date": "Fri, 13 May 2022 07:20:49 +0000", "Message-Id": "<20220513072049.149333-1-wenxuanx.wu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220428111224.57705-1-wenxuanx.wu@intel.com>", "References": "<20220428111224.57705-1-wenxuanx.wu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Wenxuan Wu <wenxuanx.wu@intel.com>\n\nPreviously, max frame size can only be set when link is up, and the wait\ntime is 1 sec. Startup time of 10G_BASET longer than 1s would result in\nfailure.\n\nAcctually, max frame size of media type I40E_MEDIA_TYPE_BASET can be set\nregardless of link status.\n\nThis patch omitted the link status check of 10G_MEDIA_TYPE_BASET.\n\nFixes: a4ba77367923 (\"net/i40e: enable maximum frame size at port level\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 24 ++++++++++++++----------\n 1 file changed, 14 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 755786dc10..12d3cd9b0c 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -12102,17 +12102,21 @@ i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size)\n \tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tuint32_t rep_cnt = MAX_REPEAT_TIME;\n \tstruct rte_eth_link link;\n-\tenum i40e_status_code status;\n-\n-\tdo {\n-\t\tupdate_link_reg(hw, &link);\n-\t\tif (link.link_status)\n-\t\t\tbreak;\n-\n-\t\trte_delay_ms(CHECK_INTERVAL);\n-\t} while (--rep_cnt);\n+\tenum i40e_status_code status = I40E_ERR_DEVICE_NOT_SUPPORTED;\n+\tbool can_be_set = true;\n+\n+\t/* I40E_MEDIA_TYPE_BASET link up can be ignored */\n+\tif (hw->phy.media_type != I40E_MEDIA_TYPE_BASET) {\n+\t\tdo {\n+\t\t\tupdate_link_reg(hw, &link);\n+\t\t\tif (link.link_status)\n+\t\t\t\tbreak;\n+\t\t\trte_delay_ms(CHECK_INTERVAL);\n+\t\t} while (--rep_cnt);\n+\t\tcan_be_set = link.link_status != 0;\n+\t}\n \n-\tif (link.link_status) {\n+\tif (can_be_set) {\n \t\tstatus = i40e_aq_set_mac_config(hw, size, TRUE, 0, false, NULL);\n \t\tif (status != I40E_SUCCESS)\n \t\t\tPMD_DRV_LOG(ERR, \"Failed to set max frame size at port level\");\n", "prefixes": [ "v3" ] }