Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110691/?format=api
{ "id": 110691, "url": "https://patches.dpdk.org/api/patches/110691/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220505102729.821075-4-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220505102729.821075-4-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220505102729.821075-4-maxime.coquelin@redhat.com", "date": "2022-05-05T10:27:26", "name": "[3/6] net/vhost: enable compliant offloading mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7ea30d67d4cd787404ed15e14045d1df606ab029", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220505102729.821075-4-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 22794, "url": "https://patches.dpdk.org/api/series/22794/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22794", "date": "2022-05-05T10:27:23", "name": "Vhost checksum offload improvements", "version": 1, "mbox": "https://patches.dpdk.org/series/22794/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/110691/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/110691/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CD38BA04FF;\n\tThu, 5 May 2022 12:27:58 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DBAC942820;\n\tThu, 5 May 2022 12:27:43 +0200 (CEST)", "from us-smtp-delivery-74.mimecast.com\n (us-smtp-delivery-74.mimecast.com [170.10.129.74])\n by mails.dpdk.org (Postfix) with ESMTP id CF32042837\n for <dev@dpdk.org>; Thu, 5 May 2022 12:27:42 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-561-kR3rGa7UNpyQGhONk9kQJQ-1; Thu, 05 May 2022 06:27:39 -0400", "from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com\n [10.11.54.10])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1D533299E743;\n Thu, 5 May 2022 10:27:39 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.18])\n by smtp.corp.redhat.com (Postfix) with ESMTP id CF6FF416157;\n Thu, 5 May 2022 10:27:37 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1651746462;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=eJfPMPP7g0kdrT1xP42yckeDoqZw/NkGadDIN4XmT8o=;\n b=avBDWwskqrpklCXAUykZ666EELp2KWr6IqqwodEiT1Q+wPaFd7lQGRd6v4PRuljmRZYpqD\n gckJvqpUN/3iQlX9ONRrXnilPic2E7TnzEv5GZ63rJ61iBIi4wTfU/qRYWM6APmhkYBz9/\n 2fDwAucTq+7aVDT2nYacXbBSv7WpO/8=", "X-MC-Unique": "kR3rGa7UNpyQGhONk9kQJQ-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, jasowang@redhat.com, chenbo.xia@intel.com,\n david.marchand@redhat.com, olivier.matz@6wind.com", "Cc": "stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH 3/6] net/vhost: enable compliant offloading mode", "Date": "Thu, 5 May 2022 12:27:26 +0200", "Message-Id": "<20220505102729.821075-4-maxime.coquelin@redhat.com>", "In-Reply-To": "<20220505102729.821075-1-maxime.coquelin@redhat.com>", "References": "<20220505102729.821075-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.85 on 10.11.54.10", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch enables the compliant offloading flags mode by\ndefault, which prevents the Rx path to set Tx offload flags,\nwhich is illegal. A new legacy-ol-flags devarg is introduced\nto enable the legacy behaviour.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n doc/guides/nics/vhost.rst | 6 ++++++\n drivers/net/vhost/rte_eth_vhost.c | 19 ++++++++++++++++---\n 2 files changed, 22 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/nics/vhost.rst b/doc/guides/nics/vhost.rst\nindex ee802ec4a8..d7c0e2ade8 100644\n--- a/doc/guides/nics/vhost.rst\n+++ b/doc/guides/nics/vhost.rst\n@@ -64,6 +64,12 @@ The user can specify below arguments in `--vdev` option.\n It is used to enable external buffer support in vhost library.\n (Default: 0 (disabled))\n \n+#. ``legacy-ol-flags``:\n+\n+ It is used to restore legacy behavior for offloading that was not\n+ compliant with offloading API.\n+ (Default: 0 (disabled))\n+\n Vhost PMD event handling\n ------------------------\n \ndiff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex 070f0e6dfd..0a2e8d9b29 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -31,9 +31,10 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM};\n #define ETH_VHOST_CLIENT_ARG\t\t\"client\"\n #define ETH_VHOST_IOMMU_SUPPORT\t\t\"iommu-support\"\n #define ETH_VHOST_POSTCOPY_SUPPORT\t\"postcopy-support\"\n-#define ETH_VHOST_VIRTIO_NET_F_HOST_TSO \"tso\"\n-#define ETH_VHOST_LINEAR_BUF \"linear-buffer\"\n-#define ETH_VHOST_EXT_BUF \"ext-buffer\"\n+#define ETH_VHOST_VIRTIO_NET_F_HOST_TSO\t\"tso\"\n+#define ETH_VHOST_LINEAR_BUF\t\t\"linear-buffer\"\n+#define ETH_VHOST_EXT_BUF\t\t\"ext-buffer\"\n+#define ETH_VHOST_LEGACY_OL_FLAGS\t\"legacy-ol-flags\"\n #define VHOST_MAX_PKT_BURST 32\n \n static const char *valid_arguments[] = {\n@@ -1563,6 +1564,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)\n \tint tso = 0;\n \tint linear_buf = 0;\n \tint ext_buf = 0;\n+\tint legacy_ol_flags = 0;\n \tstruct rte_eth_dev *eth_dev;\n \tconst char *name = rte_vdev_device_name(dev);\n \n@@ -1672,6 +1674,17 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)\n \t\t\tflags |= RTE_VHOST_USER_EXTBUF_SUPPORT;\n \t}\n \n+\tif (rte_kvargs_count(kvlist, ETH_VHOST_LEGACY_OL_FLAGS) == 1) {\n+\t\tret = rte_kvargs_process(kvlist,\n+\t\t\t\tETH_VHOST_LEGACY_OL_FLAGS,\n+\t\t\t\t&open_int, &legacy_ol_flags);\n+\t\tif (ret < 0)\n+\t\t\tgoto out_free;\n+\t}\n+\n+\tif (legacy_ol_flags == 0)\n+\t\tflags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;\n+\n \tif (dev->device.numa_node == SOCKET_ID_ANY)\n \t\tdev->device.numa_node = rte_socket_id();\n \n", "prefixes": [ "3/6" ] }