Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110636/?format=api
{ "id": 110636, "url": "https://patches.dpdk.org/api/patches/110636/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220505134008.2865-1-wenwux.ma@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220505134008.2865-1-wenwux.ma@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220505134008.2865-1-wenwux.ma@intel.com", "date": "2022-05-05T13:40:08", "name": "vhost: fix deadlock when handling user messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c17014ad384890fbce315ae3ab3498f3b7a16574", "submitter": { "id": 2163, "url": "https://patches.dpdk.org/api/people/2163/?format=api", "name": "Ma, WenwuX", "email": "wenwux.ma@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220505134008.2865-1-wenwux.ma@intel.com/mbox/", "series": [ { "id": 22780, "url": "https://patches.dpdk.org/api/series/22780/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22780", "date": "2022-05-05T13:40:08", "name": "vhost: fix deadlock when handling user messages", "version": 1, "mbox": "https://patches.dpdk.org/series/22780/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/110636/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/110636/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 864FBA00BE;\n\tThu, 5 May 2022 07:42:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7099440C35;\n\tThu, 5 May 2022 07:42:12 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 097C440042\n for <dev@dpdk.org>; Thu, 5 May 2022 07:42:10 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 May 2022 22:42:10 -0700", "from unknown (HELO localhost.localdomain) ([10.239.251.209])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 May 2022 22:42:07 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1651729331; x=1683265331;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=g6TEkmVat+tF5vti7/gDyQ9qt+1xfU05wBJ6UbycZ08=;\n b=P68A9qd3MfHlBGZE0r9AdQHvwMUHTH6MgHwnOALQeKBgYRTClFJJD96b\n 5lFzVYzKVVjOUmk41XXfR5bPFfb2Fn4B0fisDIOeQGSnCxTDMDR+WbPOj\n Gviv68RlgY7Sob1pAl6a944xxbCeOWQd9FW69kYftWwdZbyalEmxduyXf\n y5OWYYaDiFWliiTIH4FOsFbxt+rnxeoBMbVCjTH5K0jALjqGKIcB+/qPD\n dncUzs3viYcefNr5ZI4+Tttu9vmxQB9E7w5WnSpleZpZkwT7DL61P25fK\n r9bRZ67yuP7OFUz3qoW/795SuAQXis7aC6A1S4eSalweeKzWLIKkAG5lk w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10337\"; a=\"267888242\"", "E=Sophos;i=\"5.91,200,1647327600\"; d=\"scan'208\";a=\"267888242\"", "E=Sophos;i=\"5.91,200,1647327600\"; d=\"scan'208\";a=\"585143317\"" ], "From": "Wenwu Ma <wenwux.ma@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com,\n\tdev@dpdk.org", "Cc": "jiayu.hu@intel.com, yinan.wang@intel.com, xingguang.he@intel.com,\n Wenwu Ma <wenwux.ma@intel.com>", "Subject": "[PATCH] vhost: fix deadlock when handling user messages", "Date": "Thu, 5 May 2022 13:40:08 +0000", "Message-Id": "<20220505134008.2865-1-wenwux.ma@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In vhost_user_msg_handler(), if vhost message handling\nfailed, we should check whether the queue is locked and\nrelease the lock before returning. Or, it will cause a\ndeadlock later.\n\nSigned-off-by: Wenwu Ma <wenwux.ma@intel.com>\n---\n lib/vhost/vhost_user.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 1d390677fa..80a5df6e9d 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -3113,6 +3113,8 @@ vhost_user_msg_handler(int vid, int fd)\n \t\tsend_vhost_reply(dev, fd, &ctx);\n \t} else if (ret == RTE_VHOST_MSG_RESULT_ERR) {\n \t\tVHOST_LOG_CONFIG(ERR, \"(%s) vhost message handling failed.\\n\", dev->ifname);\n+\t\tif (unlock_required)\n+\t\t\tvhost_user_unlock_all_queue_pairs(dev);\n \t\treturn -1;\n \t}\n \n", "prefixes": [] }