Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110431/?format=api
{ "id": 110431, "url": "https://patches.dpdk.org/api/patches/110431/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220428114733.1419957-11-g.singh@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220428114733.1419957-11-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220428114733.1419957-11-g.singh@nxp.com", "date": "2022-04-28T11:47:29", "name": "[v2,10/14] crypto/dpaa2_sec: fix crypto op pointer value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f5d523b04323de7fd6d1aedb35006c7b794af667", "submitter": { "id": 1068, "url": "https://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220428114733.1419957-11-g.singh@nxp.com/mbox/", "series": [ { "id": 22712, "url": "https://patches.dpdk.org/api/series/22712/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22712", "date": "2022-04-28T11:47:19", "name": "DPAA1 and DPAA2 crypto drivers changes", "version": 2, "mbox": "https://patches.dpdk.org/series/22712/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/110431/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/110431/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 21C28A034C;\n\tThu, 28 Apr 2022 13:49:16 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5179442865;\n\tThu, 28 Apr 2022 13:48:20 +0200 (CEST)", "from EUR05-DB8-obe.outbound.protection.outlook.com\n (mail-db8eur05on2062.outbound.protection.outlook.com [40.107.20.62])\n by mails.dpdk.org (Postfix) with ESMTP id BC7CF4284F;\n Thu, 28 Apr 2022 13:48:18 +0200 (CEST)", "from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14)\n by AM9PR04MB8162.eurprd04.prod.outlook.com (2603:10a6:20b:3e3::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 28 Apr\n 2022 11:48:18 +0000", "from AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::8cf1:93b:c340:3be2]) by AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::8cf1:93b:c340:3be2%9]) with mapi id 15.20.5206.014; Thu, 28 Apr 2022\n 11:48:17 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=EdX8sg2iPFFEECRSQhmsW4Xfmsmz64byhsASXXNMLP3plG4vd7WdL/J0pc9o+kHf4yxuvQV/Z0NowkTsYsh7uTuZAQ3VxeU1e17nitX2IbiaNS8P4xOHGU59w2Ti3v9zBnBKGO1cEqbvqqbb1pwWhQat7gAxsfWyX/arEsvcaqw9YwcGFk2ovGWdjlutHKjRYMF2ZjI40wnoHgCY5nlkrUet3ZVDCP3WLErEyYjmitSqhnbBgXsAXTZmQkXIcSagCfmWcAp91YaNABO150jSHxy2H6VXFvU42/DMVh3DjAERQNn/T9zmQDdDNAD99ArMFtVDuK4plR55Ufkt5PK8hQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=qE5wOHwxpQ030v6UJ4HYVk+HOhLA8kytV1k9n9KpvtU=;\n b=K4pvq8TjGELPaKrr/NqwH0SxuNZfuT/92fMP2HOWwpPgkbf7M++TNiMZ7z5a0udfuf+kkiBb16kR8GMrF43+vvfql4u8VGtcbIzqyjiQjpvEjxgemNVk/6VOGJrbzlSow9wgGhQvGGaZYWclmetvstSND+UpDohxFAvMqIG02PG21XSbDsnY2CBUWWqWzRcOE7/39Z0nU3ejGU5qpZPUbqSktObAi7aiejTQS/8IH1Ez1a0SGgDxh6jndGszxxRZQGnxZXUgdYCDm+pPh4CqGjXGN+PtOqE7LpooZ46R/O+OfHUVpLECGbXp1QGQGSMoXF6XBIWz45Q0T0mHcY3Scw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=qE5wOHwxpQ030v6UJ4HYVk+HOhLA8kytV1k9n9KpvtU=;\n b=GQ26+QNj3T2rXYcNojM7XkzBQnMOSL9yGOHi9oMULmxU0VSn2jw/5iPw6M8ehyU1vfc7iLiSDVwSh2fdeSdeS6a1plzjVp6W1G+0JigjHYPND1cd00MWbNqG5X6JlD0s3NEnfffId6R5MRVmkbBs+6As8qEQj4iwo7CJcn78EUc=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;", "From": "Gagandeep Singh <g.singh@nxp.com>", "To": "gakhil@marvell.com,\n\tdev@dpdk.org", "Cc": "Gagandeep Singh <g.singh@nxp.com>,\n\tstable@dpdk.org", "Subject": "[PATCH v2 10/14] crypto/dpaa2_sec: fix crypto op pointer value", "Date": "Thu, 28 Apr 2022 17:17:29 +0530", "Message-Id": "<20220428114733.1419957-11-g.singh@nxp.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220428114733.1419957-1-g.singh@nxp.com>", "References": "<20220422035100.3180870-1-g.singh@nxp.com>\n <20220428114733.1419957-1-g.singh@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SI2PR02CA0002.apcprd02.prod.outlook.com\n (2603:1096:4:194::22) To AS8PR04MB8198.eurprd04.prod.outlook.com\n (2603:10a6:20b:3b0::14)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "c1a7995e-7a61-4d26-5885-08da290cfc61", "X-MS-TrafficTypeDiagnostic": "AM9PR04MB8162:EE_", "X-Microsoft-Antispam-PRVS": "\n <AM9PR04MB816296E5BA5D7A9D7AF147B7E1FD9@AM9PR04MB8162.eurprd04.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n DPFVjopESsrnwo6gXFI55twlzfkbMb3xq98ynMTSKd9Y1tcF4Pllnb7zPmzIYO+RCFqJDG0ZS1+9mGLqAjaYUHLyTKCqWGdldhC3N1b1TlorFaFYThSXTHSVwLZToTf0sIeaAPb2NW83S4Wp1GfWFIC3+Z1Dr3cqPdcLQBl+o6F1tJDTPZwbd/59nzyzPZQtoq+f6gZEfb5ks4d/26lNa279A8246YySDmGy8qTp7oJ+87m8ZShwaTBVhVzGiao9euACsjTu9WzyHUU7GcUsX+BocRl3X6rq/v9L0ua8GwrwnBRCtS5bn+uL5XE6cWu8uG+oakBjwHiTcbf6POht9T511Sxta95GS38GnwZ8RVNPaz82NSYCerkfD6CqkU9rHXdmiPYN1gX3WVBVi+cqslTfKp24w6JKk0ETxrzqv+CDbl/Co+/6NUrnSeoRdqKAjvEYpklb0JHuxXayko6nJ+b+TEEDg38GbWegkVErDQVRyud0zm1AjA+gSOlb0UGlq0tHUgbvanLmLyeql2kct+TpwjQ9LQG88aBzlnzB7xaBrjJ7zYgm+YkAP+9L0lyVBhPzWG+71eTMvFRpY1LE+6TVNqRwzzXFfzz6OsuaRYGo/yD79cNHRbfFV99PYRIcLggYglymPJbDYUiCgLpxJUnOrQi4Od6YRKkPwGbKw/5J9XBfiQH0+DufiOYANMseNO/ctT2QIt2zXgHnXsl4dhCZaXYdJ1bgnapJ0WCATTk84XkaqKAGsCPbPE2ktzA9", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230001)(4636009)(366004)(6486002)(508600001)(8676002)(4326008)(66476007)(66556008)(86362001)(66946007)(316002)(55236004)(2906002)(38100700002)(6512007)(38350700002)(26005)(6666004)(6506007)(52116002)(5660300002)(2616005)(1076003)(186003)(83380400001)(8936002)(36756003);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n HhFvAVhYPLtugJDqn6zPs3sSWRr3TW4qek01EaQGbT18pqxPh/BeqjXZBhp8OLAFn08e13f0pR6z7ZztL01NXWItv6XwJ/ox919SsgR8dnpe/cozV6eGZre2KlrI2tPp0NG0ykg7g9+piP1plgjCglVOV12MlgKcxUpga7WmJr5I+A45UjULxzBT5mS75CpQrf0rDNCVOxW0PziGb02sjkJhM2OWKV6LSGSuPT0g4e1UH2J23TmD6a5MlydpqJWny20M348TYhmW9b6BnmhyTkwRwDViLlJxRO4kpcdfLzi8AH7eu+cZRs6v/QnwNntCH4Tbtar8jdTuAF0jcP32vNlqcWVID4VMWIvetSdv3wFomCYhmE9C/AjPOaYejsyOxIfKhwXYdTCzwkk+zlxRmYuBXFM8x1k+QERVj4M55NNBoPz0BOLGmt/5kdURj9anYXGREpYT/plWuE3aoQWOdDVrEYXf/e23N0rDpB1yHJiKSetr9Y0FwrpALPQa6c6DoBBPwJvoH3SGv5gyK2xdYk0XLfZGESMeP3FkfoLKVsCB/LAFEfCmPJQ5qLaMiAo5k9GNmGUsu8myyg46p3romYi8K69wZURI7rm9g0TFa3qXq3EN1k7R0huN1OFUdK4SL772iU24qxdzwswZ6k6WcMXnYqoeHackHAmvIS+DC7gCTM+GjBxpgehckRUCdbyxc4QlXPtI64BUuwIM4cHLRIm6CchfMIQY8qne2AtvWW1LprmR1SnCmIsLfsvW/dMQ+KTiRFYieQpiRR3vsk7u3g5GsgoSR8yJkf5s9urDMngeRIoL0HUGWoS3Wmvx0vkKsA+iCy4n7DqDAOMzcYhGsqLKP9rz/3nE4s4nkSeXdOfx7DihykLfvA8B7LFPPuRIMRKekNx6BlDxltQ4nm0HUegAsRQVVhdU5if7cX+ZU3SrpibzjhYdzRbu4c4wd4uq6/YlVrTljNPbDRnaoogEhKwDJxoxoPjBPkD33gtZDHFsB4cJAJ72lwGMp3tlaPWlprQXKQZSNw6q0uxZgOFMWcjvCh8/aWoUmAEsTCHO94i37fzwCJbEMBmsCReXuR6O8YP/5G234UfyC4+kmePfb6b8S7J90kPYM46rHxOAKo24LYiYXEnrL5PdIiqfW6xMAaBwXRfwbI2p1wOLmovCjpwqss7YZnvOK96Ybtk6R5r1tsoDNTVCB4el+McH7TROQbyf1gdHwWfAbyieWtFcF0PN5TdTiHtUU19Ak7ngmSeqtL8rOMYbMmwHMEOtsbkpLSyVIjLt0O0xRed7HnLidF9NWfamJP+QspTTc2DShBmPNDakjRFmVJ0Eul8CiHSb3jGJq0rEw5b/0oWegxjoqtmsFIl9013pIDbR+/UtEwKjPqn45wOytg1imOpLCtSNfcnmzBKnexdVivDjKBsj1DhFqMohmCh+o4q9BxKauaDS4CH9lDGjl/YH9szbrP6GSFuke0FMGDM0rtX8YHm/RtRE+DOs/bBMuSC+BGlT0tnkg+G6P/qxf03ivMiQ9VgXnZE4pqX9ZPemjSS1cFx20iFsoTRbBm61yA77Qj9mFhyeiw4qTBZfsfmBlOgFDMxaahQ8IYtVfeCJtHSD8kIOntzisX/l/ez0oRGMZRaNLA5t07da+iqGfj/8KvHmfMiFuEXHagD/jC9qirHdSwXGN0WOmUVaG46NbjeZvXTR6wlUKbmY6YboBUDCE5EA8WEewSqV6UTnR7anjcGQ/lgx4A==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n c1a7995e-7a61-4d26-5885-08da290cfc61", "X-MS-Exchange-CrossTenant-AuthSource": "AS8PR04MB8198.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Apr 2022 11:48:17.9443 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n r+3dkEUiX8syamUaIFhcqUob3G/XDmcqISK0mbPqxsREyAhzNQBrnW5FdvRhdtHE", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM9PR04MB8162", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Driver is filling the crypto_op variable with an invalid value\nfor atomic and ordered events which can results into\nsegmentation fault.\n\nThis patch assigning the correct crypto_op and event buffer\npointers by extracting from FD.\n\nFixes: a77db24643b7 (\"crypto/dpaa2_sec: support atomic queues\")\nFixes: 4562de326d30 (\"crypto/dpaa2_sec: support ordered queue\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex 86c8df241b..9f2b384af9 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -4019,7 +4019,7 @@ dpaa2_sec_process_atomic_event(struct qbman_swp *swp __rte_unused,\n {\n \tuint8_t dqrr_index;\n \tstruct dpaa2_sec_qp *qp;\n-\tstruct rte_crypto_op *crypto_op = (struct rte_crypto_op *)ev->event_ptr;\n+\tstruct rte_crypto_op *crypto_op;\n \t/* Prefetching mbuf */\n \trte_prefetch0((void *)(size_t)(DPAA2_GET_FD_ADDR(fd)-\n \t\trte_dpaa2_bpid_info[DPAA2_GET_FD_BPID(fd)].meta_data_size));\n@@ -4036,12 +4036,13 @@ dpaa2_sec_process_atomic_event(struct qbman_swp *swp __rte_unused,\n \tev->queue_id = rxq->ev.queue_id;\n \tev->priority = rxq->ev.priority;\n \n-\tev->event_ptr = sec_fd_to_mbuf(fd, qp);\n+\tcrypto_op = sec_fd_to_mbuf(fd, qp);\n \tdqrr_index = qbman_get_dqrr_idx(dq);\n \t*dpaa2_seqn(crypto_op->sym->m_src) = QBMAN_ENQUEUE_FLAG_DCA | dqrr_index;\n \tDPAA2_PER_LCORE_DQRR_SIZE++;\n \tDPAA2_PER_LCORE_DQRR_HELD |= 1 << dqrr_index;\n \tDPAA2_PER_LCORE_DQRR_MBUF(dqrr_index) = crypto_op->sym->m_src;\n+\tev->event_ptr = crypto_op;\n }\n \n static void __rte_hot\n@@ -4051,7 +4052,7 @@ dpaa2_sec_process_ordered_event(struct qbman_swp *swp,\n \t\t\t\tstruct dpaa2_queue *rxq,\n \t\t\t\tstruct rte_event *ev)\n {\n-\tstruct rte_crypto_op *crypto_op = (struct rte_crypto_op *)ev->event_ptr;\n+\tstruct rte_crypto_op *crypto_op;\n \tstruct dpaa2_sec_qp *qp;\n \n \t/* Prefetching mbuf */\n@@ -4069,7 +4070,7 @@ dpaa2_sec_process_ordered_event(struct qbman_swp *swp,\n \tev->sched_type = rxq->ev.sched_type;\n \tev->queue_id = rxq->ev.queue_id;\n \tev->priority = rxq->ev.priority;\n-\tev->event_ptr = sec_fd_to_mbuf(fd, qp);\n+\tcrypto_op = sec_fd_to_mbuf(fd, qp);\n \n \t*dpaa2_seqn(crypto_op->sym->m_src) = DPAA2_ENQUEUE_FLAG_ORP;\n \t*dpaa2_seqn(crypto_op->sym->m_src) |= qbman_result_DQ_odpid(dq) <<\n@@ -4078,6 +4079,7 @@ dpaa2_sec_process_ordered_event(struct qbman_swp *swp,\n \t\tDPAA2_EQCR_SEQNUM_SHIFT;\n \n \tqbman_swp_dqrr_consume(swp, dq);\n+\tev->event_ptr = crypto_op;\n }\n \n int\n", "prefixes": [ "v2", "10/14" ] }