Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/11041/?format=api
https://patches.dpdk.org/api/patches/11041/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1457015260-3041-4-git-send-email-adrien.mazarguil@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1457015260-3041-4-git-send-email-adrien.mazarguil@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1457015260-3041-4-git-send-email-adrien.mazarguil@6wind.com", "date": "2016-03-03T14:27:36", "name": "[dpdk-dev,v2,3/7] mlx5: manage all special flow types at once", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7751868d75511ec9cfc23785b6c71f7ed4f1f711", "submitter": { "id": 165, "url": "https://patches.dpdk.org/api/people/165/?format=api", "name": "Adrien Mazarguil", "email": "adrien.mazarguil@6wind.com" }, "delegate": { "id": 10, "url": "https://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1457015260-3041-4-git-send-email-adrien.mazarguil@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/11041/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/11041/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2567C2C2E;\n\tThu, 3 Mar 2016 15:28:02 +0100 (CET)", "from mail-wm0-f46.google.com (mail-wm0-f46.google.com\n\t[74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 55E232C2D\n\tfor <dev@dpdk.org>; Thu, 3 Mar 2016 15:28:00 +0100 (CET)", "by mail-wm0-f46.google.com with SMTP id p65so33869551wmp.0\n\tfor <dev@dpdk.org>; Thu, 03 Mar 2016 06:28:00 -0800 (PST)", "from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tfv6sm40999504wjc.12.2016.03.03.06.27.58\n\tfor <dev@dpdk.org> (version=TLSv1/SSLv3 cipher=OTHER);\n\tThu, 03 Mar 2016 06:27:59 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=cD0IJsm/LUqEGtfHVtcQ2WlcF5criDyfuE2CypNMyaQ=;\n\tb=HBLUhG6hX1HoMf8MHs49NAL2dTi9zdID+hunMkO1Jdg9Be/sIXUmH3voingLDzJZEs\n\tryKXCok9uWhdElzF2b2oujQs80RvOwMTtCxQpT8B4MRzsc71djzOLxMVKHPGcCoTehd/\n\t6FfwCgut17bJMeTTwPi4nhjrMxQGf/rPU3G8RHbaIHQb+8NxgHTGLZQ9paroUOTvYuuB\n\tv6n3vYIqwMg6zRWI3dtl0bVCNoTHPCeILVytno5cWfEh4Xqq8WfVhSpgSJ9yTAPntPR2\n\t5OvO8u3P14Mc4aUaXBNGCK+q7ngoeO6Z6/9XslELCK4JXAq4o3V+ws3JbshNcXZepURt\n\tG2Vw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=cD0IJsm/LUqEGtfHVtcQ2WlcF5criDyfuE2CypNMyaQ=;\n\tb=Af3GBmE/Vt2O3abTnBv+JBn9BZ7ADW/SgdYVZR3s7YxXlvxPhVdM2hzdzzTH73yq1m\n\tmoXdfRV/AiY8n1l6KN+QCR+i6bTPbZq4ObLDM/mIKPFfoQ8Y7rB5jjo7nHawrCNYc50S\n\tgR7xNMCY2l7MtiWNB6KrH6TeufjfXpEelt5NEdrKI0Mh8kUWwvPNibZs4Kh5w1AqSvmY\n\tZC8pEFN7taJdnuXnCIwQTwYMOwmZ/6udjUndWpcu4oSAFMTvJQxU/gNFkUshaHQlaexm\n\tP87XZK5t9kSKQ2AiKZg/bXOR4MjqF8uF3VFa5EHblkDMi6WoNkQ0bleuTq8HGLh7DcdI\n\te7AA==", "X-Gm-Message-State": "AD7BkJJwyOqoBGPX870Tdt/cbLNaqh64kuXXLfz+its20yiw76z4jY55ecCkJ0g/UwX2870I", "X-Received": "by 10.194.134.134 with SMTP id pk6mr3362927wjb.176.1457015280135;\n\tThu, 03 Mar 2016 06:28:00 -0800 (PST)", "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "To": "dev@dpdk.org", "Date": "Thu, 3 Mar 2016 15:27:36 +0100", "Message-Id": "<1457015260-3041-4-git-send-email-adrien.mazarguil@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1457015260-3041-1-git-send-email-adrien.mazarguil@6wind.com>", "References": "<1456165123-28365-1-git-send-email-adrien.mazarguil@6wind.com>\n\t<1457015260-3041-1-git-send-email-adrien.mazarguil@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 3/7] mlx5: manage all special flow types at\n\tonce", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit adds helpers to remove redundant code.\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx5/mlx5.c | 5 +----\n drivers/net/mlx5/mlx5.h | 2 ++\n drivers/net/mlx5/mlx5_rxmode.c | 40 ++++++++++++++++++++++++++++++++++++++++\n drivers/net/mlx5/mlx5_trigger.c | 10 ++--------\n 4 files changed, 45 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex ae2576f..ad69ec2 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -88,10 +88,7 @@ mlx5_dev_close(struct rte_eth_dev *dev)\n \t ((priv->ctx != NULL) ? priv->ctx->device->name : \"\"));\n \t/* In case mlx5_dev_stop() has not been called. */\n \tpriv_dev_interrupt_handler_uninstall(priv, dev);\n-\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_ALLMULTI);\n-\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_PROMISC);\n-\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_BROADCAST);\n-\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_IPV6MULTI);\n+\tpriv_special_flow_disable_all(priv);\n \tpriv_mac_addrs_disable(priv);\n \tpriv_destroy_hash_rxqs(priv);\n \ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 8442016..43b24fb 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -199,6 +199,8 @@ int mlx5_dev_rss_reta_update(struct rte_eth_dev *,\n \n int priv_special_flow_enable(struct priv *, enum hash_rxq_flow_type);\n void priv_special_flow_disable(struct priv *, enum hash_rxq_flow_type);\n+int priv_special_flow_enable_all(struct priv *);\n+void priv_special_flow_disable_all(struct priv *);\n void mlx5_promiscuous_enable(struct rte_eth_dev *);\n void mlx5_promiscuous_disable(struct rte_eth_dev *);\n void mlx5_allmulticast_enable(struct rte_eth_dev *);\ndiff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c\nindex 9ac7a41..bcf4231 100644\n--- a/drivers/net/mlx5/mlx5_rxmode.c\n+++ b/drivers/net/mlx5/mlx5_rxmode.c\n@@ -268,6 +268,46 @@ priv_special_flow_disable(struct priv *priv, enum hash_rxq_flow_type flow_type)\n }\n \n /**\n+ * Enable all special flows in all hash RX queues.\n+ *\n+ * @param priv\n+ * Private structure.\n+ */\n+int\n+priv_special_flow_enable_all(struct priv *priv)\n+{\n+\tenum hash_rxq_flow_type flow_type;\n+\n+\tfor (flow_type = 0; flow_type != HASH_RXQ_FLOW_TYPE_MAC; ++flow_type) {\n+\t\tint ret;\n+\n+\t\tret = priv_special_flow_enable(priv, flow_type);\n+\t\tif (!ret)\n+\t\t\tcontinue;\n+\t\t/* Failure, rollback. */\n+\t\twhile (flow_type)\n+\t\t\tpriv_special_flow_disable(priv, --flow_type);\n+\t\treturn ret;\n+\t}\n+\treturn 0;\n+}\n+\n+/**\n+ * Disable all special flows in all hash RX queues.\n+ *\n+ * @param priv\n+ * Private structure.\n+ */\n+void\n+priv_special_flow_disable_all(struct priv *priv)\n+{\n+\tenum hash_rxq_flow_type flow_type;\n+\n+\tfor (flow_type = 0; flow_type != HASH_RXQ_FLOW_TYPE_MAC; ++flow_type)\n+\t\tpriv_special_flow_disable(priv, flow_type);\n+}\n+\n+/**\n * DPDK callback to enable promiscuous mode.\n *\n * @param dev\ndiff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c\nindex db7890f..b5ca7d4 100644\n--- a/drivers/net/mlx5/mlx5_trigger.c\n+++ b/drivers/net/mlx5/mlx5_trigger.c\n@@ -80,10 +80,7 @@ mlx5_dev_start(struct rte_eth_dev *dev)\n \t\t \" %s\",\n \t\t (void *)priv, strerror(err));\n \t\t/* Rollback. */\n-\t\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_IPV6MULTI);\n-\t\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_BROADCAST);\n-\t\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_ALLMULTI);\n-\t\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_PROMISC);\n+\t\tpriv_special_flow_disable_all(priv);\n \t\tpriv_mac_addrs_disable(priv);\n \t\tpriv_destroy_hash_rxqs(priv);\n \t}\n@@ -113,10 +110,7 @@ mlx5_dev_stop(struct rte_eth_dev *dev)\n \t\treturn;\n \t}\n \tDEBUG(\"%p: cleaning up and destroying hash RX queues\", (void *)dev);\n-\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_IPV6MULTI);\n-\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_BROADCAST);\n-\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_ALLMULTI);\n-\tpriv_special_flow_disable(priv, HASH_RXQ_FLOW_TYPE_PROMISC);\n+\tpriv_special_flow_disable_all(priv);\n \tpriv_mac_addrs_disable(priv);\n \tpriv_destroy_hash_rxqs(priv);\n \tpriv_fdir_disable(priv);\n", "prefixes": [ "dpdk-dev", "v2", "3/7" ] }{ "id": 11041, "url": "