Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10995/?format=api
{ "id": 10995, "url": "https://patches.dpdk.org/api/patches/10995/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1456928543-23329-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1456928543-23329-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1456928543-23329-1-git-send-email-thomas.monjalon@6wind.com", "date": "2016-03-02T14:22:23", "name": "[dpdk-dev,v3] mk: stop on warning only in developer build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "08e954184d0e3ace5fea2c866040ad65b4e4e83c", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1456928543-23329-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/10995/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/10995/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6F5CFAD89;\n\tWed, 2 Mar 2016 15:24:15 +0100 (CET)", "from mail-wm0-f49.google.com (mail-wm0-f49.google.com\n\t[74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 778189AA8\n\tfor <dev@dpdk.org>; Wed, 2 Mar 2016 15:24:13 +0100 (CET)", "by mail-wm0-f49.google.com with SMTP id l68so87824070wml.0\n\tfor <dev@dpdk.org>; Wed, 02 Mar 2016 06:24:13 -0800 (PST)", "from XPS13.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tw17sm4452962wmw.5.2016.03.02.06.24.12\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tWed, 02 Mar 2016 06:24:12 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=+lhRi9Xk+ymMaVYvcZ9KTXjJo9h8GODX1Jm+ID0/6gg=;\n\tb=wTIZFPoJiqIkii232FQ+xFC+70/dMmI7ZqSQMv1nYDyEan7RR5sGxGg3W5P+Lj5m4X\n\t73XLviVl144Fcb19IKPK6gAOEEb0zvGoSNaZbbSxsm4Z0AgTi48IjB/XtUlRx8P+sY9e\n\tWdB1oNhYDf36JUWvajW4WxGPn+GOAzXH0803C6YzQKacTyTqcA6iT4uHqqpj8KVZEl6n\n\tYQwkGryQJoH/JlSTevwf4a75HQH2eXIZc3x9sV0u/Y+ELWhby/baIATBPJxe+UXGjj9m\n\tWSUwqUVx3Y0+dZOxsyzMEO2vYpWT121DgAYhP4j0d2uCFU+sxcfZkKBUjvrhTAC0N9cT\n\tuAaQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=+lhRi9Xk+ymMaVYvcZ9KTXjJo9h8GODX1Jm+ID0/6gg=;\n\tb=iJCCgoL+oUAHC/0/dDIT5SxRrK1wNPhZE4XgbWe0WfoL3PsiUHRHAG9Ir4rpqHKtAv\n\to56NlFGG6gtLomdmVumjnT6Kg37JF5jPU2y2xhzxPj7x41WjE0U7joJ8qGx7QPUkJp6C\n\talwG2HnrTzHZnS8pE9W1NcUkTGnCsmfRybNebBudHutw3cGeU6CcI2pPdXUUT530W46a\n\tKft+jtA3WuWnHvLTpKaVicG+yF7EPUinltr7mEMgAU9QGdnWAvkZYdZZ4P2n/0shBKJv\n\t1WWQkmjRbmLnVdAlPC9GBrmN7QUluC3l/MVXPUS0HbET116wdm7ifUX323DiYeSOkrOb\n\tBoLg==", "X-Gm-Message-State": "AD7BkJJvxHicGFG/Sqqk/Oh3JPoneG8m6Gjr79jY6Dc4AouxakDYGn6qBmXSWrHrpDsxYAGS", "X-Received": "by 10.194.158.36 with SMTP id wr4mr25347879wjb.134.1456928653316;\n\tWed, 02 Mar 2016 06:24:13 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "pmatilai@redhat.com", "Date": "Wed, 2 Mar 2016 15:22:23 +0100", "Message-Id": "<1456928543-23329-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "In-Reply-To": "<9190554.3JBlDK3N1R@xps13>", "References": "<9190554.3JBlDK3N1R@xps13>", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [PATCH v3] mk: stop on warning only in developer build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Panu Matilainen <pmatilai@redhat.com>\n\nAdd RTE_DEVEL_BUILD make-variable which can be used to do things\ndifferently when doing development vs building a release,\nautodetected from source root .git presence and overridable via\ncommandline. It is used it to enable -Werror compiler flag and may\nbe extended to other checks.\n\nFailing build on warnings is a useful developer tool but its bad\nfor release tarballs which can and do get built with newer\ncompilers than what was used/available during development. Compilers\nroutinely add new warnings so code which built silently with cc X\nmight no longer do so with X+1. This doesn't make the existing code\nany more buggier and failing the build in this case does not help\nto improve the quality of an already released version either.\n\nThis change the default flags which can be tuned with EXTRA_CFLAGS.\n\nSigned-off-by: Panu Matilainen <pmatilai@redhat.com>\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n doc/build-sdk-quick.txt | 1 +\n doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++\n mk/rte.vars.mk | 5 +++++\n mk/toolchain/clang/rte.vars.mk | 6 +++++-\n mk/toolchain/gcc/rte.vars.mk | 6 +++++-\n mk/toolchain/icc/rte.vars.mk | 6 +++++-\n 6 files changed, 23 insertions(+), 3 deletions(-)\n\nv3:\n- not only for SDK build (-Werror for examples, apps)\n- update doc", "diff": "diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt\nindex acd1bfe..967ff09 100644\n--- a/doc/build-sdk-quick.txt\n+++ b/doc/build-sdk-quick.txt\n@@ -15,6 +15,7 @@ Build variables\n \tEXTRA_LDFLAGS linker options\n \tEXTRA_LDLIBS linker library options\n \tRTE_KERNELDIR linux headers path\n+\tRTE_DEVEL_BUILD stricter options (default: y in git tree)\n \tCROSS toolchain prefix\n \tV verbose\n \tD debug dependencies\ndiff --git a/doc/guides/prog_guide/dev_kit_build_system.rst b/doc/guides/prog_guide/dev_kit_build_system.rst\nindex dd3e3d0..3e89eae 100644\n--- a/doc/guides/prog_guide/dev_kit_build_system.rst\n+++ b/doc/guides/prog_guide/dev_kit_build_system.rst\n@@ -343,6 +343,8 @@ Useful Variables Provided by the Build System\n By default, the variable is set to /lib/modules/$(shell uname -r)/build,\n which is correct when the target machine is also the build machine.\n \n+* RTE_DEVEL_BUILD: Stricter options (stop on warning). It defaults to y in a git tree.\n+\n Variables that Can be Set/Overridden in a Makefile Only\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n \ndiff --git a/mk/rte.vars.mk b/mk/rte.vars.mk\nindex 2d734bd..28982a5 100644\n--- a/mk/rte.vars.mk\n+++ b/mk/rte.vars.mk\n@@ -102,6 +102,11 @@ export RTE_MACHINE\n export RTE_EXEC_ENV\n export RTE_TOOLCHAIN\n \n+# developer build automatically enabled in a git tree\n+ifneq ($(wildcard $(RTE_SDK)/.git),)\n+RTE_DEVEL_BUILD := y\n+endif\n+\n # SRCDIR is the current source directory\n ifdef S\n SRCDIR := $(abspath $(RTE_SRCDIR)/$(S))\ndiff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk\nindex 245ea7e..7749b99 100644\n--- a/mk/toolchain/clang/rte.vars.mk\n+++ b/mk/toolchain/clang/rte.vars.mk\n@@ -63,12 +63,16 @@ TOOLCHAIN_ASFLAGS =\n TOOLCHAIN_CFLAGS =\n TOOLCHAIN_LDFLAGS =\n \n-WERROR_FLAGS := -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes\n+WERROR_FLAGS := -W -Wall -Wstrict-prototypes -Wmissing-prototypes\n WERROR_FLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith\n WERROR_FLAGS += -Wnested-externs -Wcast-qual\n WERROR_FLAGS += -Wformat-nonliteral -Wformat-security\n WERROR_FLAGS += -Wundef -Wwrite-strings\n \n+ifeq ($(RTE_DEVEL_BUILD),y)\n+WERROR_FLAGS += -Werror\n+endif\n+\n # process cpu flags\n include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk\n \ndiff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk\nindex c2c5255..ff70f3d 100644\n--- a/mk/toolchain/gcc/rte.vars.mk\n+++ b/mk/toolchain/gcc/rte.vars.mk\n@@ -71,12 +71,16 @@ ifeq (,$(findstring -O0,$(EXTRA_CFLAGS)))\n endif\n endif\n \n-WERROR_FLAGS := -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes\n+WERROR_FLAGS := -W -Wall -Wstrict-prototypes -Wmissing-prototypes\n WERROR_FLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith\n WERROR_FLAGS += -Wcast-align -Wnested-externs -Wcast-qual\n WERROR_FLAGS += -Wformat-nonliteral -Wformat-security\n WERROR_FLAGS += -Wundef -Wwrite-strings\n \n+ifeq ($(RTE_DEVEL_BUILD),y)\n+WERROR_FLAGS += -Werror\n+endif\n+\n # There are many issues reported for ARMv7 architecture\n # which are not necessarily fatal. Report as warnings.\n ifeq ($(CONFIG_RTE_ARCH_ARMv7),y)\ndiff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk\nindex 9b6b34b..ba69f1f 100644\n--- a/mk/toolchain/icc/rte.vars.mk\n+++ b/mk/toolchain/icc/rte.vars.mk\n@@ -69,9 +69,13 @@ TOOLCHAIN_ASFLAGS =\n # error #13368: loop was not vectorized with \"vector always assert\"\n # error #15527: loop was not vectorized: function call to fprintf cannot be vectorize\n # was declared \"deprecated\"\n-WERROR_FLAGS := -Wall -Werror-all -w2 -diag-disable 271 -diag-warning 1478\n+WERROR_FLAGS := -Wall -w2 -diag-disable 271 -diag-warning 1478\n WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527\n \n+ifeq ($(RTE_DEVEL_BUILD),y)\n+WERROR_FLAGS += -Werror-all\n+endif\n+\n # process cpu flags\n include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk\n # disable max-inline params boundaries for ICC compiler for version 15 and greater\n", "prefixes": [ "dpdk-dev", "v3" ] }