Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/109879/?format=api
{ "id": 109879, "url": "https://patches.dpdk.org/api/patches/109879/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220418042915.5765-10-srikanth.k@oneconvergence.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220418042915.5765-10-srikanth.k@oneconvergence.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220418042915.5765-10-srikanth.k@oneconvergence.com", "date": "2022-04-18T04:29:10", "name": "[v4,09/14] bus/vmbus: open subchannels", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ddbf3747197c886095ad26bdec748385587f6fbe", "submitter": { "id": 2368, "url": "https://patches.dpdk.org/api/people/2368/?format=api", "name": "Srikanth Kaka", "email": "srikanth.k@oneconvergence.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220418042915.5765-10-srikanth.k@oneconvergence.com/mbox/", "series": [ { "id": 22557, "url": "https://patches.dpdk.org/api/series/22557/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22557", "date": "2022-04-18T04:29:01", "name": "add FreeBSD support to VMBUS & NetVSC PMDs", "version": 4, "mbox": "https://patches.dpdk.org/series/22557/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/109879/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/109879/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2D0F1A00BE;\n\tTue, 19 Apr 2022 11:34:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 20FC942815;\n\tTue, 19 Apr 2022 11:33:48 +0200 (CEST)", "from mail-pg1-f177.google.com (mail-pg1-f177.google.com\n [209.85.215.177])\n by mails.dpdk.org (Postfix) with ESMTP id 4976240141\n for <dev@dpdk.org>; Mon, 18 Apr 2022 06:29:59 +0200 (CEST)", "by mail-pg1-f177.google.com with SMTP id q19so16755475pgm.6\n for <dev@dpdk.org>; Sun, 17 Apr 2022 21:29:59 -0700 (PDT)", "from srikanth-ThinkPad-T450.. ([49.37.158.191])\n by smtp.gmail.com with ESMTPSA id\n e14-20020aa78c4e000000b00506475da4cesm10377577pfd.49.2022.04.17.21.29.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 17 Apr 2022 21:29:57 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oneconvergence.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=2bahx64LuEbChOf1Axjl42rqx1Wa1GVGQEcGvPASvoI=;\n b=UFRwJLIq2vAZ4L6PP2o0h5gFT9TEcW8stP98xN8spuIytVztyw9TF2vUklRmB740Bu\n mlzRGslezDj2vTSL8S5VhlTb7ga0ebr9A/PO7JkQBYjxX39obiE+dXK+l7qazeTFmw8T\n ZlWcwbG48+zF9G86uyQ+gTzpPNd7YE3hyMlFg=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=2bahx64LuEbChOf1Axjl42rqx1Wa1GVGQEcGvPASvoI=;\n b=HaxFgrxjXwZwDgduTm0uFeOWUgwsojFy2DQwpKMMUrssfM0vRZLipl0ypTFHFsSnM8\n hqg4y0beZ3ONidVG90yJGAL/QJkEYkzlqyAnk969CFX7d2I06xRD7XVGFJzfMhw/Bnzt\n L0uTuTTMPeuGDshQeMy3g4LGdK0OzqnbgxFL+By6Lc4JteXn3MuTicxY9773H30UOqSs\n pRuDraHzRRMMMOfutSmBcQgwoeRiylr106MECyufvNWQ8FZgLOmaYqMB/Vif5kE5pQ1y\n cjrk0YK6YoVLvwWMrPrXWYqDEFQbiOyn8Y3+BFj1gtJLJrhGUSgjypltcClW/S5T1AUg\n u2fA==", "X-Gm-Message-State": "AOAM53099wIOxYWKn+vO8SahR4A80l64WCMTAIz0Nkt2Re/Bxg0c8cFS\n FJX/1cGwmplMBbIkzZzkqZl31A==", "X-Google-Smtp-Source": "\n ABdhPJztMOmEpgYAj+lZiIdx2oo3jxHLoIVo81mkcYGm7P1faPbHiUCYAvyLWswYvJ7yOQ4NuAZzsQ==", "X-Received": "by 2002:a63:f546:0:b0:3aa:878:e29f with SMTP id\n e6-20020a63f546000000b003aa0878e29fmr1456072pgk.439.1650256198522;\n Sun, 17 Apr 2022 21:29:58 -0700 (PDT)", "From": "Srikanth Kaka <srikanth.k@oneconvergence.com>", "To": "Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>", "Cc": "dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>,\n Anand Thulasiram <avelu@juniper.net>,\n Srikanth Kaka <srikanth.k@oneconvergence.com>", "Subject": "[PATCH v4 09/14] bus/vmbus: open subchannels", "Date": "Mon, 18 Apr 2022 09:59:10 +0530", "Message-Id": "<20220418042915.5765-10-srikanth.k@oneconvergence.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220418042915.5765-1-srikanth.k@oneconvergence.com>", "References": "<20220217160613.70161-16-srikanth.k@oneconvergence.com>\n <20220418042915.5765-1-srikanth.k@oneconvergence.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Tue, 19 Apr 2022 11:33:36 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In FreeBSD, unlike Linux there is no sub-channel open callback that\ncould be called by HV_UIO driver upon their grant by the hypervisor.\nThus the PMD makes an IOCTL to the HV_UIO to open the sub-channels\n\nOn Linux, the vmbus_uio_subchan_open() will always return success\nas the Linux HV_UIO opens them implicitly.\n\nSigned-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com>\nSigned-off-by: Vag Singh <vag.singh@oneconvergence.com>\nSigned-off-by: Anand Thulasiram <avelu@juniper.net>\n---\n drivers/bus/vmbus/freebsd/vmbus_uio.c | 30 +++++++++++++++++++++++++++\n drivers/bus/vmbus/linux/vmbus_uio.c | 12 +++++++++++\n drivers/bus/vmbus/private.h | 1 +\n drivers/bus/vmbus/rte_bus_vmbus.h | 10 +++++++++\n drivers/bus/vmbus/version.map | 1 +\n drivers/bus/vmbus/vmbus_channel.c | 5 +++++\n 6 files changed, 59 insertions(+)", "diff": "diff --git a/drivers/bus/vmbus/freebsd/vmbus_uio.c b/drivers/bus/vmbus/freebsd/vmbus_uio.c\nindex 6b43b4349f..7e4e9723cb 100644\n--- a/drivers/bus/vmbus/freebsd/vmbus_uio.c\n+++ b/drivers/bus/vmbus/freebsd/vmbus_uio.c\n@@ -25,6 +25,9 @@\n */\n #define UH_SUBCHAN_MASK_SHIFT 8\n \n+/* ioctl */\n+#define HVIOOPENSUBCHAN _IOW('h', 14, uint32_t)\n+\n const char *driver_name = \"hv_uio\";\n \n /* Check map names with kernel names */\n@@ -151,3 +154,30 @@ const char *get_devname_os(void)\n {\n \treturn \"/dev/hv_uio\";\n }\n+\n+int vmbus_uio_subchan_open(struct rte_vmbus_device *dev, uint32_t subchan)\n+{\n+\tstruct mapped_vmbus_resource *uio_res;\n+\tint fd, err = 0;\n+\n+\tuio_res = vmbus_uio_find_resource(dev);\n+\tif (!uio_res) {\n+\t\tVMBUS_LOG(ERR, \"cannot find uio resource\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfd = open(uio_res->path, O_RDWR);\n+\tif (fd < 0) {\n+\t\tVMBUS_LOG(ERR, \"Cannot open %s: %s\",\n+\t\t\t\tuio_res->path, strerror(errno));\n+\t\treturn -1;\n+\t}\n+\n+\tif (ioctl(fd, HVIOOPENSUBCHAN, &subchan)) {\n+\t\tVMBUS_LOG(ERR, \"open subchan ioctl failed %s: %s\",\n+\t\t\t\tuio_res->path, strerror(errno));\n+\t\terr = -1;\n+\t}\n+\tclose(fd);\n+\treturn err;\n+}\ndiff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c\nindex 669551a4d4..d88cc97b5b 100644\n--- a/drivers/bus/vmbus/linux/vmbus_uio.c\n+++ b/drivers/bus/vmbus/linux/vmbus_uio.c\n@@ -215,3 +215,15 @@ const char *get_devname_os(void)\n {\n \treturn \"/dev/uio\";\n }\n+\n+/*\n+ * This is a stub function and it should always succeed.\n+ * The Linux UIO kernel driver opens the subchannels implicitly.\n+ */\n+int vmbus_uio_subchan_open(struct rte_vmbus_device *dev,\n+\t\t\t uint32_t subchan)\n+{\n+\tRTE_SET_USED(dev);\n+\tRTE_SET_USED(subchan);\n+\treturn 0;\n+}\ndiff --git a/drivers/bus/vmbus/private.h b/drivers/bus/vmbus/private.h\nindex 1bca147e12..ea0276a6c6 100644\n--- a/drivers/bus/vmbus/private.h\n+++ b/drivers/bus/vmbus/private.h\n@@ -116,6 +116,7 @@ bool vmbus_uio_subchannels_supported(const struct rte_vmbus_device *dev,\n int vmbus_uio_get_subchan(struct vmbus_channel *primary,\n \t\t\t struct vmbus_channel **subchan);\n int vmbus_uio_map_rings(struct vmbus_channel *chan);\n+int vmbus_uio_subchan_open(struct rte_vmbus_device *device, uint32_t subchan);\n \n void vmbus_br_setup(struct vmbus_br *br, void *buf, unsigned int blen);\n \ndiff --git a/drivers/bus/vmbus/rte_bus_vmbus.h b/drivers/bus/vmbus/rte_bus_vmbus.h\nindex a24bad831d..c8cb4bc98c 100644\n--- a/drivers/bus/vmbus/rte_bus_vmbus.h\n+++ b/drivers/bus/vmbus/rte_bus_vmbus.h\n@@ -404,6 +404,16 @@ void rte_vmbus_chan_dump(FILE *f, const struct vmbus_channel *chan);\n */\n void rte_vmbus_unregister(struct rte_vmbus_driver *driver);\n \n+/**\n+ * Perform IOCTL to VMBUS device\n+ *\n+ * @param device\n+ *\tA pointer to a rte_vmbus_device structure\n+ * @param subchan\n+ *\tCount of subchannels to open\n+ */\n+int rte_vmbus_ioctl(struct rte_vmbus_device *device, uint32_t subchan);\n+\n /** Helper for VMBUS device registration from driver instance */\n #define RTE_PMD_REGISTER_VMBUS(nm, vmbus_drv)\t\t\\\n \tRTE_INIT(vmbusinitfn_ ##nm)\t\t\t\\\ndiff --git a/drivers/bus/vmbus/version.map b/drivers/bus/vmbus/version.map\nindex 3cadec7fae..3509d4fc14 100644\n--- a/drivers/bus/vmbus/version.map\n+++ b/drivers/bus/vmbus/version.map\n@@ -23,6 +23,7 @@ DPDK_22 {\n \trte_vmbus_subchan_open;\n \trte_vmbus_unmap_device;\n \trte_vmbus_unregister;\n+\trte_vmbus_ioctl;\n \n \tlocal: *;\n };\ndiff --git a/drivers/bus/vmbus/vmbus_channel.c b/drivers/bus/vmbus/vmbus_channel.c\nindex 119b9b367e..9a8f6e3eef 100644\n--- a/drivers/bus/vmbus/vmbus_channel.c\n+++ b/drivers/bus/vmbus/vmbus_channel.c\n@@ -365,6 +365,11 @@ int rte_vmbus_max_channels(const struct rte_vmbus_device *device)\n \t\treturn 1;\n }\n \n+int rte_vmbus_ioctl(struct rte_vmbus_device *device, uint32_t subchan)\n+{\n+\treturn vmbus_uio_subchan_open(device, subchan);\n+}\n+\n /* Setup secondary channel */\n int rte_vmbus_subchan_open(struct vmbus_channel *primary,\n \t\t\t struct vmbus_channel **new_chan)\n", "prefixes": [ "v4", "09/14" ] }