Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/109596/?format=api
{ "id": 109596, "url": "https://patches.dpdk.org/api/patches/109596/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220411151559.164217-1-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220411151559.164217-1-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220411151559.164217-1-mattias.ronnblom@ericsson.com", "date": "2022-04-11T15:15:57", "name": "[1/3] eal: add macro to warn for unused function return values", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "03838f49e336d3ae1d1d9f75445af8ea0feb8d7c", "submitter": { "id": 1077, "url": "https://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220411151559.164217-1-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 22477, "url": "https://patches.dpdk.org/api/series/22477/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22477", "date": "2022-04-11T15:15:58", "name": "[1/3] eal: add macro to warn for unused function return values", "version": 1, "mbox": "https://patches.dpdk.org/series/22477/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/109596/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/109596/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9320CA00BE;\n\tMon, 11 Apr 2022 17:18:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8594241611;\n\tMon, 11 Apr 2022 17:18:37 +0200 (CEST)", "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2075.outbound.protection.outlook.com [40.107.22.75])\n by mails.dpdk.org (Postfix) with ESMTP id 6046B415D7\n for <dev@dpdk.org>; Mon, 11 Apr 2022 17:18:36 +0200 (CEST)", "from AM6P195CA0042.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::19)\n by HE1PR0702MB3657.eurprd07.prod.outlook.com (2603:10a6:7:7e::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.17; Mon, 11 Apr\n 2022 15:18:35 +0000", "from VE1EUR02FT048.eop-EUR02.prod.protection.outlook.com\n (2603:10a6:209:87:cafe::50) by AM6P195CA0042.outlook.office365.com\n (2603:10a6:209:87::19) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend\n Transport; Mon, 11 Apr 2022 15:18:34 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n VE1EUR02FT048.mail.protection.outlook.com (10.152.13.177) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id\n 15.20.5144.20 via Frontend Transport; Mon, 11 Apr 2022 15:18:34 +0000", "from ESESSMB501.ericsson.se (153.88.183.162) by\n ESESSMR505.ericsson.se (153.88.183.127) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2308.27; Mon, 11 Apr 2022 17:17:37 +0200", "from seliiuapp00218.seli.gic.ericsson.se (153.88.183.153) by\n smtp.internal.ericsson.com (153.88.183.189) with Microsoft SMTP Server id\n 15.1.2308.27 via Frontend Transport; Mon, 11 Apr 2022 17:17:37 +0200", "from localhost.localdomain (seliicwb00002.seli.gic.ericsson.se\n [10.156.25.100])\n by seliiuapp00218.seli.gic.ericsson.se (Postfix) with ESMTP id 4ED9160160;\n Mon, 11 Apr 2022 17:17:37 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=jmT00qdc0yN0q3CjT3KPRNzKCCB3GNqIiQ7fu/x/LjtIYojf8931aR95kzhI6JyDqiQQeK+3zRmnBmlL+8sY0LKBu3TxpMBex8PxM9jmkdRNCfPyfcso4UfuuDKUYvExepLwa4cVLv5S7IfTJ+BRb/YVzN1d7AFUErq3bKAshSRH1VjcaBdL6EghQproeVoEWvSkA+mF9aY/jbSdSY4tWtpTv7aHOBwPiSD9h1Sx+9ciapYVstPZ0NCK/qfuJ/DHPfg4LyK+WqDOFKoUtxOdgtwxgiKl0fZ5uRfRnytJgQl00G63zF0kQMM/65VF+0FM5BvHCS92kIkuipNPnOWkFw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=9t/hTjCAT0r0pT1YrTQwOHpzMcHrkNUGsWIL3KI0gJk=;\n b=h76aRImFIc6nDUoHzQGI5uQ4cQ1hhCu/05XmdhV2ZTCPAfNEjSA881jbU16roaWkoL3wVDY/zXnvwmB+YKLFsijSBPN2AQ4TdSERGNwIdWiLlEaei+/i80caXiglVrThgWbGuNXzUpVQvOChAL4unS51T/qFaLxJ3VWiZYhdRQhL/bVfU6kzVAEL46sSZQdHuEy5PhHAP55gT1irnZQlOVWhmGbSS4J2oWkeZcGIg7Zypu5FZsx0CTG2MMSPJ0Kqawd7jvIJYRbKBlooaPzkuAuD52JS1uMehRdWYxVDusdt4eGbIpfMq/1Vco+veZqUQcDr4vNyS5oRRUg70Pf7aQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=arm.com smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=9t/hTjCAT0r0pT1YrTQwOHpzMcHrkNUGsWIL3KI0gJk=;\n b=ky1wpchbEwHAatu6YNBFc7fuJYh4UU+U57yaFxRxewmBdu3mFPgZicZHY9KfGskGzi23NojBOPR0vZ/wH73bcPkaCrGUh+9xoRybY71K5qEFe/J7eP8oHzF1rR8DRW9604G9DNfLyKdlPWUY4QY/cApFxHN++0p9shjVOuRFU+Y=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com;", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "Bruce Richardson <bruce.richardson@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n David Marchand <david.marchand@redhat.com>, <Honnappa.Nagarahalli@arm.com>,\n <mb@smartsharesystems.com>, <hofors@lysator.liu.se>,\n Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Mattias_R=C3=B6nn?=\n\t=?utf-8?q?blom?= <mattias.ronnblom@ericsson.com>", "Subject": "[PATCH 1/3] eal: add macro to warn for unused function return values", "Date": "Mon, 11 Apr 2022 17:15:57 +0200", "Message-ID": "<20220411151559.164217-1-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<YlPx85fQa0XbUf/O@bricha3-MOBL.ger.corp.intel.com>", "References": "<YlPx85fQa0XbUf/O@bricha3-MOBL.ger.corp.intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "79926fc1-27c6-4ff1-2d44-08da1bce8b87", "X-MS-TrafficTypeDiagnostic": "HE1PR0702MB3657:EE_", "X-Microsoft-Antispam-PRVS": "\n <HE1PR0702MB365734BB6EBBAFFE4A89E113E1EA9@HE1PR0702MB3657.eurprd07.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n WzLrW3zhPIiL3Uyqr92+MrykT8UOZnGqZJzyygcDdiVRqr5V8qZtKfON3rYBpjYuL33seMhy++2ddndhgunwujMGtBA6HN4n1i+0KGwcr4srmr/9N4GEkeuJmFY/2K3Secv0Yxg1lIOo+OS96LGNp2su7iq0HB45UGfilrabbU7BY74+n1EAjZIzpPmUSMXDYUHM0HJVd+3DBF/52xCsinbVT8l8560u1avMVLugAN6Zu6ZshygCgtT3xfhzVuDuHsz+T/cZrFrsDza+kVUrTRHLKXI6HliqDRePlfSTqsKCcdXXIZ8NF05+RthYrhlKTAUvbNPHPCnrnrBYadDO8oobeXq5wo52UQJLBbvyH048rxYQWp/gtjhyUUcFNDKCHau2Gl014To7ebL2lRAK25NAu34t3qJ/0hxBfVepXklLCNTdlkQj15zJzMIQ312mRbtYQPuFvhtazCR0tDgDz+0vwWlGH9QUQehL/0fBud4FWsSYyv2r8jgZGvtFJLSQDy8iU9BcR3tuP0fYbOsiZ7sIIXUDnKzqxJbgVas5b5MVOHdhL1xkehbDMjirkTaMvAK96jxGgIu+tdKZ2zZYXVp/whqsnqj8TVhCE1pR9ckVXDXpF9ekBb7cZelz0JwjjETgEHG+91TALtp6uaZTNzwDVKUK1aN1DY6PWcYrfe8ERsirJavWVZSzDaeMNiEL", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE;\n SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(6666004)(316002)(47076005)(54906003)(6916009)(2906002)(36860700001)(186003)(107886003)(26005)(2616005)(6266002)(1076003)(66574015)(5660300002)(336012)(83380400001)(508600001)(40460700003)(8936002)(86362001)(4326008)(82310400005)(7636003)(82960400001)(356005)(8676002)(70206006)(36756003)(70586007);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "11 Apr 2022 15:18:34.3670 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 79926fc1-27c6-4ff1-2d44-08da1bce8b87", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n VE1EUR02FT048.eop-EUR02.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "HE1PR0702MB3657", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch adds a wrapper macro __rte_warn_unused_result for the\nwarn_unused_result function attribute.\n\nMarking a function __rte_warn_unused_result will make the compiler\nemit a warning in case the caller does not use the function's return\nvalue.\n\nChanges since RFC:\n * Include usage recommendation and GCC peculiarities in the macro\n documentation.\n\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n lib/eal/include/rte_common.h | 25 +++++++++++++++++++++++++\n 1 file changed, 25 insertions(+)", "diff": "diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h\nindex 4a399cc7c8..67587025ab 100644\n--- a/lib/eal/include/rte_common.h\n+++ b/lib/eal/include/rte_common.h\n@@ -222,6 +222,31 @@ static void __attribute__((destructor(RTE_PRIO(prio)), used)) func(void)\n */\n #define __rte_noreturn __attribute__((noreturn))\n \n+/**\n+ * Issue a warning in case the function's return value is ignored.\n+ *\n+ * The use of this attribute should be restricted to cases where\n+ * ignoring the marked function's return value is almost always a\n+ * bug. With GCC, some effort is required to make clear that ignoring\n+ * the return value is intentional. The usual void-casting method to\n+ * mark something unused as used does not suppress the warning with\n+ * this compiler.\n+ *\n+ * @code{.c}\n+ * __rte_warn_unused_result int foo();\n+ *\n+ * void ignore_foo_result(void) {\n+ * foo(); // generates a warning with all compilers\n+ *\n+ * (void)foo(); // still generates the warning with GCC (but not clang)\n+ *\n+ * int unused __rte_unused;\n+ * unused = foo(); // does the trick with all compilers\n+ * }\n+ * @endcode\n+ */\n+#define __rte_warn_unused_result __attribute__((warn_unused_result))\n+\n /**\n * Force a function to be inlined\n */\n", "prefixes": [ "1/3" ] }