Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 109575,
    "url": "https://patches.dpdk.org/api/patches/109575/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220411100032.114434-3-xuan.ding@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220411100032.114434-3-xuan.ding@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220411100032.114434-3-xuan.ding@intel.com",
    "date": "2022-04-11T10:00:29",
    "name": "[v2,2/5] vhost: prepare async for descriptor to mbuf refactoring",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b87b6ead107ba523b81fac71de5b98862ead5ac6",
    "submitter": {
        "id": 1401,
        "url": "https://patches.dpdk.org/api/people/1401/?format=api",
        "name": "Ding, Xuan",
        "email": "xuan.ding@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220411100032.114434-3-xuan.ding@intel.com/mbox/",
    "series": [
        {
            "id": 22473,
            "url": "https://patches.dpdk.org/api/series/22473/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22473",
            "date": "2022-04-11T10:00:27",
            "name": "vhost: support async dequeue data path",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/22473/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/109575/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/109575/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 62813A04FD;\n\tMon, 11 Apr 2022 12:01:11 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0EF21410F3;\n\tMon, 11 Apr 2022 12:01:08 +0200 (CEST)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 91B12410F3\n for <dev@dpdk.org>; Mon, 11 Apr 2022 12:01:06 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Apr 2022 03:01:06 -0700",
            "from npg-dpdk-xuan-cbdma.sh.intel.com ([10.67.110.228])\n by orsmga002.jf.intel.com with ESMTP; 11 Apr 2022 03:01:03 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1649671267; x=1681207267;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=DtJXZ2RfVrvaE8eeulPDGqutTfhTiI7nrdlWB9VyAgU=;\n b=aWZtOZMDsfkkXDVABhF+geOmY+rqXFizFw+kLwAqombxurAAVB0c6uAM\n E8DZbQqZtMYxj6hMDgyapW5z7wUz1fWN6t4/OBMyfXZyyfPZBZl+KNz4H\n kMnliQr9Ehka6tHE66Dv3aXnFlRnvCS24BbugXXEkS+CngyQTFHPltB2q\n iCsl1KQxPgOnsoIl4PlnVEBrWQOY4hw2PS6RoKsroxoSi7Xz6MtszsONP\n IX5WXfdQXmmqGSUFgUQDTeq7rMSrVZCOku9FPbuhcH0p2VqQMZM5fAMNG\n nexbfyRtaLSuKizhjH19ESFHlwDj+braaZEvjMtl7boapqkE1W8CaPRR4 g==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6400,9594,10313\"; a=\"249361602\"",
            "E=Sophos;i=\"5.90,251,1643702400\"; d=\"scan'208\";a=\"249361602\"",
            "E=Sophos;i=\"5.90,251,1643702400\"; d=\"scan'208\";a=\"525446226\""
        ],
        "X-ExtLoop1": "1",
        "From": "xuan.ding@intel.com",
        "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com",
        "Cc": "dev@dpdk.org, jiayu.hu@intel.com, cheng1.jiang@intel.com,\n sunil.pai.g@intel.com, liangma@liangbit.com,\n Xuan Ding <xuan.ding@intel.com>",
        "Subject": "[PATCH v2 2/5] vhost: prepare async for descriptor to mbuf\n refactoring",
        "Date": "Mon, 11 Apr 2022 10:00:29 +0000",
        "Message-Id": "<20220411100032.114434-3-xuan.ding@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20220411100032.114434-1-xuan.ding@intel.com>",
        "References": "<20220407152546.38167-1-xuan.ding@intel.com>\n <20220411100032.114434-1-xuan.ding@intel.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Xuan Ding <xuan.ding@intel.com>\n\nThis patch refactors vhost async enqueue path and dequeue path to use\nthe same function async_fill_seg() for preparing batch elements,\nwhich simplifies the code without performance degradation.\n\nSigned-off-by: Xuan Ding <xuan.ding@intel.com>\n---\n lib/vhost/virtio_net.c | 23 +++++++++++++++--------\n 1 file changed, 15 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c\nindex a2d04a1f60..709ff483a3 100644\n--- a/lib/vhost/virtio_net.c\n+++ b/lib/vhost/virtio_net.c\n@@ -997,13 +997,14 @@ async_iter_reset(struct vhost_async *async)\n }\n \n static __rte_always_inline int\n-async_mbuf_to_desc_seg(struct virtio_net *dev, struct vhost_virtqueue *vq,\n+async_fill_seg(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\tstruct rte_mbuf *m, uint32_t mbuf_offset,\n-\t\tuint64_t buf_iova, uint32_t cpy_len)\n+\t\tuint64_t buf_iova, uint32_t cpy_len, bool to_desc)\n {\n \tstruct vhost_async *async = vq->async;\n \tuint64_t mapped_len;\n \tuint32_t buf_offset = 0;\n+\tvoid *src, *dst;\n \tvoid *host_iova;\n \n \twhile (cpy_len) {\n@@ -1015,10 +1016,16 @@ async_mbuf_to_desc_seg(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t\treturn -1;\n \t\t}\n \n-\t\tif (unlikely(async_iter_add_iovec(dev, async,\n-\t\t\t\t\t\t(void *)(uintptr_t)rte_pktmbuf_iova_offset(m,\n-\t\t\t\t\t\t\tmbuf_offset),\n-\t\t\t\t\t\thost_iova, (size_t)mapped_len)))\n+\t\tif (to_desc) {\n+\t\t\tsrc = (void *)(uintptr_t)rte_pktmbuf_iova_offset(m, mbuf_offset);\n+\t\t\tdst = host_iova;\n+\t\t} else {\n+\t\t\tsrc = host_iova;\n+\t\t\tdst = (void *)(uintptr_t)rte_pktmbuf_iova_offset(m, mbuf_offset);\n+\t\t}\n+\n+\t\tif (unlikely(async_iter_add_iovec(dev, async, src, dst,\n+\t\t\t\t\t\t (size_t)mapped_len)))\n \t\t\treturn -1;\n \n \t\tcpy_len -= (uint32_t)mapped_len;\n@@ -1161,8 +1168,8 @@ mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\tcpy_len = RTE_MIN(buf_avail, mbuf_avail);\n \n \t\tif (is_async) {\n-\t\t\tif (async_mbuf_to_desc_seg(dev, vq, m, mbuf_offset,\n-\t\t\t\t\t\tbuf_iova + buf_offset, cpy_len) < 0)\n+\t\t\tif (async_fill_seg(dev, vq, m, mbuf_offset,\n+\t\t\t\t\t\tbuf_iova + buf_offset, cpy_len, true) < 0)\n \t\t\t\tgoto error;\n \t\t} else {\n \t\t\tsync_fill_seg(dev, vq, m, mbuf_offset,\n",
    "prefixes": [
        "v2",
        "2/5"
    ]
}