Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/109570/?format=api
{ "id": 109570, "url": "https://patches.dpdk.org/api/patches/109570/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220411054003.60095-1-ke1x.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220411054003.60095-1-ke1x.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220411054003.60095-1-ke1x.zhang@intel.com", "date": "2022-04-11T05:40:03", "name": "[v3,1/1] net/bonding: fix rss key configuration when the key length is 52", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "97b68d925efe6e5760d52a2311a1effe7c80653a", "submitter": { "id": 2503, "url": "https://patches.dpdk.org/api/people/2503/?format=api", "name": "Zhang, Ke1X", "email": "ke1x.zhang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220411054003.60095-1-ke1x.zhang@intel.com/mbox/", "series": [ { "id": 22470, "url": "https://patches.dpdk.org/api/series/22470/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22470", "date": "2022-04-11T05:40:03", "name": "[v3,1/1] net/bonding: fix rss key configuration when the key length is 52", "version": 3, "mbox": "https://patches.dpdk.org/series/22470/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/109570/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/109570/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B9510A00C4;\n\tMon, 11 Apr 2022 07:45:20 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 572E340685;\n\tMon, 11 Apr 2022 07:45:20 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id C9D2F4067B\n for <dev@dpdk.org>; Mon, 11 Apr 2022 07:45:17 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2022 22:45:12 -0700", "from unknown (HELO localhost.localdomain) ([10.239.251.104])\n by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2022 22:45:05 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1649655918; x=1681191918;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=TOFqBkV5nA5Ywb/5WXwNsOwO/PGOrK4sraaPXK5Exyk=;\n b=oDCCiFxa3Rq3ZwFaaX+50Bnmw+NVFHeGuxv+zGVLWXCieRY8hRafwlHl\n lpBloOjDbYR7EE1i7asg5oEWmHPxdMiM50ak/H0jMIb75CR6bV0DAnQW5\n 4+KC9bjHIhNG+6xd0GeUMaPyWvd03+g0EEFSz9g54GJsHCBRqfPcnkm7C\n jBo8eq23/GgBEp7OVSE2pfhogaIy8blOFMq2rmf6h/EaEZOKMa55Gvf32\n NaDOFewSD1y5Tkn9DxxYAr/nRuQDkLrZWDTjOfNxZ7XU1xMTeTty1xJHN\n NyTdgaQoin3QyL6/4rb2vuopop9qgt27Msq1U9MJWRxTkahGWDWo4gRnD A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10313\"; a=\"287043665\"", "E=Sophos;i=\"5.90,251,1643702400\"; d=\"scan'208\";a=\"287043665\"", "E=Sophos;i=\"5.90,251,1643702400\"; d=\"scan'208\";a=\"550988241\"" ], "From": "Ke Zhang <ke1x.zhang@intel.com>", "To": "chas3@att.com,\n\thumin29@huawei.com,\n\tdev@dpdk.org", "Cc": "Ke Zhang <ke1x.zhang@intel.com>", "Subject": "[PATCH v3 1/1] net/bonding: fix rss key configuration when the key\n length is 52", "Date": "Mon, 11 Apr 2022 05:40:03 +0000", "Message-Id": "<20220411054003.60095-1-ke1x.zhang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220411030231.58268-1-ke1x.zhang@intel.com>", "References": "<20220411030231.58268-1-ke1x.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "when creating a bonding device, if the slave device's rss key length\n= standard_rss_key length + extended_hash_key length, then bonding\ndevice will be same as slave, in function bond_ethdev_configure(),\nthe default_rss_key length is 40, it is not matched, so it should\ncalculate a new key for bonding device if the default key could not\nbe used.\n\nSigned-off-by: Ke Zhang <ke1x.zhang@intel.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 17 +++++++++++------\n 1 file changed, 11 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex b305b6a35b..5cbe89031b 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -3617,13 +3617,18 @@ bond_ethdev_configure(struct rte_eth_dev *dev)\n \t\t\t internals->rss_key_len);\n \t\t} else {\n \t\t\tif (internals->rss_key_len > sizeof(default_rss_key)) {\n-\t\t\t\tRTE_BOND_LOG(ERR,\n-\t\t\t\t \"There is no suitable default hash key\");\n-\t\t\t\treturn -EINVAL;\n+\t\t\t\t/*\n+\t\t\t\t * If the rss_key includes standard_rss_key and\n+\t\t\t\t * extended_hash_key, the rss key length will be\n+\t\t\t\t * larger than default rss key length, so it should\n+\t\t\t\t * re-calculate the hash key.\n+\t\t\t\t */\n+\t\t\t\tfor (i = 0; i < internals->rss_key_len; i++)\n+\t\t\t\t\tinternals->rss_key[i] = (uint8_t)rte_rand();\n+\t\t\t} else {\n+\t\t\t\tmemcpy(internals->rss_key, default_rss_key,\n+\t\t\t\t\tinternals->rss_key_len);\n \t\t\t}\n-\n-\t\t\tmemcpy(internals->rss_key, default_rss_key,\n-\t\t\t internals->rss_key_len);\n \t\t}\n \n \t\tfor (i = 0; i < RTE_DIM(internals->reta_conf); i++) {\n", "prefixes": [ "v3", "1/1" ] }