Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/109567/?format=api
{ "id": 109567, "url": "https://patches.dpdk.org/api/patches/109567/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220411030231.58268-1-ke1x.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220411030231.58268-1-ke1x.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220411030231.58268-1-ke1x.zhang@intel.com", "date": "2022-04-11T03:02:31", "name": "[v2,1/1] net/bonding: fix rss key configuration when the key length is 52", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1a1b51f334fe4d1467b761f3fa6ff7adaa468886", "submitter": { "id": 2503, "url": "https://patches.dpdk.org/api/people/2503/?format=api", "name": "Zhang, Ke1X", "email": "ke1x.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220411030231.58268-1-ke1x.zhang@intel.com/mbox/", "series": [ { "id": 22467, "url": "https://patches.dpdk.org/api/series/22467/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22467", "date": "2022-04-11T03:02:31", "name": "[v2,1/1] net/bonding: fix rss key configuration when the key length is 52", "version": 2, "mbox": "https://patches.dpdk.org/series/22467/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/109567/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/109567/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3DBEBA00C4;\n\tMon, 11 Apr 2022 05:07:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 25B3C40698;\n\tMon, 11 Apr 2022 05:07:37 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 7A83E4067B\n for <dev@dpdk.org>; Mon, 11 Apr 2022 05:07:35 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2022 20:07:34 -0700", "from unknown (HELO localhost.localdomain) ([10.239.251.104])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2022 20:07:33 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1649646455; x=1681182455;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=zcQa34UOHNLDhL07fGQqwGJO5QQ9T8SuLezNnH73ptA=;\n b=ESPuNeO2sZbPxDBLK+JczesZ2ubP1VKrnX3g4YnZs2q8cInYiDBs/+zj\n 5iIZhDl6KYvYwnmStZASPjlOz/u8twmE7GRkgc4sKJ27yddJaYdOHepqY\n HKEjCDFIdEPXQIIJ6xWKOOBgwchLRP1Qkv6WWMhFHvkG+mXDDfp0UK1OM\n 8/LTDdY4MU2n+r/qRC4NnMSJkkoMgp81TnwAZeZYh3YQn2FzhW8F4trai\n HUibpLbSD8T98ZXZL3Bv5Rfznk/XlN6D4ODfCsTfxvw2Y6sqlwKyfnKdr\n +/9vvvhUdnEKfj4JNFu85j+usi1AILNgygJiggBa8t2zstnDjN3sQiGWH Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10313\"; a=\"261765151\"", "E=Sophos;i=\"5.90,250,1643702400\"; d=\"scan'208\";a=\"261765151\"", "E=Sophos;i=\"5.90,250,1643702400\"; d=\"scan'208\";a=\"571923481\"" ], "From": "Ke Zhang <ke1x.zhang@intel.com>", "To": "chas3@att.com,\n\thumin29@huawei.com,\n\tdev@dpdk.org", "Cc": "Ke Zhang <ke1x.zhang@intel.com>", "Subject": "[PATCH v2 1/1] net/bonding: fix rss key configuration when the key\n length is 52", "Date": "Mon, 11 Apr 2022 03:02:31 +0000", "Message-Id": "<20220411030231.58268-1-ke1x.zhang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220407093642.44900-1-ke1x.zhang@intel.com>", "References": "<20220407093642.44900-1-ke1x.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "when creating a bonding device, if the slave device's rss key length\nis 52, then bonding device will be same as slave, in function\nbond_ethdev_configure(), the default_rss_key length is 40, it\nis not matched, so it should calculate a new key for bonding\ndevice if the deault key could not be used.\n\nSigned-off-by: Ke Zhang <ke1x.zhang@intel.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 17 +++++++++++------\n 1 file changed, 11 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex b305b6a35b..027339b0d9 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -3617,13 +3617,18 @@ bond_ethdev_configure(struct rte_eth_dev *dev)\n \t\t\t internals->rss_key_len);\n \t\t} else {\n \t\t\tif (internals->rss_key_len > sizeof(default_rss_key)) {\n-\t\t\t\tRTE_BOND_LOG(ERR,\n-\t\t\t\t \"There is no suitable default hash key\");\n-\t\t\t\treturn -EINVAL;\n+\t\t\t\t/*\n+\t\t\t\t * If the rss_key includes standard_rss_key and\n+\t\t\t\t * extended_hash_key, the rss key length will\n+\t\t\t\t * larger than default rss key length, so it should\n+\t\t\t\t * re-calculate the hash key\n+\t\t\t\t */\n+\t\t\t\tfor (i = 0; i < internals->rss_key_len; i++)\n+\t\t\t\t\tinternals->rss_key[i] = (uint8_t)rte_rand();\n+\t\t\t} else {\n+\t\t\t\tmemcpy(internals->rss_key, default_rss_key,\n+\t\t\t\t\tinternals->rss_key_len);\n \t\t\t}\n-\n-\t\t\tmemcpy(internals->rss_key, default_rss_key,\n-\t\t\t internals->rss_key_len);\n \t\t}\n \n \t\tfor (i = 0; i < RTE_DIM(internals->reta_conf); i++) {\n", "prefixes": [ "v2", "1/1" ] }