Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/109557/?format=api
{ "id": 109557, "url": "https://patches.dpdk.org/api/patches/109557/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220410135140.161842-3-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220410135140.161842-3-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220410135140.161842-3-mattias.ronnblom@ericsson.com", "date": "2022-04-10T13:51:40", "name": "[RFC,3/3] examples/bond: fix invalid use of trylock", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c25e7510d784fc261389000aea663d81d6d739e0", "submitter": { "id": 1077, "url": "https://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220410135140.161842-3-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 22461, "url": "https://patches.dpdk.org/api/series/22461/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22461", "date": "2022-04-10T13:51:38", "name": "[RFC,1/3] eal: add macro to warn for unused function return values", "version": 1, "mbox": "https://patches.dpdk.org/series/22461/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/109557/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/109557/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D6D40A00BE;\n\tSun, 10 Apr 2022 15:53:05 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 41720410E0;\n\tSun, 10 Apr 2022 15:53:05 +0200 (CEST)", "from EUR02-HE1-obe.outbound.protection.outlook.com\n (mail-eopbgr10068.outbound.protection.outlook.com [40.107.1.68])\n by mails.dpdk.org (Postfix) with ESMTP id D76F140DDB\n for <dev@dpdk.org>; Sun, 10 Apr 2022 15:53:03 +0200 (CEST)", "from AM6PR0202CA0050.eurprd02.prod.outlook.com\n (2603:10a6:20b:3a::27) by DBAPR07MB6712.eurprd07.prod.outlook.com\n (2603:10a6:10:189::7) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.16; Sun, 10 Apr\n 2022 13:53:00 +0000", "from VE1EUR02FT043.eop-EUR02.prod.protection.outlook.com\n (2603:10a6:20b:3a:cafe::43) by AM6PR0202CA0050.outlook.office365.com\n (2603:10a6:20b:3a::27) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29 via Frontend\n Transport; Sun, 10 Apr 2022 13:53:00 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n VE1EUR02FT043.mail.protection.outlook.com (10.152.13.89) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id\n 15.20.5144.20 via Frontend Transport; Sun, 10 Apr 2022 13:53:00 +0000", "from ESESBMB501.ericsson.se (153.88.183.168) by\n ESESBMR502.ericsson.se (153.88.183.134) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2308.27; Sun, 10 Apr 2022 15:52:59 +0200", "from seliiuapp00218.seli.gic.ericsson.se (153.88.183.153) by\n smtp.internal.ericsson.com (153.88.183.184) with Microsoft SMTP Server id\n 15.1.2308.27 via Frontend Transport; Sun, 10 Apr 2022 15:52:59 +0200", "from localhost.localdomain (seliicwb00002.seli.gic.ericsson.se\n [10.156.25.100])\n by seliiuapp00218.seli.gic.ericsson.se (Postfix) with ESMTP id 8E3F1601CB;\n Sun, 10 Apr 2022 15:52:59 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=UO8cS1WSaWr354swYtUHBGienc+ieKhcsmXHl3or964cRjc0JVLNuvuIDPxfykgL4a16wqS9Q+GdWieaIjj4gEpUzKDmoCkNc/1kb7pLKChbZSLjYOJWczFsWQK3IycfZZdDdSqUww5tqSm1YrON48ktfWBxAmHwHzoShkX1UnlGq4P0Tyfq0cbgqiRMHZIHbDZKZcN1LGdtWLJCa9Wiz39vx7uT5VivRPX9c5Gk+/poiBr2rVUdMaVrF44uLHPZYQv46jNDb+wOieBhojbvUJtTOyyeyw7CoFKuH8zKnjNnoXrkfl7k4DmQU9oCxxj+ulGy9Sf2SedyBFxBsm4eNQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=AktmK6NPwf7ZsqIFtOkJEC3Gqt5HF2QHO71Qn9QmkGA=;\n b=iESwaRcYv/lvq+fQ4QnpDlvJxlReW7RPSdNYcvbiVcqCKeU98GNTqtazzOiHwGijaY7r+YsbTQkixNcDd0xbxSXYEThrF/Ao4kWfLV0hwt8dwSSbgolN7amNkgdKjLxJRwvOsHzkQ1CIkeEO5+R+Xn+/vQs5kRXT4tTlrGf9mb1s6TDS5rADQ6MLPLaCNF3iUOJ71V4AaSW73ke1dGKdpqZRIx8W5Peojc/6YSIdAs7TCq9zduAMrfavS4q0lNhaOmFv2I4FcgoVLgEWQt6uw96RHSGAJpvDMM5Axn6r72FEPwIm/zd1lCTEbn/W4xomFjrBnAsJW1DTXzWzUHKOSA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=arm.com smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AktmK6NPwf7ZsqIFtOkJEC3Gqt5HF2QHO71Qn9QmkGA=;\n b=YgkW/vbvqpVymyjLbAIF2J2g8rzbp/xCMKycckLNVXfKTfxplBCmE+21jo6WJAbDsq3Zzm0446os5KrpIU+ED+qffLrcB+1dDI3v3JQfb0kgNS6NyPzQGmEINsw1xQA/khjWLlCKUuYA3k85LFhgq16MTrxoIU409Vowk9D6Luk=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com;", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "Thomas Monjalon <thomas@monjalon.net>,\n David Marchand <david.marchand@redhat.com>, <Honnappa.Nagarahalli@arm.com>,\n <mb@smartsharesystems.com>, <hofors@lysator.liu.se>, =?utf-8?q?Mattias_R?=\n\t=?utf-8?q?=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n <michalx.k.jastrzebski@intel.com>", "Subject": "[RFC 3/3] examples/bond: fix invalid use of trylock", "Date": "Sun, 10 Apr 2022 15:51:40 +0200", "Message-ID": "<20220410135140.161842-3-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220410135140.161842-1-mattias.ronnblom@ericsson.com>", "References": "\n <DBAPR08MB581495F6710F9CD5BAA40D3798E39@DBAPR08MB5814.eurprd08.prod.outlook.com>\n <20220410135140.161842-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "58c77d29-92d1-4e35-d8fd-08da1af96ce5", "X-MS-TrafficTypeDiagnostic": "DBAPR07MB6712:EE_", "X-Microsoft-Antispam-PRVS": "\n <DBAPR07MB6712DB3E6783A1D1705814FCE1EB9@DBAPR07MB6712.eurprd07.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 79Lwo27fFSYtIxvj9Ygih9HBzanpIxLwljsSxbHeJB4fZHehar8J1aFiL0Od5Vo4lFVTIEz2G5IWQxiFu/y7vfTfNV+OYWoqvrYTpd/0jbLoF+eY48fgbqF6w13eZR7OdbZd6HWORyU788OWbrYIl6ggXsxuWHp/9AtU2EIHWPfeg35O1tyESfTp+MPg+yxAQOSFPJo38izxb0xB6SsGMmoAabJwvNOBZVIs30PI7WMwKRk7LL2LbWgkfCM+qJLQkApw5rMemgysajz339uUakBTiepfq1HrfWOQA9y9SXsVC64muhUqWLt7xMotx8IsYoDKgN2izpS06winmpqUJtmFEzkpCFS25w0K8qZWoId1AvmMZ+Xsg/EonyU0Vr7jbM2hMVGwVQNH4oX3VLuFMPjv1vQlDhVKV8V9/mk3bG8Li/5fslgBHwUPI7nboSrMSIZ0qrFGytD0nzTqClkSYt/UBYLniq+HJMFhhnYam0rPzCXr7M9Toai5Tu8d/REYKHeyH45SHHkoFHk2T4c30DPydRDHXdeudtOLzNBIFXLZ/4+YEvXXfjpwhyH9jpDtp16ttQEj7PACs7FidpVLFjj9OhX5uIAkD+wK57njMlz/ZLg+ez2Lybf+dpTt4j2QlDvMVH3yfj1RBKO7yI9OG2udnmEC1EFIwpM2aAx9hi4Mgk8tPDzylLZRdjME4lTpqVTu0AhA+z62biq3juJgp6u21BuXrjFmUkWw1NUzALQ9leIzLX8eEtGHYBDPa3hwvpodkyLQ56EvE7yRAEoDYQ==", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE;\n SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(82310400005)(34020700004)(40460700003)(47076005)(66574015)(36860700001)(336012)(36756003)(2906002)(82960400001)(186003)(1076003)(6266002)(2616005)(26005)(356005)(7636003)(83380400001)(70586007)(6916009)(70206006)(54906003)(5660300002)(8936002)(508600001)(4326008)(8676002)(86362001)(316002)(6666004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "10 Apr 2022 13:53:00.1903 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 58c77d29-92d1-4e35-d8fd-08da1af96ce5", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n VE1EUR02FT043.eop-EUR02.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DBAPR07MB6712", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The conditional rte_spinlock_trylock() was used as if it is an\nunconditional lock operation in a number of places.\n\nFixes: cc7e8ae84faa (\"examples/bond: add example application for link bonding mode 6\")\nCc: michalx.k.jastrzebski@intel.com\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n examples/bond/main.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/examples/bond/main.c b/examples/bond/main.c\nindex 335bde5c8d..4efebb3902 100644\n--- a/examples/bond/main.c\n+++ b/examples/bond/main.c\n@@ -373,7 +373,7 @@ static int lcore_main(__rte_unused void *arg1)\n \tbond_ip = BOND_IP_1 | (BOND_IP_2 << 8) |\n \t\t\t\t(BOND_IP_3 << 16) | (BOND_IP_4 << 24);\n \n-\trte_spinlock_trylock(&global_flag_stru_p->lock);\n+\trte_spinlock_lock(&global_flag_stru_p->lock);\n \n \twhile (global_flag_stru_p->LcoreMainIsRunning) {\n \t\trte_spinlock_unlock(&global_flag_stru_p->lock);\n@@ -456,7 +456,7 @@ static int lcore_main(__rte_unused void *arg1)\n \t\t\tif (is_free == 0)\n \t\t\t\trte_pktmbuf_free(pkts[i]);\n \t\t}\n-\t\trte_spinlock_trylock(&global_flag_stru_p->lock);\n+\t\trte_spinlock_lock(&global_flag_stru_p->lock);\n \t}\n \trte_spinlock_unlock(&global_flag_stru_p->lock);\n \tprintf(\"BYE lcore_main\\n\");\n@@ -571,7 +571,7 @@ static void cmd_start_parsed(__rte_unused void *parsed_result,\n {\n \tint worker_core_id = rte_lcore_id();\n \n-\trte_spinlock_trylock(&global_flag_stru_p->lock);\n+\trte_spinlock_lock(&global_flag_stru_p->lock);\n \tif (global_flag_stru_p->LcoreMainIsRunning == 0) {\n \t\tif (rte_eal_get_lcore_state(global_flag_stru_p->LcoreMainCore)\n \t\t != WAIT) {\n@@ -591,7 +591,7 @@ static void cmd_start_parsed(__rte_unused void *parsed_result,\n \tif ((worker_core_id >= RTE_MAX_LCORE) || (worker_core_id == 0))\n \t\treturn;\n \n-\trte_spinlock_trylock(&global_flag_stru_p->lock);\n+\trte_spinlock_lock(&global_flag_stru_p->lock);\n \tglobal_flag_stru_p->LcoreMainIsRunning = 1;\n \trte_spinlock_unlock(&global_flag_stru_p->lock);\n \tcmdline_printf(cl,\n@@ -659,7 +659,7 @@ static void cmd_stop_parsed(__rte_unused void *parsed_result,\n \t\t\t struct cmdline *cl,\n \t\t\t __rte_unused void *data)\n {\n-\trte_spinlock_trylock(&global_flag_stru_p->lock);\n+\trte_spinlock_lock(&global_flag_stru_p->lock);\n \tif (global_flag_stru_p->LcoreMainIsRunning == 0)\t{\n \t\tcmdline_printf(cl,\n \t\t\t\t\t\"lcore_main not running on core:%d\\n\",\n@@ -700,7 +700,7 @@ static void cmd_quit_parsed(__rte_unused void *parsed_result,\n \t\t\t struct cmdline *cl,\n \t\t\t __rte_unused void *data)\n {\n-\trte_spinlock_trylock(&global_flag_stru_p->lock);\n+\trte_spinlock_lock(&global_flag_stru_p->lock);\n \tif (global_flag_stru_p->LcoreMainIsRunning == 0)\t{\n \t\tcmdline_printf(cl,\n \t\t\t\t\t\"lcore_main not running on core:%d\\n\",\n@@ -762,7 +762,7 @@ static void cmd_show_parsed(__rte_unused void *parsed_result,\n \t\tprintf(\"\\n\");\n \t}\n \n-\trte_spinlock_trylock(&global_flag_stru_p->lock);\n+\trte_spinlock_lock(&global_flag_stru_p->lock);\n \tcmdline_printf(cl,\n \t\t\t\"Active_slaves:%d \"\n \t\t\t\"packets received:Tot:%d Arp:%d IPv4:%d\\n\",\n", "prefixes": [ "RFC", "3/3" ] }