Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 10942,
    "url": "https://patches.dpdk.org/api/patches/10942/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1456821665-21831-4-git-send-email-xutao.sun@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1456821665-21831-4-git-send-email-xutao.sun@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1456821665-21831-4-git-send-email-xutao.sun@intel.com",
    "date": "2016-03-01T08:41:04",
    "name": "[dpdk-dev,v7,3/4] driver/i40e: implement tunnel filter for IP in GRE",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "1dbfdcfb83f4186b314455398fe1b36be2c3a221",
    "submitter": {
        "id": 347,
        "url": "https://patches.dpdk.org/api/people/347/?format=api",
        "name": "Xutao Sun",
        "email": "xutao.sun@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1456821665-21831-4-git-send-email-xutao.sun@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/10942/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/10942/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A8D009AB5;\n\tTue,  1 Mar 2016 09:41:23 +0100 (CET)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id E1CB49AA8\n\tfor <dev@dpdk.org>; Tue,  1 Mar 2016 09:41:21 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 01 Mar 2016 00:41:20 -0800",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 01 Mar 2016 00:41:20 -0800",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u218fHP0027832;\n\tTue, 1 Mar 2016 16:41:17 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u218fD2R021886; Tue, 1 Mar 2016 16:41:15 +0800",
            "(from xutaosun@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u218fDuF021882; \n\tTue, 1 Mar 2016 16:41:13 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.22,522,1449561600\"; d=\"scan'208\";a=\"898261485\"",
        "From": "Xutao Sun <xutao.sun@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue,  1 Mar 2016 16:41:04 +0800",
        "Message-Id": "<1456821665-21831-4-git-send-email-xutao.sun@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1456821665-21831-1-git-send-email-xutao.sun@intel.com>",
        "References": "<1456804032-1682-1-git-send-email-xutao.sun@intel.com>\n\t<1456821665-21831-1-git-send-email-xutao.sun@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v7 3/4] driver/i40e: implement tunnel filter for\n\tIP in GRE",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Xutao Sun <xutao.sun@intel.com>\nSigned-off-by: Jijiang Liu <jijiang.liu@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 33 ++++++++++++++++++++++++---------\n 1 file changed, 24 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 7c22358..237c735 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -5797,6 +5797,12 @@ i40e_dev_get_filter_type(uint16_t filter_type, uint16_t *flag)\n \tcase ETH_TUNNEL_FILTER_IMAC:\n \t\t*flag = I40E_AQC_ADD_CLOUD_FILTER_IMAC;\n \t\tbreak;\n+\tcase ETH_TUNNEL_FILTER_OIP:\n+\t\t*flag = I40E_AQC_ADD_CLOUD_FILTER_OIP;\n+\t\tbreak;\n+\tcase ETH_TUNNEL_FILTER_IIP:\n+\t\t*flag = I40E_AQC_ADD_CLOUD_FILTER_IIP;\n+\t\tbreak;\n \tdefault:\n \t\tPMD_DRV_LOG(ERR, \"invalid tunnel filter type\");\n \t\treturn -EINVAL;\n@@ -5811,7 +5817,9 @@ i40e_dev_tunnel_filter_set(struct i40e_pf *pf,\n \t\t\tuint8_t add)\n {\n \tuint16_t ip_type;\n-\tuint8_t tun_type = 0;\n+\tuint8_t i, tun_type = 0;\n+\t/* internal varialbe to convert ipv6 byte order */\n+\tuint32_t convert_ipv6[4];\n \tint val, ret = 0;\n \tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n \tstruct i40e_vsi *vsi = pf->main_vsi;\n@@ -5833,16 +5841,19 @@ i40e_dev_tunnel_filter_set(struct i40e_pf *pf,\n \t(void)rte_memcpy(&pfilter->inner_mac, &tunnel_filter->inner_mac,\n \t\t\tETHER_ADDR_LEN);\n \n-\tpfilter->inner_vlan = tunnel_filter->inner_vlan;\n+\tpfilter->inner_vlan = rte_cpu_to_le_16(tunnel_filter->inner_vlan);\n \tif (tunnel_filter->ip_type == RTE_TUNNEL_IPTYPE_IPV4) {\n \t\tip_type = I40E_AQC_ADD_CLOUD_FLAGS_IPV4;\n \t\t(void)rte_memcpy(&pfilter->ipaddr.v4.data,\n-\t\t\t\t&tunnel_filter->ip_addr,\n+\t\t\t&rte_cpu_to_le_32(tunnel_filter->ip_addr.ipv4_addr),\n \t\t\t\tsizeof(pfilter->ipaddr.v4.data));\n \t} else {\n \t\tip_type = I40E_AQC_ADD_CLOUD_FLAGS_IPV6;\n-\t\t(void)rte_memcpy(&pfilter->ipaddr.v6.data,\n-\t\t\t\t&tunnel_filter->ip_addr,\n+\t\tfor (i = 0; i < 4; i++) {\n+\t\t\tconvert_ipv6[i] =\n+\t\t\trte_cpu_to_le_32(tunnel_filter->ip_addr.ipv6_addr[i]);\n+\t\t}\n+\t\t(void)rte_memcpy(&pfilter->ipaddr.v6.data, &convert_ipv6,\n \t\t\t\tsizeof(pfilter->ipaddr.v6.data));\n \t}\n \n@@ -5854,6 +5865,9 @@ i40e_dev_tunnel_filter_set(struct i40e_pf *pf,\n \tcase RTE_TUNNEL_TYPE_NVGRE:\n \t\ttun_type = I40E_AQC_ADD_CLOUD_TNL_TYPE_NVGRE_OMAC;\n \t\tbreak;\n+\tcase RTE_TUNNEL_TYPE_IP_IN_GRE:\n+\t\ttun_type = I40E_AQC_ADD_CLOUD_TNL_TYPE_IP;\n+\t\tbreak;\n \tdefault:\n \t\t/* Other tunnel types is not supported. */\n \t\tPMD_DRV_LOG(ERR, \"tunnel type is not supported.\");\n@@ -5868,10 +5882,11 @@ i40e_dev_tunnel_filter_set(struct i40e_pf *pf,\n \t\treturn -EINVAL;\n \t}\n \n-\tpfilter->flags |= I40E_AQC_ADD_CLOUD_FLAGS_TO_QUEUE | ip_type |\n-\t\t(tun_type << I40E_AQC_ADD_CLOUD_TNL_TYPE_SHIFT);\n-\tpfilter->tenant_id = tunnel_filter->tenant_id;\n-\tpfilter->queue_number = tunnel_filter->queue_id;\n+\tpfilter->flags |= rte_cpu_to_le_16(\n+\t\tI40E_AQC_ADD_CLOUD_FLAGS_TO_QUEUE |\n+\t\tip_type | (tun_type << I40E_AQC_ADD_CLOUD_TNL_TYPE_SHIFT));\n+\tpfilter->tenant_id = rte_cpu_to_le_32(tunnel_filter->tenant_id);\n+\tpfilter->queue_number = rte_cpu_to_le_16(tunnel_filter->queue_id);\n \n \tif (add)\n \t\tret = i40e_aq_add_cloud_filters(hw, vsi->seid, cld_filter, 1);\n",
    "prefixes": [
        "dpdk-dev",
        "v7",
        "3/4"
    ]
}