Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/109416/?format=api
{ "id": 109416, "url": "https://patches.dpdk.org/api/patches/109416/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20220407093642.44900-1-ke1x.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220407093642.44900-1-ke1x.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220407093642.44900-1-ke1x.zhang@intel.com", "date": "2022-04-07T09:36:42", "name": "net/bonding: fix rss key configuration when the key length is 52", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "26440b89b67511cb02c74f72e77630b2cdc12b65", "submitter": { "id": 2503, "url": "https://patches.dpdk.org/api/people/2503/?format=api", "name": "Zhang, Ke1X", "email": "ke1x.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20220407093642.44900-1-ke1x.zhang@intel.com/mbox/", "series": [ { "id": 22406, "url": "https://patches.dpdk.org/api/series/22406/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=22406", "date": "2022-04-07T09:36:42", "name": "net/bonding: fix rss key configuration when the key length is 52", "version": 1, "mbox": "https://patches.dpdk.org/series/22406/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/109416/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/109416/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 068F2A050B;\n\tThu, 7 Apr 2022 11:41:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9E7004068B;\n\tThu, 7 Apr 2022 11:41:42 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 46D3B40689\n for <dev@dpdk.org>; Thu, 7 Apr 2022 11:41:40 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Apr 2022 02:41:19 -0700", "from unknown (HELO localhost.localdomain) ([10.239.251.104])\n by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Apr 2022 02:41:17 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1649324500; x=1680860500;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=DjOrmo2+8lK8SLAYowNOgGeLTEJNQSrp6gCFnolWqeM=;\n b=S/Em+qTcfBz1PMBWFWJVEBMs6qThdtFwmtm9hKPtMf4XB1KmmCAGsMHw\n cA876jQv+K4pk+jcDrjuxu9pJ2Z4xPF7oCjS/J66KbE+MYaMisjoEyqqq\n 814/FpXvWBw5Y6Hu1Wzyilc7D/w4k4eSJctEwfUrNuTO5io2UhsOG7js8\n 2VPXvJlxdAhe6CAFEBkbw6lJcDeM2pLj2dKlafhnTa2tmo+0SuIho8EJi\n UwXhu/t3j46gAxNBy509vyPiU2OsvXVX9cnWpMl8sCEtPRr1gJKzfMzFM\n 916LP5Fn2E4HER7aGC/8ONcYLqS34xkfEUN6l77ThvNgWwKY77xSk63LN w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10309\"; a=\"248800663\"", "E=Sophos;i=\"5.90,241,1643702400\"; d=\"scan'208\";a=\"248800663\"", "E=Sophos;i=\"5.90,241,1643702400\"; d=\"scan'208\";a=\"697732612\"" ], "From": "Ke Zhang <ke1x.zhang@intel.com>", "To": "chas3@att.com,\n\thumin29@huawei.com,\n\tdev@dpdk.org", "Cc": "Ke Zhang <ke1x.zhang@intel.com>", "Subject": "[PATCH] net/bonding: fix rss key configuration when the key length is\n 52", "Date": "Thu, 7 Apr 2022 09:36:42 +0000", "Message-Id": "<20220407093642.44900-1-ke1x.zhang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "when creating a bonding device, if the slave device's rss key length\nis 52, then bonding device will be same as slave, in function\nbond_ethdev_configure(), the default_rss_key length is 40, it\nis not matched, so it should calculate a new key for bonding\ndevice if the deault key could not be used.\n\nSigned-off-by: Ke Zhang <ke1x.zhang@intel.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex b305b6a35b..4214b33f40 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -3617,13 +3617,13 @@ bond_ethdev_configure(struct rte_eth_dev *dev)\n \t\t\t internals->rss_key_len);\n \t\t} else {\n \t\t\tif (internals->rss_key_len > sizeof(default_rss_key)) {\n-\t\t\t\tRTE_BOND_LOG(ERR,\n-\t\t\t\t \"There is no suitable default hash key\");\n-\t\t\t\treturn -EINVAL;\n+\t\t\t\t/* If the rss_key_len is 52, it should calculate the hash key */\n+\t\t\t\tfor (i = 0; i < internals->rss_key_len; i++)\n+\t\t\t\t\tinternals->rss_key[i] = (uint8_t)rte_rand();\n+\t\t\t} else {\n+\t\t\t\tmemcpy(internals->rss_key, default_rss_key,\n+\t\t\t\t\tinternals->rss_key_len);\n \t\t\t}\n-\n-\t\t\tmemcpy(internals->rss_key, default_rss_key,\n-\t\t\t internals->rss_key_len);\n \t\t}\n \n \t\tfor (i = 0; i < RTE_DIM(internals->reta_conf); i++) {\n", "prefixes": [] }